From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 603C53AB28F for ; Mon, 6 Jul 2026 08:44:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783327465; cv=none; b=g+C8vccNoIpdX3tkkCqNQkJqI3fGC8EAd7OMW4mJWB0S7sgQMysvjVjDl8VInUJHZom1Zb+M3XTx7VzAUe0FK3yZs31HedGL21h7qo0Kac9mETVCQZPSefQAIG329XdB266nxxm/SU/1XVZUSqataW7Ixp0LRyplcJEvo7XQNEQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783327465; c=relaxed/simple; bh=oK0NQYPrvhisX4lCBFAC7QmI/WS2T6aMcGlWsYUvpP0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EceoKJiaDk0x6+/32PTQXfGpI/nORFzYhyF2RwA2tHPsAgNBTt74jkxuqTqrgjF7Wu3igBSv8nH+E3o4L29bQwuMfykSxEwGZYcuBxHpvpXTfptq+dMjGliNYRZ33RMTxxBuwJfMW2UkHOxQxlbtPTE9GWU6/gKJH8KM9O7NQrk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WBg5WWbV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KSNZOMPK; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WBg5WWbV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KSNZOMPK" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66641cmr3615550 for ; Mon, 6 Jul 2026 08:44:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= z7ewoKopFZWDSHXaKQpbm185Ui8l9dwnR4N9LGUyBmM=; b=WBg5WWbVCp2776Y0 GL5MhGPOmGbuGB1bYx85IqFwSE/YFbWe0cwzCSx1i3UCsmY/uYq7VE5bvpvbuy2S cog0YFdB57IQ+RCJd5CjP54/2i2MDUtgcHLzY12hTt4iWBp5e7t54UzUxGucerVZ /OxxEHL/x2bp3DLwZLsCk4+HjNqFxcz7IPRV+cTW/6XjwnGkHpGyyCK0gAEnBlN/ mDVZaZXzu6DT57CTUO77jc6AfsPXKofcXNOrlfdPrqpRTduzHt+66mSlxaaa9Baf AzjJR72lfUpiZHX1GVfYSkEUAavCp9yE/QHVdWMzPC6naR2UTdk5ArV0wpOixKxc ee/SAQ== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6td3db9s-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 08:44:15 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51bfe75b7dbso9114371cf.3 for ; Mon, 06 Jul 2026 01:44:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783327454; x=1783932254; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=z7ewoKopFZWDSHXaKQpbm185Ui8l9dwnR4N9LGUyBmM=; b=KSNZOMPK3QNXNKfcvRpkyviMnoGleNq1xWfURObce4W8yIegjIM6eIGZ/F6FSeNVDV FhULOqn4g7//t7+qxscBdNDbZNHnI9aPRFpCtS2kNFWWhYjzQYYCBUL2Lr1st0mPn4Ld Ih3nTPOiW37eWgWreqKsIJ2UwuLD4EhWWDZLoK4Noql1jWUijZUfrWEt3EXqsH52HQy6 IPNCpunhxbe0AhhMZVefHCLJQ7axlBmYk9QVgmX0Ci3Sv326MiP+Ya6qzVQv+zkTo7oK p4Bol48K3T6j5Td9lTa8a3TBCxv45BDkzapXmw5LXGHQRMSlLOeKfSwgVlpk1r+ghBe7 E83w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783327454; x=1783932254; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=z7ewoKopFZWDSHXaKQpbm185Ui8l9dwnR4N9LGUyBmM=; b=c622oFso/JyrJAm1UgzGxZU/PqNs0J/8GARobpZTLiKUjK5Dk+w/V8K77vRVKmpSAe K7Nzc8t1Q5Z/V2PzzKPPNtE1t8snzCqd4jldky5HP7xkEy9K23oCRNanWO6lx57sQGA/ FPP1z6kQPb4A5iBM6yQP/+TUflhdqCgqEHdlvNyM9beKErEtpadjM5paEdMgHAvInxB/ Grk2ka75KVs+23xM8Q0B0QUPwPFSN1j47br8jXid4libAUIw05JRE/ieSGVhiS7YAcbF S8a7FbwkMmtID5YswbCANER3ctIl7x2Bk9cHznCVGQ1u/xp/JR4Ga9BH6fwLBn/V/ULh TEUg== X-Forwarded-Encrypted: i=1; AHgh+Ro6yM2lh5E8KK+qXYw84kRT7J5990LlKi7BhfvHzhRwchH68Ewq4PiIVFh4EmlI79Xl3LG/BU9NQgCZWxA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/2ybmYJ82up7XOen7n9fxNidyXqEkloLCVSjXUC2go1R2skbz /Lm7zS9TThRBtBIMqv/bEsiAfvfKqK82n7d7vIBwJXM42BsgehDAJS/cXc06vtq5buqa/di0xGO +mwPgvx6LmXZG9e7GzCJo2kO7EUBMa1btvvse94AEN82wj324rnhRox2/InGxg6drsNc= X-Gm-Gg: AfdE7cm4OYgDWkvG4pzT4YLbm6yo2nziIr/8Eh2X4UNyOhQVyjfHV4Rttx4rf8k9Ahf BqAcq1uHRF3TM/z8MI55G/L2Kc/vt9WgtLeB+5rgW9Jrrnt6C/1Fi88hlvUdcwSPwnkmgB4/RqU xQQttpr2BF1Q2f8AuObuB2VYqxVh5t2oECiQE3ezjAzoehdcFeBIrY3rhlA08Ngk9S/iZXYny5t 1MYA317PhgujI/kotYrzYxMA4/3Iq6Sn3ztPTo8Ru9fgnKG92ojje95Qc+Phe7kSX3KeVEzJ1MN jFLQeutKAhPtV6/tPnHaOmYW5jI4B6M7XRRR39SecKbJ5E4LeOlr5Uqa7EJ9/s/dyQtFEfApkyU p5rnR9nPmKuAnMq+Wb1Vi81BaA3xNuCr1CsY= X-Received: by 2002:a05:622a:349:b0:51c:d16:b498 with SMTP id d75a77b69052e-51c4bf1e961mr84275931cf.10.1783327454337; Mon, 06 Jul 2026 01:44:14 -0700 (PDT) X-Received: by 2002:a05:622a:349:b0:51c:d16:b498 with SMTP id d75a77b69052e-51c4bf1e961mr84275551cf.10.1783327453661; Mon, 06 Jul 2026 01:44:13 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c12b62fc72dsm702939866b.63.2026.07.06.01.44.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jul 2026 01:44:12 -0700 (PDT) Message-ID: <93b78299-866f-4a3c-9423-a990d9a7d4cd@oss.qualcomm.com> Date: Mon, 6 Jul 2026 10:44:10 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 10/13] drm/msm: initialize LPAC ring To: Anna Maniscalco , Rob Clark , Will Deacon , Robin Murphy , Joerg Roedel , Sean Paul , Konrad Dybcio , Akhil P Oommen , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org References: <20260705-descriptive-name-lpac-upstream-v1-0-01d50c3e0c99@gmail.com> <20260705-descriptive-name-lpac-upstream-v1-10-01d50c3e0c99@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260705-descriptive-name-lpac-upstream-v1-10-01d50c3e0c99@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDA4NyBTYWx0ZWRfX00aKI666FUVz tdvZndYt6PDs3bunY4VRDIzS5xnwdaw1sv9cj/LBgXbag9VNJGT089pTvvGVmczqQ1oW0k/odiO f92cO2h94VCKg7i4TIRhC6O1HdZ/qWg= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDA4NyBTYWx0ZWRfXx0KD2ol24SSQ qInRUHas7OkjJseM0koaRe4zXTZ9VxHmz3BExy9gBqtumifTxLCSQlHHYmKdyZgauQAdkexCn4b Td0a1tuooZLkyGAr2+VatmCYsIMRjPXHwmBW0sGxj7mOr6lIbqyv7PLfROldwoBIH6+kMNP0NhD nzp5d4efe4ds99Wr9n3tHm4P6xx5UmaszMq22cqtqoL+0W4KmnRk1Jw6m2URkarfYpaRFEOtccY wF2ytfAruAlcIFkU3nM7w5l3nW1h4lJ4NcDuAeISSIu1jlPxehtXKA3HFbpnUw6X1exzzZZ9Wik blo0s9UB2yJY9Jrr/+bOnAaGA2hmOMNwGiY+jtRm02mWpRbVLuuuFAklOZKdi6fKid2fi4V2q56 HsD1NXzKU6yJmvo8bmgp/niFpXCwGgdDXCP6f7Gm/lBdaLI9rMoUM3byNLDzIUF92cUPlZ3/N3K oUYLes8hzZWfKuh8Jnw== X-Proofpoint-GUID: GoQXp7JDYs_yFibBlbvp7gzKFrWE84V9 X-Proofpoint-ORIG-GUID: GoQXp7JDYs_yFibBlbvp7gzKFrWE84V9 X-Authority-Analysis: v=2.4 cv=b9GCJNGx c=1 sm=1 tr=0 ts=6a4b6adf cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=pGLkceISAAAA:8 a=NiyOziKYwqrvXK6gfTIA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_02,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 malwarescore=0 adultscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060087 On 7/5/26 9:13 PM, Anna Maniscalco wrote: > Program all the register needed to start up LPAC and send initialization > sequence. > > Additionally, now that the LPAC ring is live, make the code aware of it. > > Signed-off-by: Anna Maniscalco > --- I believe some/all of these writes need to be guarded by if (has_lpac), as many GPUs lack these registers and there may be side effects on others [...] > a6xx_gpu->shadow = msm_gem_kernel_new(gpu->dev, > - sizeof(u32) * gpu->nr_rings, > + sizeof(u32) * (gpu->nr_rings + !!gpu->lpac_rb), Should we rename nr_rings to something like nr_XXX_rings where XXX is some uarch-generic (i.e. not SQE because we also support pre-a6xx) name for the main number cruncher? Konrad