From: zhouxianrong <zhouxianrong@huawei.com>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>, Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
<linux-kernel@vger.kernel.org>, <Mi.Sophia.Wang@huawei.com>,
<zhouxiyu@huawei.com>, <weidu.du@huawei.com>,
<zhangshiming5@huawei.com>, <won.ho.park@huawei.com>
Subject: Re: [PATCH v3] zram: extend zero pages to same element pages
Date: Mon, 23 Jan 2017 14:17:23 +0800 [thread overview]
Message-ID: <93bafc81-b690-dff1-73fc-924d9fd897aa@huawei.com> (raw)
In-Reply-To: <20170123061350.GE24581@js1304-P5Q-DELUXE>
i am not sure as well about reverse hurting cache.
On 2017/1/23 14:13, Joonsoo Kim wrote:
> On Mon, Jan 23, 2017 at 01:47:20PM +0900, Minchan Kim wrote:
>> Hello,
>>
>> When I look at first patch, I wanted to use increment loop but didn't
>> tell to you because that small piece of code is no harmful for readbility
>> to me so I want to keep author's code rather than pointing the trivial
>> which is just matter of preference out.
>>
>> Rather than readiblity, I suspect it might hurt performance and talked
>> with Namhyung but we cannot find anything decremental loop is bad
>> compared to incremental. Rather than, many articles have been said
>> decrement loop is faster like zhouxianrong's mentiond although I don't
>> think it makes marginal difference.
>>
>> Joonsoo, why do you think incremental is faster?
>> zhouxianrong, why do you think decrement loops makes cache problem?
>>
>> I'm okay either way. Just want to know why you guys think about it.
>
> Hmm... I guess that cache prefetcher works better for forward access
> but I'm not sure.
>
> Thanks.
>
>
> .
>
next prev parent reply other threads:[~2017-01-23 6:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 1:55 Minchan Kim
2017-01-23 3:02 ` Joonsoo Kim
2017-01-23 3:46 ` zhouxianrong
2017-01-23 4:47 ` Minchan Kim
2017-01-23 6:13 ` Joonsoo Kim
2017-01-23 6:17 ` zhouxianrong [this message]
2017-01-23 7:45 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93bafc81-b690-dff1-73fc-924d9fd897aa@huawei.com \
--to=zhouxianrong@huawei.com \
--cc=Mi.Sophia.Wang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=weidu.du@huawei.com \
--cc=won.ho.park@huawei.com \
--cc=zhangshiming5@huawei.com \
--cc=zhouxiyu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®