From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934208AbdEWHpK (ORCPT ); Tue, 23 May 2017 03:45:10 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:6802 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933816AbdEWHpH (ORCPT ); Tue, 23 May 2017 03:45:07 -0400 Subject: Re: [PATCH] scsi: hisi_sas: add null check before indirect pointer dereference To: "Gustavo A. R. Silva" , "James E.J. Bottomley" , "Martin K. Petersen" References: <20170522180029.GA19381@embeddedgus> CC: , From: John Garry Message-ID: <93be1808-c4f8-dbb4-f928-ac3a1f5f474c@huawei.com> Date: Tue, 23 May 2017 08:43:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20170522180029.GA19381@embeddedgus> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.181.157] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020201.5923E849.00F1,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: c61918cabfbcbec3db17d19cba4c3d32 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/05/2017 19:00, Gustavo A. R. Silva wrote: > Add null check before indirectly dereferencing pointer task->lldd_task > in statement u32 tag = slot->idx; > I don't think that this is a valid scenario, but protecting against a possible NULL dereference is prudent. Thanks > Addresses-Coverity-ID: 1373843 > Signed-off-by: Gustavo A. R. Silva Reviewed-by: John Garry