From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793367913; b=Hv/fqlFFI+j0aDLWBUVB7pZAp7ChBYjMxfwePE52H5KPvPfI3LCDAMIJaY5ifhMj1LCl aEQ1pKEz0A0vpFq59LEdGiI+IYxkBN6VS9adnJfgllQsqRJTJw78/GUblXSDkdvLAjlc2 0gbQ+PMwoT9lnlFtiFdu7MptHVewHrtQIjYF4NIiwZz9zeGzk+/uEojYJe94WZ2XnqMjk tUh+cY9Apj+qhm8yy3hehmL0TaIphMdtjYREnHaDz0FO8Krw+QvFJ7HGLedHGyKwqFUSz uqJsV/5LUjeMql2W9CmG0wvM9WIQanYMXvA/gDHSW7STyYGAuVdbmLfxV1y/Kxmq9Yw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793367913; h=Received:DKIM-Signature:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:From:Content-Language:Autocrypt:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=Ua86DBE7K2w9MgwViH777WjOtVhTW1SGSXoQsfO9QYo=; b=qNI7Fx6rKt9TScK4tcjQRWxFx4/qMZS47o+xXkZyU1ymGfApOG/2NQ15S09eMDTpGxMW sImyYQ24cIMyGdjNRO5apYbl5Y8a+eZV357S5/8CYomnpuZ/NHib7ffpSFHjKZwSaWZFn QBdk4Ry90V+oo2kFOHVwWknJ70ikZiqCmg6SI3O3HbjCStINY26J96WwrRDhnzQaTfFdt LCI+EQtKn5TGzb7RLWNl2JJBKZ890q9j4AUnXo5zdS93nXIXvZ+542Jvja47Gm09qTSNz RAZZxWWhv842B3NT/xgExs4sPloG9Z9RmoX9AL+vCmiikzIs8Sob7iTIqHwENsKhGZQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=VOUtw6Nb; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93EC5606A31D for ; Fri, 30 Oct 2026 13:45:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=VOUtw6Nb Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6DC0D1F000C1; Fri, 30 Oct 2026 13:45:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793367913; bh=Ua86DBE7K2w9MgwViH777WjOtVhTW1SGSXoQsfO9QYo=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=VOUtw6NbYviCEjsCFBP4JbDCcUZIUA5u6+Uyjavq22uCtmqVmIPGdExOTTEKx7QGi 5Eoowd6DsD3aME/PmJKyhELwcP0IrPFTWF9RgoeyOH6u92epgg6b2F/xJ3GSPf2Coo 9oseda28OJb6GDqwIKKBlJzhPiVKDw3dRjimbfxuRuycNPLPoAYbmOVnOs2ce7dDNV XArkC6cGYhUe4mN9CLWiTZNv8/Crdxx/Fev57MsP8vExJ5KElxuMG55J8OKfyJz67s NSiCGBmqfEq0EG0Yzxij6zeYbt2d03n/oAJrQANQ2x2OTmgAf/4zl5o9/2yC4UhgPe Ys45InIwyIVtg== Message-ID: <93c32c13-712b-43cb-9dcf-5f900227a2ed@kernel.org> Date: Fri, 30 Oct 2026 14:45:09 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 9/9] w1: w1_therm: leave the slaves of other families alone To: Greg Kroah-Hartman Cc: Josef Bacik , linux-kernel@vger.kernel.org, stable References: <20261027-llm-char-misc-w1-v1-0-d2e6bfafb6a4@linuxfoundation.org> <20261027-llm-char-misc-w1-v1-9-d2e6bfafb6a4@linuxfoundation.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: <20261027-llm-char-misc-w1-v1-9-d2e6bfafb6a4@linuxfoundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 27/10/2026 17:04, Greg Kroah-Hartman wrote: > From: Josef Bacik > > The file therm_bulk_read belongs to the bus master. Its callbacks walk > all the slaves of the bus and look at sl->family_data as if every slave > were a temperature sensor. A 1-wire bus can carry other devices too: > > - The family data of a slave which is driven by another driver, such as > w1_ds2433, w1_ds250x, w1_ds28e04 or w1_ds28e17, is a structure of that > driver. bulk_read_support() takes whatever is at the offset of > specific_functions for a pointer and dereferences it, and if the > result happens not to be 0, the callbacks write the state of the > conversion into that foreign structure. > > - For a slave without family data, which is the case for most of the > other drivers and for the default family, trigger_bulk_read() gives up > with -ENODEV. A single serial number chip on the bus is enough to > make the bulk read unusable for all the sensors. > > Only look at the slaves whose family is one of ours. A bulk conversion > now works on a bus with other devices. > > Fixes: 57c76221d5af ("w1_therm: adding bulk read support to trigger multiple conversion on bus") > Cc: stable > Signed-off-by: Josef Bacik > Signed-off-by: Greg Kroah-Hartman > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof