mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavan Kondeti <quic_pkondeti@quicinc.com>
To: Caleb Connolly <caleb.connolly@linaro.org>,
	Bjorn Andersson <andersson@kernel.org>
Cc: Maulik Shah <quic_mkshah@quicinc.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>, <stephan@gerhold.net>,
	<swboyd@chromium.org>, <dianders@chromium.org>,
	<robdclark@gmail.com>, <nikita@trvn.ru>,
	<quic_eberman@quicinc.com>, <quic_pkondeti@quicinc.com>,
	<quic_lsrao@quicinc.com>, <linux-arm-msm@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
	<stable@vger.kernel.org>
Subject: Re: [PATCH v2] soc: qcom: cmd-db: Map shared memory as WC, not WB
Date: Wed, 24 Jul 2024 10:31:51 +0530	[thread overview]
Message-ID: <93c41b18-2280-496b-8328-9f46a68a6220@quicinc.com> (raw)
In-Reply-To: <d17e7e6d-12dd-475d-80ae-fa48178d6cf2@linaro.org>

Hi Bjorn,

On Thu, Jul 18, 2024 at 09:41:34AM +0200, Caleb Connolly wrote:
> 
> 
> On 18/07/2024 08:03, Maulik Shah wrote:
> > From: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
> > 
> > Linux does not write into cmd-db region. This region of memory is write
> > protected by XPU. XPU may sometime falsely detect clean cache eviction
> > as "write" into the write protected region leading to secure interrupt
> > which causes an endless loop somewhere in Trust Zone.
> > 
> > The only reason it is working right now is because Qualcomm Hypervisor
> > maps the same region as Non-Cacheable memory in Stage 2 translation
> > tables. The issue manifests if we want to use another hypervisor (like
> > Xen or KVM), which does not know anything about those specific mappings.
> > 
> > Changing the mapping of cmd-db memory from MEMREMAP_WB to MEMREMAP_WT/WC
> > removes dependency on correct mappings in Stage 2 tables. This patch
> > fixes the issue by updating the mapping to MEMREMAP_WC.
> > 
> > I tested this on SA8155P with Xen.
> > 
> > Fixes: 312416d9171a ("drivers: qcom: add command DB driver")
> > Cc: stable@vger.kernel.org # 5.4+
> > Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
> > Tested-by: Nikita Travkin <nikita@trvn.ru> # sc7180 WoA in EL2
> > Signed-off-by: Maulik Shah <quic_mkshah@quicinc.com>
> 
> Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org>

Is it possible to include it in v6.11-rc?

Thanks,
Pavan

  reply	other threads:[~2024-07-24  5:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-18  6:03 Maulik Shah
2024-07-18  7:38 ` Pavan Kondeti
2024-07-18  7:42   ` Caleb Connolly
2024-07-18  7:55     ` Pavan Kondeti
2024-07-18  8:49       ` Caleb Connolly
2024-07-18  7:41 ` Caleb Connolly
2024-07-24  5:01   ` Pavan Kondeti [this message]
2024-07-29  3:58 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93c41b18-2280-496b-8328-9f46a68a6220@quicinc.com \
    --to=quic_pkondeti@quicinc.com \
    --cc=Volodymyr_Babchuk@epam.com \
    --cc=andersson@kernel.org \
    --cc=caleb.connolly@linaro.org \
    --cc=dianders@chromium.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nikita@trvn.ru \
    --cc=quic_eberman@quicinc.com \
    --cc=quic_lsrao@quicinc.com \
    --cc=quic_mkshah@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=stephan@gerhold.net \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®