mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Peng Hao <peng.hao2@zte.com.cn>, rkrcmar@redhat.com
Cc: x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM:X86 simply update A/D bits route
Date: Thu, 12 Oct 2017 16:18:47 +0200	[thread overview]
Message-ID: <93c484be-5b0b-0ad3-54f2-2920316bc262@redhat.com> (raw)
In-Reply-To: <1507843044-51761-1-git-send-email-peng.hao2@zte.com.cn>

On 12/10/2017 23:17, Peng Hao wrote:
> update_accessed_dirty_bits return 0 when dirty/accessed bits are
> not supported. So walk_addr_generic just call update_accessed_dirty_bits
> with supporting dirty/accessed bits.
> 
> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
> ---
>  arch/x86/kvm/paging_tmpl.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/paging_tmpl.h b/arch/x86/kvm/paging_tmpl.h
> index 86b68dc..b40f23e 100644
> --- a/arch/x86/kvm/paging_tmpl.h
> +++ b/arch/x86/kvm/paging_tmpl.h
> @@ -422,7 +422,7 @@ static int FNAME(walk_addr_generic)(struct guest_walker *walker,
>  		accessed_dirty &= pte >>
>  			(PT_GUEST_DIRTY_SHIFT - PT_GUEST_ACCESSED_SHIFT);
>  
> -	if (unlikely(!accessed_dirty)) {
> +	if (unlikely(!accessed_dirty && have_ad)) {
>  		ret = FNAME(update_accessed_dirty_bits)(vcpu, mmu, walker, write_fault);
>  		if (unlikely(ret < 0))
>  			goto error;
> 

At least you would have to remove the corresponding conditional in
update_accessed_dirty_bits, or change it to a WARN.

But I don't see the point really... why is it _better_ to check in
walk_addr_generic instead of update_accessed_dirty_bits?

Paolo

      reply	other threads:[~2017-10-12 14:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-12 21:17 Peng Hao
2017-10-12 14:18 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93c484be-5b0b-0ad3-54f2-2920316bc262@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peng.hao2@zte.com.cn \
    --cc=rkrcmar@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®