From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f44.google.com (mail-oo1-f44.google.com [209.85.161.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE9CE2DF144 for ; Mon, 3 Aug 2026 13:42:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785764531; cv=none; b=KBheN2BeM5NVsqIVAfTSBgAB+wj5E5WTJFn4twStOI9SyD5cskc0JEhTO7JkencLrQkM0MGRGt84qEuktJtqilE/+ysMlfuHkA+uED4v5NELzgJWq/Ndf7oHmOlLHg5tyQk+VSvAG6j9Tw4zRzGrW6zCwt5pCeVHNuirQK8YxaM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785764531; c=relaxed/simple; bh=oGmjKkdANcszWWeB7hVj7Roa1B24F4uV2BexEwNone8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ErUh+BBj1Gkk84/GYqbrc7R2m5ZFWEc+gAFg35s6N3o9/WyJlN4UPX5ydJV4R9Y/og1jfSKXfnzO3GSREr9YXyVqMO8KE2memZRcrfxjKyylIDd9F0n9ZQCMEdYuG1sRwFYTNuRCK9L/7/9mpXM6kFRD9MT9H9wcbKdy8USp010= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=YzbPaD11; arc=none smtp.client-ip=209.85.161.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="YzbPaD11" Received: by mail-oo1-f44.google.com with SMTP id 006d021491bc7-6ae542c486eso665541eaf.0 for ; Mon, 03 Aug 2026 06:42:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1785764527; x=1786369327; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=4pLzSiAF7h+MHs5QbYnjTgM1XAsnbqoEGTBpx5mogmc=; b=YzbPaD11JY0YwaLYuV9RidYx9eNGzdEZX19bWHsj1oi4ffVdwQmQxBdx2psC/C4H8J 7yWgvG7d5b7HC80k58HfqLaVmOJpcT0XFr2x3D+Fc+GLBQYiAkSW/uAtz8y3u9JlzbWi d2pFNDFns/js4NbjYk8RSiqX08ap/WpeDKhjny0eTSLCkoRGID2Z/I+3BhC0vz1j3Op+ rhFDS23bpGDcaI5Uf1viqla8lD2ArxTfMWQmxjwJKdPUdjI74B9uCbecMsH/dkWPmWxA kaEwGawPLkHP2kZ9AOg0Dh0wLvcB0lLcbG7+XzE8EfR5CrcoOsp6ofI/bDdaVERZGynD +DRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785764527; x=1786369327; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4pLzSiAF7h+MHs5QbYnjTgM1XAsnbqoEGTBpx5mogmc=; b=WTwVlUhpjDeRtTJzb1jWtU9xVNl03rfHp3QCbzilSzYB8Kly4riHneV6Bc3nBK0jbs Ya9nJnea2aBFTk6q2W59KrAVmh7uvPBLLqJbERTUp7T9dfQ1WmeawMW1mP0FvRTNL1s5 kAZQ7qjc8dAIRPu2pZ21ybOHC7A5FHshWLhkkFkuL6ki01/sPh8l5O0wjp5Y8InmS900 9fgYj55e3LMRvNCLbQY0Ieg+i7KgwGLr5MihsS5dcY88QlMCDkr2FktrkW4IRa3qI0s6 KpcN+iu9T4s2s0AMnCV3wRJwyRCbsZBUFFNGTt5kv6L2+1rfrKStgxbLmfIMA78j487L tTjw== X-Forwarded-Encrypted: i=1; AHgh+Rq79WGGyaP6ghxAImoQ8u2EDeIGIej67V4WWA65Ozo9TulHNDvOoJvqSZWKIsl7hRWdaM8nfoXYaOjcysY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5UFwVFS3ag4mMLR3TEez0uT+MmWBTXztVcZQdSAQi1w1xCfrD 9C8ccOYUUWZhJFJSY2sCYRJlOPXyF43XT8TMweXPbYIPXMqaTB3gbad3GiFFlGEP2pk= X-Gm-Gg: AR+sD112LG11lSuJ/OcN/NKEn09Q3DD3EaVws8XAeQBDyMWsZd+uiwov09wKZsaJUh3 Ar0JJdSVwFCI7zVYsGyQ0KdU0KgG6ee87kBsePmsmWKS4dFV70a4Jizks1YOAznu3RMvixt+ipI 3qhL0Vs8HmiF8sBczfh7VpP6dyCMN+E2II1V94zzwad1bpXBUrzB2oIsPmAL1X8mqrQPGr+FgIG lWIF2y5xUS59XQnGaRWji2oXVQxN+oWj5U4UO+bh8JaChKCO5XQUR7Z4Nqi8AcZ1Ls/EUSL4wDa SN+dN0G3+UhZO2UoLhN75skTObA8s368KoPIvHpYf2WTloQ3DlqOS5dlz45OP1Ft3+hqeEweaD1 sSFNl2Ssw3rrAB0dFfdXGVH4oO3DOgD3nwTjClLUVW8XoxWbVvGv172mTinSqRXHbjaTNydIES9 iGVv7Uym7Y0HV7laHgqx7kmEQRo4TnUFD7Kw76wMMWXML6SpvEIatJi7RP2Z4u9JdEmSqMKBF8s WN62LqcxUsaPXbyMIsQMtOziUT4UDHNpcMYnRFNlHTq2ZFMBkUDMuLY X-Received: by 2002:a05:6820:8106:b0:6a3:d77e:725a with SMTP id 006d021491bc7-6ae432bbc33mr13969350eaf.20.1785764526752; Mon, 03 Aug 2026 06:42:06 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:b8f7:1f5e:7c:a7d1? ([2600:8803:e7e4:500:b8f7:1f5e:7c:a7d1]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-458f6064d2esm9428382fac.3.2026.08.03.06.42.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 06:42:06 -0700 (PDT) Message-ID: <93d0f625-9a84-445c-98f8-fb3e569dc833@baylibre.com> Date: Mon, 3 Aug 2026 08:42:05 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] dt-bindings: iio: adc: ti,ads112c04: Add binding for ADS112C04 To: Kyle Hsieh Cc: Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liam Girdwood , Mark Brown , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260731-ti-ads112c04-driver-v2-0-aab0168c3c01@gmail.com> <20260731-ti-ads112c04-driver-v2-1-aab0168c3c01@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 8/2/26 9:32 PM, Kyle Hsieh wrote: > On Fri, Jul 31, 2026 at 9:52 PM David Lechner wrote: >> >> On 7/30/26 9:58 PM, Kyle Hsieh wrote: >>> Add device tree binding documentation for Texas Instruments ADS112C04 >>> I2C Analog-to-Digital Converters. >>> >>> These devices provide 4-channel, 16-bit delta-sigma ADCs with an I2C >>> interface, programmable gain amplifier (PGA), and data-ready (DRDY) >>> interrupt output. >>> >>> The binding uses child nodes to dynamically define the connected >>> single-ended or differential channels. >>> >>> Signed-off-by: Kyle Hsieh >>> --- >>> .../devicetree/bindings/iio/adc/ti,ads112c04.yaml | 122 +++++++++++++++++++++ >>> 1 file changed, 122 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads112c04.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads112c04.yaml >>> new file mode 100644 >>> index 000000000000..6a5ffda84b80 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads112c04.yaml >>> @@ -0,0 +1,122 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/iio/adc/ti,ads112c04.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Texas Instruments ADS112C04 ADC >>> + >>> +maintainers: >>> + - Kyle Hsieh >>> + >>> +description: | >> >> The | isn't needed in this case. (It is only needed if we needed >> to preserve formatting, or if there is a : in the text that would >> be interpreted as a dict key.) > Understood. I will remove the `|` from in v3. >> >>> + The ADS112C04 (16-bit) are precision analog-to-digital converters (ADCs) >>> + with an I2C interface. They feature a flexible input multiplexer, a >>> + low-noise programmable gain amplifier (PGA), two programmable excitation >>> + current sources, a voltage reference, and a precision temperature sensor. >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - ti,ads112c04 >>> + >>> + reg: >>> + maxItems: 1 >>> + description: I2C address of the device. >>> + >>> + interrupts: >>> + maxItems: 1 >>> + description: Data ready (DRDY) interrupt output. >>> + >>> + "#address-cells": >>> + const: 1 >>> + >>> + "#size-cells": >>> + const: 0 >>> + >>> + reset-gpios: >>> + maxItems: 1 >>> + description: GPIO connected to the RESET pin. Active low. >>> + >>> + avdd-supply: true >>> + dvdd-supply: true >>> + >>> + refp-supply: true >>> + refn-supply: true >>> + >>> + ti,refp-refn-resistor-ohms: >>> + $ref: /schemas/types.yaml#/definitions/uint32 >> >> As the bot said, don't need $ref here because it is a standard unit. >> (So don't forget to run `make dt_binding_check DT_SCHEMA_FILES=ads112c04` >> before sending.) > Yes, the `dt_binding_check` robot caught this right away. I will > removed the redundant `$ref` and resolved the warning locally. >> >>> + description: Resistance of the external resistor between REFP and REFN. >>> + >>> +patternProperties: >>> + "^channel@[0-9a-f]$": >>> + $ref: adc.yaml >>> + unevaluatedProperties: false >>> + properties: >>> + reg: >>> + items: >>> + - maximum: 15 >> >> This chip doesn't allow arbitrary combinations, so there >> are actually only 12 possible single-channel + diff-channels >> values. So maximum: 11 and channel@[0-9a-b] would make sense. > I will update the regex and set the reg maximum to 11 to strictly reflect > the 12 possible MUX configurations supported by the hardware. >> >>> + >>> + single-channel: >>> + maximum: 3 >>> + >>> + diff-channels: >>> + items: >>> + maximum: 3 >> >> For this chip, we should also have excitation-channels, excitation-current-nanoamp, >> and reference-sources. > I will add these properties to the binding to fully describe > the hardware capabilities. >> >>> + >>> + oneOf: >>> + - required: [ single-channel ] >>> + - required: [ diff-channels ] >>> + In the future, you don't need to reply to comments you agree with. Just reply to ones you don't agree with or have further questions on. We have way too many mailing lists emails to read, so anything we can cut out helps.