From: Joe Perches <joe@perches.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Ingo Molnar <mingo@kernel.org>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org,
Andy Lutomirski <luto@amacapital.net>,
Borislav Petkov <bp@suse.de>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86: Avoid pr_cont() in show_opcodes()
Date: Wed, 18 Jul 2018 01:41:07 -0700 [thread overview]
Message-ID: <93d979554b031755fafc03ded90560d3aaec40a3.camel@perches.com> (raw)
In-Reply-To: <8e7a3e658dbb928477639e0da67a5a204456b065.camel@perches.com>
On Tue, 2018-07-17 at 14:19 -0700, Joe Perches wrote:
> diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c
> []
> > @@ -93,26 +93,15 @@ static void printk_stack_address(unsigned long address, int reliable,
> > */
> > void show_opcodes(u8 *rip, const char *loglvl)
> > {
> > - unsigned int code_prologue = OPCODE_BUFSIZE * 2 / 3;
> > + const unsigned int prologue = OPCODE_BUFSIZE * 2 / 3;
>
> And this might be better as a #define to avoid
> a few more bytes of stack consumption.
Apologies for this silly suggestion.
automatics are not structs and gcc will eliminate
this declaration at all compiler optimization levels.
next prev parent reply other threads:[~2018-07-18 8:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-07 6:07 Tetsuo Handa
2018-07-07 11:12 ` Ingo Molnar
2018-07-07 13:54 ` Tetsuo Handa
2018-07-09 8:49 ` Peter Zijlstra
2018-07-09 13:22 ` David Laight
2018-07-09 19:11 ` Josh Poimboeuf
2018-07-10 11:55 ` Tetsuo Handa
2018-07-10 16:51 ` David Laight
2018-07-10 21:08 ` Tetsuo Handa
2018-07-16 12:47 ` Tetsuo Handa
2018-07-17 9:01 ` Rasmus Villemoes
2018-07-17 13:53 ` Tetsuo Handa
2018-07-17 14:24 ` Rasmus Villemoes
2018-07-17 20:54 ` Tetsuo Handa
2018-07-17 21:19 ` Joe Perches
2018-07-18 8:41 ` Joe Perches [this message]
2018-07-17 21:07 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93d979554b031755fafc03ded90560d3aaec40a3.camel@perches.com \
--to=joe@perches.com \
--cc=bp@suse.de \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®