From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933137AbdKGLWQ (ORCPT ); Tue, 7 Nov 2017 06:22:16 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:50406 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752069AbdKGLWO (ORCPT ); Tue, 7 Nov 2017 06:22:14 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20171107112212epoutp03442b9d2588f29b74a7a49cf9911c0685~0yd56dFng2687426874epoutp03I X-AuditID: b6c32a46-46dff700000010ca-46-5a019763fc66 Subject: Re: [PATCH 2/2] usbip: use monotonic timestamps To: Arnd Bergmann , Valentina Manea , Shuah Khan , Greg Kroah-Hartman Cc: Johan Hovold , Felipe Balbi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org From: Krzysztof Opasiak Message-id: <93e30403-bfe3-9547-122b-bb4955d264be@samsung.com> Date: Tue, 07 Nov 2017 12:22:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-version: 1.0 In-reply-to: <20171107104010.2884193-2-arnd@arndb.de> Content-type: text/plain; charset="utf-8"; format="flowed" Content-language: en-US Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprNKsWRmVeSWpSXmKPExsWy7bCmqW7ydMYogz9f1S3+TjrGbjH/ZpJF 8+L1bBZNN3pYLS7vmsNmsWhZK7PFlJfr2C3eXZrL7sDh8fvXJEaPnbPusntsWtXJ5jHvZKDH /rlr2D0+b5ILYIvisklJzcksSy3St0vgyvh75QBjwRO2ioWtt5gbGI+ydjFyckgImEic2P+G EcQWEtjBKDF/u2cXIxeQ/Z1R4tHeVkaYolNT+1kgijYwSryY6AJRdJ9RYvPi7cwgCWEBC4lT Sw+ygCREBJYwSux99hzMYRboZZS4NXcv0CgODjYBfYl5u0RBGngF7CTmbv3IBGKzCKhKPLjf ygZiiwpESFzY9JMJokZQ4sfke2CbOQVMJWZ/3QkWZxawknj2r5UVwhaXaG69yQJhy0tsXvOW GWSvhMBtNolZd8+wQ7zgItHd94QZwhaWeHV8C1RcWuLZqo2MEA3rGCUubH3ABpHYzSjR8jQa wraW+LNqIhvEBj6JjsN/2UGekRDglehoE4IwPSTmn4OqdpR4vryHBRJCmxklvqxsZpzAKDcL yT+zkPwwC8kPs5D8sICRZRWjWGpBcW56arFRgZFecWJucWleul5yfu4mRnCS0XLbwbjknM8h RgEORiUe3hkHGaKEWBPLiitzDzFKcDArifBuVwcK8aYkVlalFuXHF5XmpBYfYpTmYFES563b di1CSCA9sSQ1OzW1ILUIJsvEwSnVwFh5fn1+doL2rwn/fsRE/DTQ1vvaxGS68s5LEe8nOrf4 PTr375y+J/5RgpOW8+3afPsvRyW2ls/YdzFwbob6ERfRV2uPy+98Irwo1OhQ39FvCXpTrFfk Sq3Vvd5wu/Xr+w3S2ik5JkYzP+k9jklqK5x/+0n91yVqb3XLXCaV3Np3SZn3W6Pp7ANKLMUZ iYZazEXFiQAmv/b2LgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMLMWRmVeSWpSXmKPExsVy+t9jQd2k6YxRBqvXi1r8nXSM3WL+zSSL 5sXr2SyabvSwWlzeNYfNYtGyVmaLKS/XsVu8uzSX3YHD4/evSYweO2fdZffYtKqTzWPeyUCP /XPXsHt83iQXwBbFZZOSmpNZllqkb5fAlfH3ygHGgidsFQtbbzE3MB5l7WLk5JAQMJE4NbWf pYuRi0NIYB2jRPu2LhaQhJDAQ0aJz4syQWxhAQuJU0sPgsVFBJYwSpx9awPSwCzQyyixo+MX I0T3ZkaJ3v3ngcZycLAJ6EvM2yUK0sArYCcxd+tHJhCbRUBV4sH9VjaQElGBCIkNG/khSgQl fky+BzafU8BUYvbXnWDlzAJmEl9eHmaFsMUlmltvskDY8hKb17xlnsAoMAtJ+ywkLbOQtMxC 0rKAkWUVo2RqQXFuem6xUYFRXmq5XnFibnFpXrpecn7uJkZgVGw7rNW/g/HxkvhDjAIcjEo8 vDMOMkQJsSaWFVfmHmKU4GBWEuHdrg4U4k1JrKxKLcqPLyrNSS0+xCjNwaIkzsuffyxSSCA9 sSQ1OzW1ILUIJsvEwSnVwJjRJMrldCU+Y6XXwp8Kc7SKjtxRVSya6cURbH37UOnMzezhXzW4 FzvbrVtXYhfUxpv1P/zAmb3Hne0Nlz66v6q3/89C392Senvq5+dc8trsUZpdcqLGLdvM9Yf8 7xstreq6XE3TCmL2ljKte5l2IureMl4JBYYta0IiH4sK/ZWdt+boZgbxyUosxRmJhlrMRcWJ AOd7Y1eGAgAA X-CMS-MailID: 20171107112210epcas2p4ad5614b3ae7731a85de3c6fc53267590 X-Msg-Generator: CA CMS-TYPE: 102P X-CMS-RootMailID: 20171107104035epcas5p3b6a2556146de0340d762701451aeb1d2 X-RootMTR: 20171107104035epcas5p3b6a2556146de0340d762701451aeb1d2 References: <20171107104010.2884193-1-arnd@arndb.de> <20171107104010.2884193-2-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/07/2017 11:39 AM, Arnd Bergmann wrote: > This gets rid of the deprecated do_gettimeofday() function in usbip. > The comment above vgadget_get_frame() mentions that it suffers > from issues with the time jumps due to suspend and settimeofday, > so I'm changing it to use ktime_get_ts64() to use monotonic times > that don't have this problem. > > I couldn't tell whether we should use CLOCK_MONOTONIC or > CLOCK_MONOTONIC_RAW here, the difference being the exact rate > when correcting for NTP. I picked monotonic time since it doesn't > change the speed to the existing code and should be better > synchronized with other machines we talk to. > > Signed-off-by: Arnd Bergmann Looks good to me: Reviewed-by: Krzysztof Opasiak -- Krzysztof Opasiak Samsung R&D Institute Poland Samsung Electronics