From: Hongmei Xu <hongmei.xu@oss.qualcomm.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: phy: aquantia: Add support for 5GbaseR
Date: Thu, 24 Sep 2026 11:58:52 +0800 [thread overview]
Message-ID: <93e44830-d141-4ba5-8048-fbbaf4a2a63d@oss.qualcomm.com> (raw)
In-Reply-To: <9a79f51e-50ec-4df2-b908-71573c81b69e@lunn.ch>
Apologies for the careless submission. I will fix the changelog and
improve the commit description before sending v3. I will also ensure
patches go through internal review before posting upstream.
On 9/24/2026 12:02 AM, Andrew Lunn wrote:
> On Wed, Sep 23, 2026 at 04:24:24PM +0800, Hongmei Xu wrote:
>> Add support for 5GbaseR within Aquantia phy driver.
>>
>> Signed-off-by: Hongmei Xu <hongmei.xu@oss.qualcomm.com>
>> ---
>> Changes in v2:
>> - EDITME: describe what is new in this series revision.
>> - EDITME: use bulletpoints and terse descriptions.
>
> Did you even read your own patch?
>
> https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
>
> Please try to setup an internal review process, get other Qualcomm
> developers to point out all the problems with your patches before
> posting them for the world to see. Silly errors like this are not good
> for Qualcomm's reputation. Not that it is very good anyway within
> Mainline networking.
>
> Andrew
> ---
> pw-bot: cr
next prev parent reply other threads:[~2026-09-24 3:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 8:24 Hongmei Xu
2026-09-23 16:02 ` Andrew Lunn
2026-09-24 3:58 ` Hongmei Xu [this message]
2026-09-24 14:01 ` Andrew Lunn
2026-09-24 17:45 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93e44830-d141-4ba5-8048-fbbaf4a2a63d@oss.qualcomm.com \
--to=hongmei.xu@oss.qualcomm.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®