From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A8FCEE14C3 for ; Wed, 6 Sep 2023 20:20:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244334AbjIFUU7 (ORCPT ); Wed, 6 Sep 2023 16:20:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231742AbjIFUU5 (ORCPT ); Wed, 6 Sep 2023 16:20:57 -0400 X-Greylist: delayed 465 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 06 Sep 2023 13:20:52 PDT Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0070419A4; Wed, 6 Sep 2023 13:20:52 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id D74F7581298; Wed, 6 Sep 2023 16:13:06 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Wed, 06 Sep 2023 16:13:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1694031186; x=1694038386; bh=4D QpkjWhlnU/jRaOv5cdvU9fDBTugxJNiIsRvReEP5Q=; b=B/0zM6yqj9l7vx9sk4 eNPXsFyJgJcYg4fAxPjGMeD6oYtP6/MxD79AJifJc6ZZIbg+mQIpDI+/3AtxbMXL Ft+ECX9UGtQT7GxpY9ozLVVnKoVqFnPn/C80bZllK3I0G30w3ZKqUBKmhiHr6h5e JbQnidbQWuEToSqmf1ijLXt9v9+yug430tseWzahpScJ/yzr0b2VsubJ32jlVjLO fNeTuFnuVYgFGpobHBvSWM5bWV8j9vFTaZUaZp+uoEmgbJMhFn66NVUsrP9N4jcG CM2gndG8yjxDXyGIqAfjXWuUIOcz5hwk7rkgLk4PA5dCVijxnIem/aOR8qmnUM3E 22mg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1694031186; x=1694038386; bh=4DQpkjWhlnU/j RaOv5cdvU9fDBTugxJNiIsRvReEP5Q=; b=I8BDpAvNFOe3vb6c6SYdbJSOvTHjC jWkK5/vL46nf4cbwv89chgSRUHu2AT1z/fjDP17xKeV7WCqtCojQEBRQHvJFxgSb tIpLbt7U3dBKxMbux9t6OgCAPXWQnJR6qPGj/ooER3OhjYxkrcs7N32IWS57dspJ sf6VWA4CDw8XJkt/rehjNnKji16SP9FI6po/GK5/TFg/Ka6ux7G5ptXQqo33X6CW YLWWO8LMtA9ShXpPbjy0jvE/OPCDf4GJvD9n8KqQaVFyUz/KMTm6JmoTceSFx7MY yW/mSH2nI1cIVqM6XYRxgmSSDNEZIb6Tkk8/IgcpXdg/gjalJm348HHAw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudehfedgudeghecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedt keetffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 88D49B60089; Wed, 6 Sep 2023 16:13:06 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-711-g440737448e-fm-20230828.001-g44073744 Mime-Version: 1.0 Message-Id: <93e5e75d-3cfc-485b-9f81-54c82c58e24e@app.fastmail.com> In-Reply-To: <6406fb2e-afb2-461d-9bac-aa157cf6d16f@leemhuis.info> References: <20230901122424.247070-1-daniel@zonque.org> <6406fb2e-afb2-461d-9bac-aa157cf6d16f@leemhuis.info> Date: Wed, 06 Sep 2023 16:12:43 -0400 From: "Arnd Bergmann" To: "Thorsten Leemhuis" , "Daniel Mack" , "open list:GPIO SUBSYSTEM" , manikanta.guntupalli@amd.com Cc: linux-kernel@vger.kernel.org, stable@kernel.org, "Bartosz Golaszewski" , "Linus Walleij" , "Linux kernel regressions list" Subject: Re: [PATCH] gpio: zynq: restore zynq_gpio_irq_reqres/zynq_gpio_irq_relres callbacks Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 6, 2023, at 09:49, Thorsten Leemhuis wrote: > CCing Arnd (wrote the culprit), Linus (reviewed it), Bartosz (applied > it), and the regressions mailing list Thanks > On 01.09.23 14:24, Daniel Mack wrote: >> Commit f56914393537 ("gpio: zynq: fix zynqmp_gpio not an immutable chip >> warning") ditched the open-coded resource allocation handlers in favor >> of the generic ones. These generic handlers don't maintain the PM >> runtime anymore, which causes a regression in that level IRQs are no >> longer reported. >> >> Restore the original handlers to fix this. >> >> Signed-off-by: Daniel Mack >> Fixes: f56914393537 ("gpio: zynq: fix zynqmp_gpio not an immutable chip warning") >> Cc: stable@kernel.org > > This seems to be a regression report that comes straight with a fix, but > there wasn't a single reply yet afaics. :-/ Maybe the extended list of > recipients will get things moving. But to ensure this doesn't fall > through the cracks, I'll add it to the list of tracked regressions. I don't understand what the GPIOCHIP_IRQ_RESOURCE_HELPERS change intended to do in the first place: Manikanta's patch changed the behavior here with the addition of GPIOCHIP_IRQ_RESOURCE_HELPERS, while my patch was a cleanup that removed the dead code. Daniel's fix reverts both my cleanup patch and part of the original change, which may or may not be what we want here. Arnd