From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758636AbdCVBhF (ORCPT ); Tue, 21 Mar 2017 21:37:05 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:56919 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758419AbdCVBgx (ORCPT ); Tue, 21 Mar 2017 21:36:53 -0400 X-AuditID: b6c32a59-f79736d000001328-a2-58d1d52de87d Subject: Re: [PATCH v5 3/5] drm/exynos: dsi: Fix the parse_dt function To: inki.dae@samsung.com, jy0922.shim@samsung.com, sw0312.kim@samsung.com, airlied@linux.ie, kgene@kernel.org, krzk@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com Cc: javier@osg.samsung.com, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, a.hajda@samsung.com, andi.shyti@samsung.com, LW@KARO-electronics.de, Hoegeun Kwon From: Hoegeun Kwon Message-id: <93e79e92-a102-e931-8d63-843031848888@samsung.com> Date: Wed, 22 Mar 2017 10:36:44 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-version: 1.0 In-reply-to: <1488948852-5380-4-git-send-email-hoegeun.kwon@samsung.com> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrNJsWRmVeSWpSXmKPExsWy7bCmhq7u1YsRBo/eSljcWneO1aL33Ekm i+1HnrFavF/Ww2gx/whQ7MrX92wW75d3sVlMuj+BxeLN2zVMFi/uXWSx6H/8mtni/PkN7Bab Hl9jtbi8aw6bxYzz+5gsDjxZzmax9PpFJovWvUfYLWZMfslm8fLjCRYHEY8189Ywesyf/ojZ Y9OqTjaP7d8esHrc7z7O5LF5Sb3Hlv677B59W1YxenzeJBfAGZVqk5GamJJapJCal5yfkpmX bqvkHRzvHG9qZmCoa2hpYa6kkJeYm2qr5OIToOuWmQP0mpJCWWJOKVAoILG4WEnfzqYov7Qk VSEjv7jEVina0NBIz9DAXM/IyEjPxDjWysgUqCQhNePIrWNMBf+EKtr6yhsYO/m7GDk5JARM JLb8+8kMYYtJXLi3nq2LkYtDSGApo0TXjE8sIAkhgXYmicfXkrsYOcAaHncGQ9QsZ5SYtuAx O4Rzl1Fi6+vvYJOEBdwkVl0+wgiSEBG4xShxYeVMZhCHWWALk8S3juNMIFVsAroSX3uug9m8 AnYST2bcZAWxWQRUgWpOgMVFBSIkdtzoYYOoEZT4Mfke2EmcAh4Snx/cYASxmQUcJR4s2skK YctLbF7zFmyZhMBSDonzJz6yQ9wtK7HpANSfLhIvby5nhbCFJV4d38IOYUtL/F16ixHCrpe4 vOMkI8ScBkaJ/omzoYqMJe4/uMcMsYxPovf3EyaI+bwSHW1CECUeEvuv/oQqd5Q4dXAeNBhv MkpcWx4zgVF+FpJ3ZiF5YRaSFxYwMq9iFEstKM5NTy02LTDVK07MLS7NS9dLzs/dxAhO2FqR OxivzAw6xCjAwajEwyuw/GKEEGtiWXFl7iFGCQ5mJRHeu2eAQrwpiZVVqUX58UWlOanFhxhN gUE8kVlKNDkfmE3ySuINTcwMTYwsgdDc0FxJnDfKYGKEkEB6YklqdmpqQWoRTB8TB6dUA2PO 3j3FXE71CkyX/Pq+H6q7fNWJ8fqTE5Nv3uoVuVXjkxIfq/17qWJOrNoXK6WI1X8r+aznbZeY uL6qzeYnS/jEGx7Hj0uqPa8TO8s1U15L4qh+AesHzuxNocvf5mW7b0zV2VcU2THbmsPT8U1e c+xk5p76GWuvFjx4+Dgjjr3NKX5PRXeFlRJLcUaioRZzUXEiAJX/kXfuAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupileLIzCtJLcpLzFFi42I5/e+xgK7u1YsRBr+amCxurTvHatF77iST xfYjz1gt3i/rYbSYfwQoduXrezaL98u72Cwm3Z/AYvHm7Romixf3LrJY9D9+zWxx/vwGdotN j6+xWlzeNYfNYsb5fUwWB54sZ7NYev0ik0Xr3iPsFjMmv2SzePnxBIuDiMeaeWsYPeZPf8Ts sWlVJ5vH9m8PWD3udx9n8ti8pN5jS/9ddo++LasYPT5vkgvgjHKzyUhNTEktUkjNS85PycxL t1UKDXHTtVBSyEvMTbVVitD1DQlSUihLzCkF8owM0ICDc4B7sJK+XYJbxpFbx5gK/glVtPWV NzB28ncxcnBICJhIPO4M7mLkBDLFJC7cW8/WxcjFISSwlFFi0a8FUM59RolNr/eygFQJC7hJ rLp8hBEkISJwi1HizPQzUFU3GSWeLjvGAuIwC2xhkvj+/DsbSAubgK7E157rTCA2r4CdxJMZ N1lBbBYBVYlvHSfA4qICERLzn66CqhGU+DH5Htg6TgEPic8PbjCC2MwCthIL3q9jgbDlJTav ecs8gVFgFpKWWUjKZiEpW8DIvIpRIrUguaA4KT3XKC+1XK84Mbe4NC9dLzk/dxMjOB08k97B eHiX+yFGAQ5GJR7eEzIXI4RYE8uKK3MPMUpwMCuJ8N49AxTiTUmsrEotyo8vKs1JLT7EaAr0 yERmKdHkfGCqyiuJNzQxNzE3NrAwt7Q0MVIS522c/SxcSCA9sSQ1OzW1ILUIpo+Jg1OqgTF9 1xX7jYuX9PGsidZe17cj0Ge3x7W/r3YZPw/rmP/bMVfq8cqg5kczEpme5Cz5fMvojVTEzJB4 mXMMGQ+F5N2PZ8s638wrezN9Ee+OyNJXGYGnV7x82BO+RvXYRI3HkU8mL4pq1L9/vCVZxttw YWnwv5/nL2qtn8ki31JSVmt0Ynlz8Lcygf1KLMUZiYZazEXFiQB0xaSvHQMAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170322013645epcas5p3f880a1a9dd215e48fd04f3b09bb73e10 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?6raM7ZqM6re8G1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?SG9lZ2V1biBLd29uG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170308045502epcas1p2d2f7a0f768082b7a54b2ebe260e78436 X-RootMTR: 20170308045502epcas1p2d2f7a0f768082b7a54b2ebe260e78436 References: <1488948852-5380-1-git-send-email-hoegeun.kwon@samsung.com> <1488948852-5380-4-git-send-email-hoegeun.kwon@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi inki, Could you check the this patch? For reference, patch 1/5 and 2/5 have already been applied to Krzysztof tree. Best regards, Hoegeun On 03/08/2017 01:54 PM, Hoegeun Kwon wrote: > The dsi + panel is a parental relationship, so OF grpah is not needed. > Therefore, the current dsi_parse_dt function will throw an error, > because there is no linked OF graph for the case fimd + dsi + panel. > > Parse the Pll burst and esc clock frequency properties in dsi_parse_dt() > and create a bridge_node only if there is an OF graph associated with dsi. > > Signed-off-by: Hoegeun Kwon > Reviewed-by: Andrzej Hajda > Reviewed-by: Andi Shyti > --- > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 32 ++++++++------------------------ > 1 file changed, 8 insertions(+), 24 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c > index f5c04d0..2d4e118 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c > @@ -1652,39 +1652,23 @@ static int exynos_dsi_parse_dt(struct exynos_dsi *dsi) > if (ret < 0) > return ret; > > - ep = of_graph_get_endpoint_by_regs(node, DSI_PORT_OUT, 0); > - if (!ep) { > - dev_err(dev, "no output port with endpoint specified\n"); > - return -EINVAL; > - } > - > - ret = exynos_dsi_of_read_u32(ep, "samsung,burst-clock-frequency", > + ret = exynos_dsi_of_read_u32(node, "samsung,burst-clock-frequency", > &dsi->burst_clk_rate); > if (ret < 0) > - goto end; > + return ret; > > - ret = exynos_dsi_of_read_u32(ep, "samsung,esc-clock-frequency", > + ret = exynos_dsi_of_read_u32(node, "samsung,esc-clock-frequency", > &dsi->esc_clk_rate); > if (ret < 0) > - goto end; > - > - of_node_put(ep); > + return ret; > > ep = of_graph_get_next_endpoint(node, NULL); > - if (!ep) { > - ret = -EINVAL; > - goto end; > - } > - > - dsi->bridge_node = of_graph_get_remote_port_parent(ep); > - if (!dsi->bridge_node) { > - ret = -EINVAL; > - goto end; > + if (ep) { > + dsi->bridge_node = of_graph_get_remote_port_parent(ep); > + of_node_put(ep); > } > -end: > - of_node_put(ep); > > - return ret; > + return 0; > } > > static int exynos_dsi_bind(struct device *dev, struct device *master,