From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03B983793DB for ; Thu, 26 Mar 2026 16:17:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774541851; cv=none; b=WbtiwjJ4+ObBMiqdxMK16gVVEZuqkwYUFr9yvHyT3sVpVfo0STCTo4SJaK/cnMlOJO9MfXL5gQOqxSikL06/tZlAKarZPxAcbc4gtm6+prB+O34HYSiw4+BmGgYxe5bimCqdijzYvlhXBV0n2rNaTZXwtf6TSQwZBQzaiRrV1Wk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774541851; c=relaxed/simple; bh=tDSpY1TejOzwCOwtqoeML4zTegfiFUOPdcSviZLNYpA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=p07YcUFwkoshgxpjvcjGBoyjeG7DDJOodM8RYs26d6FkuNJ4vTa4/w21v4ogxnqnnzeaEXXzKupvWRDAewBMM+p1X90pxdCQy8EbIBekUuN7xzKIZ/RERPuUS49Soc06eBAFDk2krw4o7xvRHs4CumE//J5QXgixH5oTZDJEGas= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UZOKp+zi; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LSpcZ4nc; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UZOKp+zi"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LSpcZ4nc" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62QF9sjt2451576 for ; Thu, 26 Mar 2026 16:17:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rv1vMcePfr6BrkYqOV4MUVosqHAwIr52HNOnEfknKZQ=; b=UZOKp+zilRaU2178 BbFu5L+mi0L69kdCdbiLtEBcwTnSNldcrrujeuW8oU1nBR67UkQFbvcMPDsYgIr8 uYkNoKpaJsUviVpo+CQ4+Z8vDOj8TDHRHm2sxT37NlOzdZJoGx9+b6BmUNq2b/xE pN8odIvefr0tTz/4XYRhQb8ugqDsy+kAcou1gWX/1FihEC4gLU+wI60PveH8dLpM kzUhYHsgqqC5BljGyUZKfC4nHzJ9kjAxoTzl6hzTzAAXVpr+2sivwDhK3USjijls Ji0dBmZcBb4rcnpLMNhHkHk2LUQtSDxtz1Bz0ivnq3EVNtPV4uVwSTu4Fg0p1hPi 08Dqug== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d4q1t3kdp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 26 Mar 2026 16:17:28 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-82c1e1a6cfbso985454b3a.0 for ; Thu, 26 Mar 2026 09:17:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774541848; x=1775146648; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rv1vMcePfr6BrkYqOV4MUVosqHAwIr52HNOnEfknKZQ=; b=LSpcZ4ncs8ZWgHyCTwfQDUB+XU9VqLW+nBbe6MJ3nToBZG8SiNvJdclC8HjYmk0C3I seOk+oT43tFokC1+PmrUIO+loGr088rb8+t9Ns+rLP/IJWlLaIO+UyVsgXD5SDtl4l5b ZWXBoQ5nIkxpXfjRDslptj9ov/bvMS9XysgYsvdLKMRkZbgTOTnMI3tazUj4YKg2fGK2 UCtNRvL8EdMzzgHjEgjFMCoeyfygy0lduIefL+z2tXU/4/ny+ShmYkYBeCn5gFi24MWv QTEG5jHftwyJgLMLk2hoBc0s0G47egjmQfynhnPlephxMa2gFqgGEh0Nb8kyGko+odoZ C1XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774541848; x=1775146648; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rv1vMcePfr6BrkYqOV4MUVosqHAwIr52HNOnEfknKZQ=; b=k707Ytb5cSQeE7gVOtAnL5B0aWc3rZ0hNaJqbh70EkQY/nADIgg1xj3BebgmPoa7pE Zf5iFIAKNrEN74vD2PvF4hHmBw5uuRe5ksFuoSghyy5O51OBJ/Nr7h9O6BRGRvteY34z Sf28nmmIyNKWFYnpGpUeLZuTcunFYTj3/wqsUYEV5Ul8XAcZcktYSUAgs3C+xBWvDd3j 5SyO5iKqdPGE/FpNKugGsF966lWMUJYakwY9guCrE9F4yNuU+aE5mkpS4PA6NPng3Mnr p4UU7kVNNsOmydPCYoOv4GE2dW630STWwgYG1xZonVu0AEmY7AYBBdUfvpYlE+v15V52 xBfQ== X-Forwarded-Encrypted: i=1; AJvYcCWGaAPHCdPYl5sD/OLK73Bf0k9ANoLmRorhwI3WsObwAG0OsFVcDVbMgPwqRC91q7pAz9xLlL8F3KHyKOc=@vger.kernel.org X-Gm-Message-State: AOJu0YyyqN/DVVokgz2crojs11PuiSfZXeee7oMTMLXIudEQgz67k2hK J6MNWcJkjvoGozZVvl1snBehe31mKzs/18ilRpkxVw8V/01Ut8rx7u45cAOP02vNTwGYjREWFxr S/MXKpvSAAR/c3he4VHE+U+NwtawdSgcVwMuYwK6h2Kq6+IZv7elXHJqbcb3Dbn+40Fo= X-Gm-Gg: ATEYQzwxw6NRBIZpf5Ja6HXAfRkYg6dw8LaUSv+pBOf2ZirWQgupotyscQ7boyIsL8u fbBZ8BIBbGWch0Yb8Dq3aE/1HvNDCKuoRnCjL+TPVfAisUmBm/E3yfFPJNrP8QjoL+qPzMrSypO /sZdg8raSWXwAYIfGTwqf//6U8DAGvTsVNwJcT6kPescTtcAbzobWFK9bYsRV7hVmT2dcI0vwZ9 MjI3OjZPfutf1t9tX/4WpvITwjKL2JukgC3uSrwXwEI61qKhOYROjRufE3g95V2OOFk685Eknx+ anN4nVlLcVXCwMXlPocC8T6QOsy/RtwKx5VGq22gwNXm288NU3I8lQUqB6T61a8EtYrAmCE1l/x xbd0Qa/A+C94hOxNiagJ/M5Fe5HU3TGxn6SI42r86DKWWjY1TPDvceA== X-Received: by 2002:a05:6a00:1c98:b0:81f:44f9:7c1a with SMTP id d2e1a72fcca58-82c6de863demr8484554b3a.3.1774541847948; Thu, 26 Mar 2026 09:17:27 -0700 (PDT) X-Received: by 2002:a05:6a00:1c98:b0:81f:44f9:7c1a with SMTP id d2e1a72fcca58-82c6de863demr8484520b3a.3.1774541847445; Thu, 26 Mar 2026 09:17:27 -0700 (PDT) Received: from [192.168.29.82] ([49.43.230.194]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82c7d20fc0fsm3820103b3a.19.2026.03.26.09.17.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Mar 2026 09:17:26 -0700 (PDT) Message-ID: <93eacde8-41a4-44a2-a427-31e56cde9da0@oss.qualcomm.com> Date: Thu, 26 Mar 2026 21:47:21 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/2] ufs: core: Configure only active lanes during link To: Bart Van Assche , mani@kernel.org, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, nitin.rawat@oss.qualcomm.com References: <20260311060912.3139257-1-palash.kambar@oss.qualcomm.com> <20260311060912.3139257-2-palash.kambar@oss.qualcomm.com> <7922d339-5e85-4b12-9e32-f095e10b1211@acm.org> Content-Language: en-US From: Palash Kambar In-Reply-To: <7922d339-5e85-4b12-9e32-f095e10b1211@acm.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=e7cLiKp/ c=1 sm=1 tr=0 ts=69c55c19 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=PiB50hzSAWR/pQeEMnc2VA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=zigxiAtAAKp8hoqNa4IA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-GUID: 7JkEGq59Ipls3iO74HRiTI2nof8Uk2C6 X-Proofpoint-ORIG-GUID: 7JkEGq59Ipls3iO74HRiTI2nof8Uk2C6 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI2MDExNSBTYWx0ZWRfX5DpLYKsgJy36 MyJJh7DTvh1sgdVD5J7Th1p0JVlxLCsj2xLAZzmW8lipj0xxESPLJEeQqxx22bKOOCG0kuzfvCj 7GLUt+beYq5TM8y46q1/yQV+NTZCCnSsOELZPB/WY7RXj9WuYVbC1BtkwTFlVpyJB8PsQebrcSB /gpigTg7syV8WbSwreQtaeV3k0R9okwPWacmKBAVWz4OoCqDZSG5OMoZpBTP5nOlELUhwB6KSsu jdGQFodf/C9i9hzgYTxWPIOlblM01XYToP2m9CxEnC+B/DGg538/frakSdfbFiZiBt3kcrd5AKb HUAH1Xq+wMv7QDQa8hFAnJHq7WEAmRmZNQkPKIabLO0Z98AMzCIs2UXOZtU5eklqpzL4ckjmsIx Si5o7B7eS9jYvXtknw/GP4EZkk1nLnNm60sxGt/D9CvFNpIFE9LK/LDyga1rKk3jWN6tU2J0I1Q kx0eM6iYGCOywAJbAaw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-26_03,2026-03-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 spamscore=0 bulkscore=0 phishscore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603260115 On 3/23/2026 9:13 PM, Bart Van Assche wrote: > On 3/10/26 11:09 PM, palash.kambar@oss.qualcomm.com wrote: >> [ ... ] >> +static int ufshcd_get_connected_tx_lanes(struct ufs_hba *hba, u32 *tx_lanes) >> +{ >> +    return ufshcd_dme_get(hba, >> +                  UIC_ARG_MIB(PA_CONNECTEDTXDATALANES), tx_lanes); >> +} >> + >> +static int ufshcd_get_connected_rx_lanes(struct ufs_hba *hba, u32 *rx_lanes) >> +{ >> +    return ufshcd_dme_get(hba, >> +                  UIC_ARG_MIB(PA_CONNECTEDRXDATALANES), rx_lanes); >> +} > > The body of the above two functions is very short. Please remove these > functions and instead inline these function into their only caller. Sure Bart, will address this. > >> +static void ufshcd_validate_link_params(struct ufs_hba *hba) >> +{ >> +    int val = 0; >> + >> +    if (ufshcd_get_connected_tx_lanes(hba, &val)) >> +        return; > > Shouldn't it be reported if ufshcd_get_connected_tx_lanes() fails? > >> +    if (ufshcd_get_connected_rx_lanes(hba, &val)) >> +        return; > > Same question here - shouldn't it be reported if > ufshcd_get_connected_rx_lanes() fails? > > Why does this patch only call dev_err() in case of a mismatch instead of adjusting hba->lanes_per_direction or making initialization fail? Idea was just to warn and catch the failure scenario. But I agree on your feedback. Will fix it. > > Thanks, > > Bart.