From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1865DC433DB for ; Wed, 17 Mar 2021 11:55:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD5C864F6A for ; Wed, 17 Mar 2021 11:55:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231536AbhCQLzJ (ORCPT ); Wed, 17 Mar 2021 07:55:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:53188 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231528AbhCQLyn (ORCPT ); Wed, 17 Mar 2021 07:54:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A9A7164F2A; Wed, 17 Mar 2021 11:54:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615982083; bh=GmQ75fNkKGyxDuMPQluIYApqwkIGssLIIUJlFc8URIY=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=klF22XywXZ2p74BuS1cZYk4rx2lVXTSjaF4UPvdf0ZdDLHERXZmE3VUbgDFhgwNJM sqr3daV6+ZCq0pp6nayVGecVQ9oP3Ev3KK3EgvOOafkBWl7/JWzDD4CeJ1txqTZLS0 drGFXYFy72N0i6WHCTgzOCoZJeCv1cXq1QZ+ZM6BgniNoGrnKKx2faHRJact0l2cnd hTd90NwD/0LfxJOjBJpIbl2EOCrEO7S3HtcHqaYF0P/Su3shLKEMl/NGVtfCTK565y itUMTsETJ2UOqOlTOy0+yC8O0ywXGW/sCznXy+yq7ftMdjS5TcsTP81cdaTOPUyPuj q35SZ15wOoKwA== Subject: Re: [PATCH] omapdrm/dss/dsi.c:modify 'u32'->'int' To: ChunyouTang Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, tangchunyou@yulong.com, airlied@linux.ie, daniel@ffwll.ch, sebastian.reichel@collabora.com, laurent.pinchart@ideasonboard.com References: <20210317094852.424-1-tangchunyou@163.com> From: Tomi Valkeinen Message-ID: <93f05e6c-21ad-5b4b-3406-14229ea4feef@kernel.org> Date: Wed, 17 Mar 2021 13:54:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210317094852.424-1-tangchunyou@163.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 17/03/2021 11:48, ChunyouTang wrote: > From: tangchunyou > > 1.the type of mipi_dsi_create_packet id int > 2.u32 can not < 0 > > Signed-off-by: tangchunyou > --- > drivers/gpu/drm/omapdrm/dss/dsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c > index 8e11612..11c502d 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dsi.c > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c > @@ -2149,7 +2149,7 @@ static int dsi_vc_send_short(struct dsi_data *dsi, int vc, > const struct mipi_dsi_msg *msg) > { > struct mipi_dsi_packet pkt; > - u32 r; > + int r; > > r = mipi_dsi_create_packet(&pkt, msg); > if (r < 0) > I have already applies a similar patch "drm/omap: dsi: fix unsigned expression compared with zero". Tomi