From: Krzysztof Kozlowski <krzk@kernel.org>
To: Charan Pedumuru <charan.pedumuru@gmail.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mmc: ti,da830-mmc: convert text based binding to json schema
Date: Sat, 12 Jul 2025 10:29:42 +0200 [thread overview]
Message-ID: <93f7f1b7-8c04-4d0e-9e41-6127651bdca4@kernel.org> (raw)
In-Reply-To: <5d746239-83d2-4316-82e9-4e7ae4f3422e@gmail.com>
On 12/07/2025 10:22, Charan Pedumuru wrote:
>>> +
>>> +allOf:
>>> + - $ref: mmc-controller.yaml
>>> +
>>> +maintainers:
>>> + - Rob Herring <robh@kernel.org>
>>
>> No, I really doubt Rob cares about this hardware.
>
> I will remove Rob from maintainers and add Ulf under the maintainers.
This should be someone responsible for this hardware, not subsystem
maintainer.
>
>>
>>> +
>>> +properties:
>>> + compatible:
>>> + enum:
>>> + - ti,da830-mmc
>>> + - ti,dm355-mmc
>>> +
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + clocks:
>>> + maxItems: 1
>>> +
>>> + interrupts:
>>> + maxItems: 2
>>> +
>>
>> This wasn't in original binding. You need to document this in the commit
>> msg. Also, list the items.
>
> Sure, but what list of items for interrupts?
List as a verb. You need to list them.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-12 8:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 13:34 Charan Pedumuru
2025-05-23 15:44 ` Conor Dooley
2025-05-28 8:02 ` Krzysztof Kozlowski
2025-07-12 8:22 ` Charan Pedumuru
2025-07-12 8:29 ` Krzysztof Kozlowski [this message]
2025-09-07 6:53 ` Charan Pedumuru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93f7f1b7-8c04-4d0e-9e41-6127651bdca4@kernel.org \
--to=krzk@kernel.org \
--cc=charan.pedumuru@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®