From: Markus Elfring <Markus.Elfring@web.de>
To: Wei Yongjun <weiyongjun1@huawei.com>,
linux-arm-kernel@lists.infradead.org
Cc: Jassi Brar <jassisinghbrar@gmail.com>,
Michal Simek <michal.simek@xilinx.com>,
Wendy Liang <wendy.liang@xilinx.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next v2] mailbox: zynqmp-ipi: Fix NULL vs IS_ERR() check in zynqmp_ipi_mbox_probe()
Date: Wed, 29 Apr 2020 13:00:41 +0200 [thread overview]
Message-ID: <93fe8107-ffca-8006-4020-be3bd6edfc57@web.de> (raw)
In-Reply-To: <20200429093503.150485-1-weiyongjun1@huawei.com>
> So we should check whether the return value of devm_ioremap()
> is NULL instead of IS_ERR.
Will an other change description provide the preferred imperative wording?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=96c9a7802af7d500a582d89a8b864584fe878c1b#n151
Regards,
Markus
prev parent reply other threads:[~2020-04-29 11:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 7:30 [PATCH -next] mailbox: " Wei Yongjun
2020-04-29 9:35 ` [PATCH -next v2] mailbox: zynqmp-ipi: " Wei Yongjun
2020-04-29 11:00 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93fe8107-ffca-8006-4020-be3bd6edfc57@web.de \
--to=markus.elfring@web.de \
--cc=jassisinghbrar@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=weiyongjun1@huawei.com \
--cc=wendy.liang@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®