mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mattias Jacobsson <2pi@mok.nu>
To: <mario.limonciello@dell.com>, <dvhart@infradead.org>,
	<andy@infradead.org>
Cc: <2pi@mok.nu>, <platform-driver-x86@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH v4 4/8] platform/x86: dell-wmi-descriptor: use MODULE_DEVICE_TABLE() instead of MODULE_ALIAS()
Date: Tue, 19 Feb 2019 20:59:52 +0100	[thread overview]
Message-ID: <94088cad97f6db9f656c8a67fde35f2fcbbca7af.1550603967.git.2pi@mok.nu> (raw)
In-Reply-To: <cover.1550603967.git.2pi@mok.nu>

WMI drivers can if they have specified an array of struct wmi_device_id
use the MODULE_DEVICE_TABLE() macro to automatically generate the
appropriate MODULE_ALIAS() output. Thus avoiding to keep both the array
of struct wmi_device_id and the MODULE_ALIAS() declaration(s) in sync.

Change driver to use MODULE_DEVICE_TABLE() instead of MODULE_ALIAS().

Signed-off-by: Mattias Jacobsson <2pi@mok.nu>
Reviewed-by: Mario Limonciello <mario.limonciello@dell.com>
---
 drivers/platform/x86/dell-wmi-descriptor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/dell-wmi-descriptor.c b/drivers/platform/x86/dell-wmi-descriptor.c
index 072821aa47fc..14ab250b7d5a 100644
--- a/drivers/platform/x86/dell-wmi-descriptor.c
+++ b/drivers/platform/x86/dell-wmi-descriptor.c
@@ -207,7 +207,7 @@ static struct wmi_driver dell_wmi_descriptor_driver = {
 
 module_wmi_driver(dell_wmi_descriptor_driver);
 
-MODULE_ALIAS("wmi:" DELL_WMI_DESCRIPTOR_GUID);
+MODULE_DEVICE_TABLE(wmi, dell_wmi_descriptor_id_table);
 MODULE_AUTHOR("Mario Limonciello <mario.limonciello@dell.com>");
 MODULE_DESCRIPTION("Dell WMI descriptor driver");
 MODULE_LICENSE("GPL");
-- 
2.20.1


  parent reply	other threads:[~2019-02-19 20:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-19 19:59 [PATCH v4 0/8] platform/x86: wmi: add WMI support to Mattias Jacobsson
2019-02-19 19:59 ` [PATCH v4 1/8] platform/x86: wmi: move struct wmi_device_id to mod_devicetable.h Mattias Jacobsson
2019-02-19 19:59 ` [PATCH v4 2/8] platform/x86: wmi: add WMI support to MODULE_DEVICE_TABLE() Mattias Jacobsson
2019-02-19 19:59 ` [PATCH v4 3/8] platform/x86: dell-smbios-wmi: use MODULE_DEVICE_TABLE() instead of MODULE_ALIAS() Mattias Jacobsson
2019-02-19 19:59 ` Mattias Jacobsson [this message]
2019-02-19 19:59 ` [PATCH v4 5/8] platform/x86: dell-wmi: " Mattias Jacobsson
2019-02-19 19:59 ` [PATCH v4 6/8] platform/x86: huawei-wmi: " Mattias Jacobsson
2019-02-19 19:59 ` [PATCH v4 7/8] platform/x86: intel-wmi-thunderbolt: " Mattias Jacobsson
2019-02-19 19:59 ` [PATCH v4 8/8] platform/x86: wmi-bmof: " Mattias Jacobsson
2019-03-07  6:20 ` [PATCH v4 0/8] platform/x86: wmi: add WMI support to Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=94088cad97f6db9f656c8a67fde35f2fcbbca7af.1550603967.git.2pi@mok.nu \
    --to=2pi@mok.nu \
    --cc=andy@infradead.org \
    --cc=dvhart@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@dell.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®