From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3523632C92A for ; Sat, 25 Jul 2026 10:14:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784974447; cv=none; b=Qvk4V+Xj/+8lAGfvylfyjw2XYY0w2b9BVGvBd/OgjQbTIN35KzLfxqicaSRnpy7zg8CDghLFv+A9aSK/fHLmP8cf5jBVGNXODb4MRxwSif5+nJzLsFkUxV5CWfTSBwShjCs9GBR0T7JisXew56kSMm2I2O69wVBpjfr29VDzPRU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784974447; c=relaxed/simple; bh=CdTDJUcqSLsVPWjQw81bCST4cL8xQYNSY97v4bQRwj0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=F6qHHKvwrXP7DFDs/uMWwL4UtPSBduEp3l38yD8uS+8oMTdY8QfLoAD3IWPtWExnUbX9dHBq5p2R+WV832nx6xzcsMzHifHXmhKRsOj2tzUBKbAdOniMRMWkmKGIaK7lGzQRk7CB2YLoH79qAz65ATf77hpmtRW0weE0GfLsyKg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Q5pq4MhO; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Q5pq4MhO" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-5aebe49b227so295129e87.2 for ; Sat, 25 Jul 2026 03:14:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1784974444; x=1785579244; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=egMHTHxWFQyh6fekGfV4FZbVfp3OyPJ8sTvFYBVlJAE=; b=Q5pq4MhO8e1qstW4RVyOcVVr5LY0Eq4aPPA9O7I3SUM/JoIRqd5wxzSqcRmDZsjWTr oB5mU0BKdLmILNz/n2Cl/Km3dX2fhKpQh4Y7RaUhJL1t20E7p4PxBMjTzoEJAFcYhUuV 1QEcERXJyegjSrgA1EmS54Lo9VzOcFGzzHX6H3He1hwoA3cMrXl+OPVMWMqaPZSFK+WE C6g8SR2JbMRL0vtEowuKuYr6yriHNKfMvctgC5e9meRafTnP0RojDLpPg5678puQvFDi xjc2COCCfGf7uZMIkXR38DgLRUlgC1ifxP5UQCeqfxKz7uueNUprB8QZNtSI33jIbfcR CiCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784974444; x=1785579244; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=egMHTHxWFQyh6fekGfV4FZbVfp3OyPJ8sTvFYBVlJAE=; b=ZH3j93UeySflrHDsyzHhl95QQJW69/2N9UKDBn1nUSLTmJ/dGSalPWmmm93KvfHPnr TVHJmOffNrmX3mKs6DRx1F7PMS/ynLi9/wmZ/j+CbJyeARYg3AaNt+XaMLSWqp2NSdEC yn4K98PHwD44Eo3193HQuNJsmo1+eLJSirXD3CDia/FxRHColXkKxszrMoJgo7tDn9mQ knHh6Ovm7CMjGlZmkL60X9IZ4JmHuhLn0tB3jale6ai1lObeAraR+0lZGKTdnNY/BB6d VoGHbguKjqZCOFZLawjXMHMi3iGo/05KPx9bGoCB4LIs2N5uGCEU+DVuwo1URZcwSnvl qFqg== X-Forwarded-Encrypted: i=1; AHgh+Rog2R/Rm5O7Yrv7MJyC6BZz1UFkQOZDv5CvpG71nxkoXerXaPer0rbzrqKSpusH/84IAMuaPyvmHdXTDdw=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7xBZaMjCGAYLUcHMK/PdfOP5UdJ3UUQxsTYaeII0fa7pPyyTP 48rqOYxJWooef7I8ZUccq5aeT0DgM/SgOhnSPDq6od5HevkJTsMW5GcY9UQhtk2qA8o= X-Gm-Gg: AR+sD12JnsxySsD5ScTM1GgWRgZJWeRrloMqrHalm77BYUtCBezK8qfH5oAlht9R+Bc LrvkdwtWDvWLTWXCE3tQ4d4TifdAU5Zc/ddDuEJ+pN7nSb6rIyjUsEiufCpwwWuP6EyD2lxeLG9 xbxqpPuboqDTfRvFgsWYgXf87y09kBzqYxHPIbJHwgFIxOpZinxeChInawF0skKTeY2c4klnngI ZB4Joa7qgQrlxSJHDu+Nz3ng37z97Biv2jzaRabwbaA8G1zjRtwU/dTvAWwkbPZv2L+40CqSZia acQ22xL4pQLGbnrdMnVGgxOMDnXfIa7NsmxuxvAprD5Jqw1OpJ9aW1ybdnBdMlNWQzi6OxX4/RO X0KXgyVuEUr8/LLNAeyzA+00xGNvwii+NmRqJSwWOECh2MMa26cMFsZ9noFnQrL2Lb4X4gVXGM/ rDihgQMVduRwyqjhKWSR6wMtevSmORwyjGbndbmP/0MnKLvgLYvrphNMRYOkCDdKNMRK0= X-Received: by 2002:a05:6512:31d2:b0:5ae:b7c0:f231 with SMTP id 2adb3069b0e04-5b2c1b35f0amr212631e87.7.1784974444095; Sat, 25 Jul 2026 03:14:04 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b2be1d863bsm368823e87.53.2026.07.25.03.14.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Jul 2026 03:14:03 -0700 (PDT) Message-ID: <940d7267-cdfb-4dbd-9b4a-6fcd26c4fd58@linaro.org> Date: Sat, 25 Jul 2026 13:14:02 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] media: i2c: Add Samsung S5KJN5 image sensor driver To: Wenmeng Liu , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sakari Ailus Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260724-sk5jn5-v2-0-871d3b9a2e47@oss.qualcomm.com> <20260724-sk5jn5-v2-2-871d3b9a2e47@oss.qualcomm.com> From: Vladimir Zapolskiy In-Reply-To: <20260724-sk5jn5-v2-2-871d3b9a2e47@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/24/26 12:50, Wenmeng Liu wrote: > Add a V4L2 sub-device driver for the Samsung S5KJN5, a 50 MP GBRG 10-bit > RAW MIPI CSI-2 image sensor. The driver supports the 4096x3072 mode and > exposes the standard controls (exposure, gain, vblank/hblank, test > pattern). > > Signed-off-by: Wenmeng Liu > + > +static const struct s5kjn5_init_op s5kjn5_init_ops[] = { > + { .reg = CCI_REG16(0xfcfc), .val = 0x4000 }, > + { .reg = CCI_REG16(0x0000), .val = 0x000e }, > + { .reg = CCI_REG16(0x0000), .val = 0x38e5 }, One more comment: .val = S5KJN5_CHIP_ID > + { .reg = CCI_REG16(0x6018), .val = 0x0001 }, > + { .reg = CCI_REG16(0x7002), .val = 0x0408 }, > + { .reg = CCI_REG16(0x6014), .val = 0x0001 }, > + { .reg = CCI_REG16(0xfcfc), .val = 0x2002 }, > + { .reg = CCI_REG16(0x1e92), .val = 0x8000 }, > + { .reg = CCI_REG8(0x1e84), .val = 0x28 }, > + { .reg = CCI_REG8(0x1e85), .val = 0x2b }, > + { .reg = CCI_REG8(0x1e86), .val = 0x03 }, > + { .reg = CCI_REG8(0x1e87), .val = 0x20 }, > + { .reg = CCI_REG16(0xfcfc), .val = 0x4000 }, > + { .reg = CCI_REG16(0x7002), .val = 0x0008 }, > + { .delay_us = 5000 }, -- Best wishes, Vladimir