From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755866AbdDRH5d (ORCPT ); Tue, 18 Apr 2017 03:57:33 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:26529 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754751AbdDRH4e (ORCPT ); Tue, 18 Apr 2017 03:56:34 -0400 X-AuditID: cbfec7f4-f79806d000001279-dc-58f5c6ae6ca2 Subject: Re: [PATCH v2 3/3] arm64: dts: exynos: Add support for s6e3hf2 panel device on TM2e board To: Hoegeun Kwon , thierry.reding@gmail.com, airlied@linux.ie, robh+dt@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, kgene@kernel.org, krzk@kernel.org Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, javier@osg.samsung.com, andi.shyti@samsung.com From: Andrzej Hajda Message-id: <94152d85-5fb0-f5dc-045d-e6ee6c009f42@samsung.com> Date: Tue, 18 Apr 2017 09:56:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA01SWUwTURTNm2mnQ0NhKKiXRUlqjGAiaiRx4oJi/JgPjf6Q1C1a6QgECqYF 4vIBBiVsUsKiTYMsKqCkUShVFAIiFAouVEAoaMCFJSiVIouILEo7kPB37j3n3nPPyyNxcRff i4yIjmWV0bIoCSHkPWuZM29/3DIj3Tn1YAt9q70No6uNI3zaVpqB6EJjO5/+MGMjaFtZGkFb f+owWj04htNmc4WA1g/28OmumnyC1pjrMbrE0oHRN+uMAnqupoBHf//VyjtEMboCHWJeaPsF jL48lWCqf3/hM5/TTRhT9SCBMaiX+5mGcsRM6TedcDol3C9noyLiWeWOoPPC8KJBk+CS2fVy +7ggEfU5pyEnEqhAUHebBRxeD+8HnhBpSEiKqRIEtZ0GHldMIRjVpwhWJwr6RjGOKEUwUmxB XDGCQJ3e7VC5U3IYaC5xEB5UL4KyJ2OOxTj1EUFmUjZuVxGUPyxW9RF2LKKCIGn8vaPPo7aA tXcBs+N1lBQs+QbEadzgT87A8lEk6UQdhOZ/Z+1tnNoJmtwmjMO+UKX7idu9gEolYXbeiNn1 QG0EfQPORTgCGUPFiMPu8MNkWInmA6kprzBuNh3BpLpVwBW5CJYmNCvT+6DJ1MHn3Fwg+9kd nDMQQUqymJMwMHGjaGVpMORnda68ajMGDcN1vCzkq12TR7smhHZNiCKElyMPNk6lCGNVgQEq mUIVFx0WEBqj0KPlr/ZmyTT9HN1v2duIKBJJnEUP66elYr4sXnVF0YiAxCUeoor6GalYJJdd ucoqY84p46JYVSPyJnmSDSLh6x6pmAqTxbKRLHuJVa6yGOnklYj4i9Nspf98HdvXpvm0kOM+ dPS2W2SX59fFrnfeZZEG1xHb6T2hO6oKA0KGK2b/HvO07JO8vXtYXru5JbefPfkjwdf12wVr 8tbfZ/IeXZf72A7I7+1+6q9sSOwI1h1vHUroYLa6YReNlZNj2stEiPldHuv3ssTPovC+9sE8 6GKtGZXwVOGyXdtwpUr2HyOutupmAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrAIsWRmVeSWpSXmKPExsVy+t/xy7p6x79GGKydrWbRe+4kk8X2I89Y Ld4v62G0mH/kHKvFla/v2SzeL+9is3jzdg2TRf/j18wW589vYLfY9Pgaq8XlXXPYLGac38dk sfT6RSaL1r1H2C1+7prHYvHy4wkWBwGPNfPWMHrsnHWX3WPTqk42j+3fHrB63O8+zuSxeUm9 x5Z+oHjfllWMHp83yQVwRrnZZKQmpqQWKaTmJeenZOal2yqFhrjpWigp5CXmptoqRej6hgQp KZQl5pQCeUYGaMDBOcA9WEnfLsEtY8Hj4+wF5/krzr1jb2C8ydPFyMkhIWAiMe/mCyYIW0zi wr31bF2MXBxCAksYJRa8/MsO4TxjlPjbu5gVpEpYIEViddsksCoRgWuMErNWLWCEqDrKJDHr 2i9mEIdZ4BajxNf25cwgLWwCmhJ/N99kA7F5Bewkmt9dAIuzCKhKvLnxB2y5qECExMPOXewQ NYISPybfY+li5ODgFLCXOPo/FsRkFtCTuH9RC6SCWUBeYvOat8wTGAVmIWmYhVA1C0nVAkbm VYwiqaXFuem5xYZ6xYm5xaV56XrJ+bmbGIGxve3Yz807GC9tDD7EKMDBqMTDu2Lflwgh1sSy 4srcQ4wSHMxKIrwb9n2NEOJNSaysSi3Kjy8qzUktPsRoCvTBRGYp0eR8YNrJK4k3NDE0tzQ0 MrawMDcyUhLnLflwJVxIID2xJDU7NbUgtQimj4mDU6qB0Xxn07+j8yLv/tlQ837D8cV+U+yn eF+rZbrEpnHU0eG0aq2BZm6A3NXj13eU6gtt7d2WJT5z0Sb+8y/P+oSWt/yYwpapYZggapt2 S/HNt8CXRbUxJu0/tO/vTb++9tT+qwfPOKUVbdM8c/q7YP6H98JObJ+To9SM39c3qsrEC9Uc nvdSOdqSW4mlOCPRUIu5qDgRAIkJ7pUDAwAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170418075630eucas1p2490ca427440a09e0a28c86c5c7ff292d X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRvsgrw=?= =?UTF-8?B?7ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRtTYW1z?= =?UTF-8?B?dW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170417060220epcas5p42f6ed43d9db94779382e84a129b9da2d X-RootMTR: 20170417060220epcas5p42f6ed43d9db94779382e84a129b9da2d References: <1492408934-22096-1-git-send-email-hoegeun.kwon@samsung.com> <1492408934-22096-4-git-send-email-hoegeun.kwon@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18.04.2017 09:44, Hoegeun Kwon wrote: > On 04/18/2017 03:00 PM, Andrzej Hajda wrote: >> On 17.04.2017 08:02, Hoegeun Kwon wrote: >>> This patch add the panel device tree node for s6e3hf2 display >>> controller to TM2e dts. >>> >>> Signed-off-by: Hoegeun Kwon >> Maybe it would be good to remove te-gpios property - tm2/tm2e uses >> hardware trigger, so it is not necessary and generates useless interrupts. > Thanks for your review. > > I agree, but I thinks remove the te-gpio property after your patch [1] > has been merged. Patch [1] has been merged about month ago :) Regards Andrzej > > > [1] https://patchwork.kernel.org/patch/9625383/ > > Best regards, > Hoegeun > >> Beside this: >> Reviewed-by: Andrzej Hajda >> -- >> Regards >> Andrzej >>> --- >>> arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts >>> index 694717a..98ad094 100644 >>> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts >>> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts >>> @@ -52,6 +52,18 @@ >>> assigned-clock-rates = <278000000>, <400000000>; >>> }; >>> >>> +&dsi { >>> + panel@0 { >>> + compatible = "samsung,s6e3hf2"; >>> + reg = <0>; >>> + vdd3-supply = <&ldo27_reg>; >>> + vci-supply = <&ldo28_reg>; >>> + reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>; >>> + enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>; >>> + te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>; >>> + }; >>> +}; >>> + >>> &ldo31_reg { >>> regulator-name = "TSP_VDD_1.8V_AP"; >>> regulator-min-microvolt = <1800000>; >> >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > >