Re: [PATCH 10/10] ASoC: Intel: soc-acpi: Add CS35L56 Soundwire to TGL

[Richard Fitzgerald <rf@opensource.cirrus.com>]

On 21/02/2023 16:52, Pierre-Louis Bossart wrote:
> 
>> +static const struct snd_soc_acpi_link_adr up_extreme_cs35l56_sdw0_one[] = {
>> +	{
>> +		.mask = BIT(0),
>> +		.num_adr = 1,
>> +		.adr_d = cs35l56_sdw0_adr,
>> +	},
>> +	{}
>> +};
>> +
>> +static const struct snd_soc_acpi_link_adr up_extreme_cs35l56_sdw0_four[] = {
>> +	{
>> +		.mask = BIT(0),
>> +		.num_adr = 4,
>> +		.adr_d = cs35l56_sdw0_adr,
>> +	},
>> +	{}
>> +};
> 
> If the machine driver has support for the 2-amplifier configuration,
> shouldn't it be present here as well?
> 

Not necessarily.
It's not a setup we're currently using on this initial TGL
configuration.

The machine driver we'd expect to work on multiple hardware. The
counting algorithm has to go through "2" anyway, and the code to
handle that is so trivial we may as well include it.

>> +
>>   /* this table is used when there is no I2S codec present */
>>   struct snd_soc_acpi_mach snd_soc_acpi_intel_tgl_sdw_machines[] = {
>>   	/* mockup tests need to be first */
>> @@ -501,6 +546,18 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_tgl_sdw_machines[] = {
>>   		.drv_name = "sof_sdw",
>>   		.sof_tplg_filename = "sof-tgl-rt711.tplg",
>>   	},
>> +	{
>> +		.link_mask = BIT(0),
>> +		.links = up_extreme_cs35l56_sdw0_four,
>> +		.drv_name = "sof_sdw",
>> +		.sof_tplg_filename = "sof-tgl-cs35l56-sdw0.tplg"
>> +	},
>> +	{
>> +		.link_mask = BIT(0),
>> +		.links = up_extreme_cs35l56_sdw0_one,
>> +		.drv_name = "sof_sdw",
>> +		.sof_tplg_filename = "sof-tgl-cs35l56-sdw0.tplg"
>> +	},
>>   	{},
>>   };
>>   EXPORT_SYMBOL_GPL(snd_soc_acpi_intel_tgl_sdw_machines);