From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 044021DDC20 for ; Thu, 16 Jan 2025 11:30:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737027048; cv=none; b=JZz3gOr+kl0dSXSrvKVL+UKVQenRsjsrgvqg9MGvaFbcM7b/gmg0E9Ls2LYUXNeJ95HnrPsVPOLoFqxpX9G8ir3pqsAGVM9R0BNEaPleY3Nop/2LlXDYCxqQmlMU2807aTRjMnHkWa3Ce8HkT3LALsFd9PeWcfnPRevge4zKj9U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737027048; c=relaxed/simple; bh=kzDN9dmdAK48wXWx0awduq7CrBP6vYP35O8PwR+e9qk=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=U4ypsAIFb7TH8segbQEjZbazCnW/1lZb6PNCg4Q8J3vQ7h4dRxWoiHjFj6T6d7N3zkMjWjOwr87W1dzuDcVZlzAQdGa+GDFI8Q5axnpD1wklMHkbRyQhdTc0m8KqHJ502z5AQeNuWBJbpUGD7bl0+VOEMBHhrGV4iSr2FKOC3HU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=S5PRRw1E; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="S5PRRw1E" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-3862b40a6e0so484026f8f.0 for ; Thu, 16 Jan 2025 03:30:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1737027045; x=1737631845; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=kzDN9dmdAK48wXWx0awduq7CrBP6vYP35O8PwR+e9qk=; b=S5PRRw1En8G+21KOJC9ZD6IqUHXgz4xQLsvIBxr/XWZPdIgRHRo/eicNlgEHSbm1kb 1GSs0FuwZkJWhSTbI8sRnjw4lqGhGVOHWmzZ0yxkZ199QjpJ48qSkyfwlh0J7t2cDH16 5O+UvF7PGwbTxzl8xtZQjUu2yIhdNvIjWZaX7uFfOqe4w24yiEAkdt1+OoG+UHZ0ii6u 4l9rBpEwm0MJgnEvnBvLGqAb2KXZ1W7WasebdcT1tz8uneIWS4mZcpNqQUbB3A6WCvIU VaO0n04kdHOCGitjn0dYqnYnHbSiJdKfZFG5DzRhNNd9oYOuRAVQuWsx2j0NfW/la/bm m4Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737027045; x=1737631845; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=kzDN9dmdAK48wXWx0awduq7CrBP6vYP35O8PwR+e9qk=; b=rlIgFlwzI3x8folIs3DRdcnj6B9VpRhYZkeI+WKAr5T4Q4MxKg51I6MPjF+AG4Ru2o q0YcQ1ZMbtKXjejENAnRy5dD0pZ/Lx0nyHgKW1r9y8GraJvhjtCq0uAIxXqWEfzNraQm 6nVj2T0dLOOtj08IcLs6WqdKNj8mOI+9OFzMdqoAa3USEMhgqXAIHgiLo2JsEdmTO1gy pmWmjbMnTxDHtScTEsEEytzxpd0Nk1DBWWbruQzbWNIkKgWqB5cuOMM1a9F+vlKj4SAx UKBoB8OBCYOSzJteZLYK87Ysbil7PL7jf1Mf5VAr68XPMsQ+V60wO4tfuexv+VT+/syg sKGg== X-Forwarded-Encrypted: i=1; AJvYcCWkZi3j7LKo0t3pkJvXcxevfpG05P21amLkQTiSB13/Xk2LpE63+lqHhvufDeNKoBteKdwMay1SMxmxUYg=@vger.kernel.org X-Gm-Message-State: AOJu0YzQvNojoXFzkErdGxplsScnfMu5bJfqw/p63F+lk+w+9rPojJFs 7nZMuFUqsPgr6YtPFtjAVr0bGPcUEpm+XJFGuCovctuj21YNyc/D3VZs8pLUXUI= X-Gm-Gg: ASbGnctBmCOTJlxDEf9Lj3D1inY8FE+/JsPAhFuWYlN3vEf18/Q7J5ZH+3gQPOdnCpy grfscuLbTjB1uNQEQacoB0UMm5uqd3WVYvEKAVGmkrMz/Nybo4/9P8GGh9H96VinLyi/kNs0wFg sVpTb9WRibZm5gD0kT1p9soPn648IRBr7j3E8liPyO9WyCZHvgK7XffNk9UAn3IJNfvE1DxO9wp sgFBYV21z8igX2gqGfdLnOhupFm80tE+UAw7YL2hDctxYN/CRLD1Nit6KRbTA== X-Google-Smtp-Source: AGHT+IGsW7R8SXZiI21rLVry2LB3/IZkmamq2Z2hj3KPYHeT5ENtm5n56n32F1wCYQ4Tz4sR0OmrNQ== X-Received: by 2002:a5d:648b:0:b0:386:3e3c:ef1 with SMTP id ffacd0b85a97d-38a87312f36mr34852486f8f.35.1737027045345; Thu, 16 Jan 2025 03:30:45 -0800 (PST) Received: from [10.1.1.109] ([80.111.64.44]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-437c74ac707sm55516355e9.15.2025.01.16.03.30.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2025 03:30:44 -0800 (PST) Message-ID: <941c7920a7d07496222e6e93cb338ca6df38dc33.camel@linaro.org> Subject: Re: [PATCH v3] scsi: ufs: fix use-after free in init error and remove paths From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Alim Akhtar , Avri Altman , Bart Van Assche , "James E.J. Bottomley" , "Martin K. Petersen" , Peter Griffin , Krzysztof Kozlowski , Manivannan Sadhasivam , Mike Snitzer , Jens Axboe , Ulf Hansson , Eric Biggers Cc: Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, stable@vger.kernel.org Date: Thu, 16 Jan 2025 11:30:43 +0000 In-Reply-To: <20250116-ufshcd-fix-v3-1-6a83004ea85c@linaro.org> References: <20250116-ufshcd-fix-v3-1-6a83004ea85c@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.1-4 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2025-01-16 at 11:18 +0000, Andr=C3=A9 Draszik wrote: > Changes in v2: > - completely new approach using devres action for Scsi_host cleanup, to > =C2=A0 ensure ordering Just repeating this again due to updated recipients list: This new approach now means that Scsi_host cleanup (scsi_host_put) happens after ufshcd's hba->dev cleanup and I am not sure if this approach has wider implications (in particular if there is any underlying assumption or requirement for the Scsi_host device to clean up before the ufshcd device). Simple testing using a few iteration of manual module bind/unbind worked, as did the error handling / cleanup during init. But I'm not sure if that is sufficient testing for the changed release ordering. Cheers, Andre'