From: Jens Axboe <axboe@kernel.dk>
To: Jianchao Wang <jianchao.w.wang@oracle.com>
Cc: tom.leiming@gmail.com, bart.vanassche@wdc.com,
keith.busch@linux.intel.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 0/2] fixes for the updating nr_hw_queues
Date: Tue, 21 Aug 2018 09:02:33 -0600 [thread overview]
Message-ID: <94238d71-9f39-1378-5f86-9093d0d2cf32@kernel.dk> (raw)
In-Reply-To: <1534835704-3607-1-git-send-email-jianchao.w.wang@oracle.com>
On 8/21/18 1:15 AM, Jianchao Wang wrote:
> Hi Jens
>
> Two fixes for updating nr_hw_queues.
>
> The first patch fixes the following scenario:
> io scheduler (kyber) depends on the mapping between ctx and hctx.
> When update nr_hw_queues, io scheduler's init_hctx will be
> invoked before the mapping is adapted correctly, this would cause
> panic in kyber.
>
> The second patch fixes the following scenario:
> part_in_flight/rw will invoke blk_mq_in_flight/rw to account the
> inflight requests. It will access the queue_hw_ctx and nr_hw_queues
> w/o any protection. When updating nr_hw_queues and blk_mq_in_flight
> /rw occur concurrently, panic comes up.
This looks good to me know, I'll queue it up for some testing.
--
Jens Axboe
prev parent reply other threads:[~2018-08-21 15:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 7:15 Jianchao Wang
2018-08-21 7:15 ` [PATCH V4 1/2] blk-mq: init hctx sched after update ctx and hctx mapping Jianchao Wang
2018-08-21 7:15 ` [PATCH V4 2/2] blk-mq: sync the update nr_hw_queues with blk_mq_queue_tag_busy_iter Jianchao Wang
2018-08-21 15:02 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94238d71-9f39-1378-5f86-9093d0d2cf32@kernel.dk \
--to=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=jianchao.w.wang@oracle.com \
--cc=keith.busch@linux.intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®