From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754256AbcIEG2m (ORCPT <rfc822;w@1wt.eu>);
        Mon, 5 Sep 2016 02:28:42 -0400
Received: from b.ns.miles-group.at ([95.130.255.144]:44723 "EHLO radon.swed.at"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1750776AbcIEG2k (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 5 Sep 2016 02:28:40 -0400
Subject: Re: [PATCH] ubifs: compress lines for immediate return
To: Heiko Schocher <hs@denx.de>, linux-mtd@lists.infradead.org
References: <1473051597-30078-1-git-send-email-hs@denx.de>
Cc: Artem Bityutskiy <dedekind1@gmail.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        linux-kernel@vger.kernel.org
From: Richard Weinberger <richard@nod.at>
Message-ID: <94271caf-4852-1d08-c6a0-102aac22ab65@nod.at>
Date: Mon, 5 Sep 2016 08:28:05 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2
MIME-Version: 1.0
In-Reply-To: <1473051597-30078-1-git-send-email-hs@denx.de>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Heiko,

On 05.09.2016 06:59, Heiko Schocher wrote:
> fix the following code:
> 
> -ret = expression;
> -if (ret)
> -        return ret;
> -return 0;
> +return expression;

"Fix"? ;-)
What was broken?

I agree that we can write the expression in a different way, but is it really worth it?
Is this part of a tree-wide cleanup?

Thanks,
//richard