From: Daniel Drake <ddrake@baylibre.com>
To: D D <dhabal123@gmail.com>, Tomeu Vizoso <tomeu@tomeuvizoso.net>
Cc: simona@ffwll.ch, airlied@gmail.com,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] accel/rocket: Fix NULL deref and double-free in job submit error path
Date: Tue, 17 Nov 2026 16:35:10 +0000 [thread overview]
Message-ID: <9429350a-4c59-419c-80da-7f6d3768cfce@baylibre.com> (raw)
In-Reply-To: <CA+g3TbucTCsgvGaywNqyZdh5g-889zK06WZ57Mpxm1qOpgYTfA@mail.gmail.com>
Hi,
On 27/05/2026 15:33, D D wrote:
> Hi Tomeu,
>
> Two bugs in the job submission error path in rocket_job.c:
>
> 1) rocket_job_cleanup() unconditionally calls
> rocket_iommu_domain_put(job->domain), but job->domain is only
> assigned after all fallible operations in
> rocket_ioctl_submit_job(). On early failure, job->domain is NULL,
> causing a NULL pointer dereference.
>
> 2) rocket_copy_tasks() frees rjob->tasks on its error path but does
> not NULL the pointer. rocket_job_cleanup() frees it again,
> resulting in a double-free.
Please read the kernel docs on submitting patches, you cannot submit
them as attachments.
You also need to rewrite the commit messages to be easily readable by
overloaded kernel maintainers. If you are including 10+
function/variable names in a single paragraph, or translating C code
into English, it is a sign the commit message is not useful.
Thanks
Daniel
prev parent reply other threads:[~2026-11-17 16:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 14:33 D D
2026-11-17 16:35 ` Daniel Drake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9429350a-4c59-419c-80da-7f6d3768cfce@baylibre.com \
--to=ddrake@baylibre.com \
--cc=airlied@gmail.com \
--cc=dhabal123@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tomeu@tomeuvizoso.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®