From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Sergio Lopez <slp@redhat.com>,
gurchetansingh@chromium.org, tzimmermann@suse.de,
mripard@kernel.org, olvaffe@gmail.com, kraxel@redhat.com,
daniel@ffwll.ch, maarten.lankhorst@linux.intel.com,
airlied@redhat.com
Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux.dev,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/2] drm/virtio: introduce the HOST_PAGE_SIZE feature
Date: Wed, 24 Jul 2024 22:00:31 +0300 [thread overview]
Message-ID: <942afa37-a24c-48ed-ae10-c811849165bf@collabora.com> (raw)
In-Reply-To: <20240723114914.53677-1-slp@redhat.com>
On 7/23/24 14:49, Sergio Lopez wrote:
> There's an incresing number of machines supporting multiple page sizes
> and on these machines the host and a guest can be running, each one,
> with a different page size.
>
> For what pertains to virtio-gpu, this is not a problem if the page size
> of the guest happens to be bigger or equal than the host, but will
> potentially lead to failures in memory allocations and/or mappings
> otherwise.
Please describe concrete problem you're trying to solve. Guest memory
allocation consists of guest pages, I don't see how knowledge of host
page size helps anything in userspace.
I suspect you want this for host blobs, but then it should be
virtio_gpu_vram_create() that should use max(host_page_sz,
guest_page_size), AFAICT. It's kernel who is responsible for memory
management, userspace can't be trusted for doing that.
--
Best regards,
Dmitry
next prev parent reply other threads:[~2024-07-24 19:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 11:49 Sergio Lopez
2024-07-23 11:49 ` [PATCH 1/2] " Sergio Lopez
2024-07-23 11:49 ` [PATCH 2/2] drm/virtio: add VIRTGPU_PARAM_HOST_PAGE_SIZE to params Sergio Lopez
2024-07-24 19:00 ` Dmitry Osipenko [this message]
2024-08-05 9:14 ` [PATCH 0/2] drm/virtio: introduce the HOST_PAGE_SIZE feature Sergio Lopez Pascual
[not found] ` <CAAfnVBkWKn3+YEhNz0CTmw-T_jjL72axkWqYgkzkSa72t_Gf0A@mail.gmail.com>
2024-08-06 20:15 ` Rob Clark
[not found] ` <CAAfnVBki816fSPuQ_FcvuwYzbSwiS_WaYsGSA1AyitmAA5OsXg@mail.gmail.com>
2024-08-08 10:38 ` Sergio Lopez Pascual
[not found] ` <CAAfnVBkkste=HR2SKRBNWXKcunbA2iEP+rr9yhDy89+WZsYeQw@mail.gmail.com>
2024-08-22 15:29 ` Sergio Lopez Pascual
2025-04-02 16:38 ` Sergio Lopez Pascual
2024-08-05 16:24 ` Rob Clark
2024-08-08 11:15 ` Dmitry Osipenko
2024-08-12 18:22 ` Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=942afa37-a24c-48ed-ae10-c811849165bf@collabora.com \
--to=dmitry.osipenko@collabora.com \
--cc=airlied@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gurchetansingh@chromium.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=olvaffe@gmail.com \
--cc=slp@redhat.com \
--cc=tzimmermann@suse.de \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®