From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E9F627E076 for ; Thu, 28 May 2026 01:38:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779932296; cv=none; b=QuS4K11W22U4PnJEubOXFzrvBvdJyLbXIWwYN0UqfF/5/yqPRP7XXBR84evxGezDHGRgfww5YxwLp7U/JSEJoMbu0aX+Yhhs6b04FyG0yWrZWaREln5CB6xABLFesWIgx2/x408UJxqB4tmAQ8qSp6xLcdZ/2uXQrRLTvajf+/E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779932296; c=relaxed/simple; bh=qe3zyWvGadofixYtb9EnLb3GehJHODsiK13Z5ONXy9M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=d4HelzNjNH+M7qraSuucsYsLVD9N7xds3vLvpA9GO+uMzjwneLa58qXGsJCpXCxxrWGUdkaHmsUZtzwpCZCf8ekIAg4+HaegP2l1asgw6jaCEiUFjmmMCQrf2j/L8mXN41YOy2ogsydZ+5ON4c2Y2wN8YfyedufWXniMYjdH1NM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DwdrrleX; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DwdrrleX" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-83659d38e38so5086638b3a.1 for ; Wed, 27 May 2026 18:38:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779932295; x=1780537095; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=rwygTp2mARrzZlBrAwz1tP6ZHcucWtK2gK/Pcd3NLTA=; b=DwdrrleXb/YjmY2kTF1WesOIHo7HzSooB4cEurlThYlkTyloDByGa3nOoowP1TXWGC r6y0eLvt1LW2Ga3eNW7nxr+wlPtKYnOIVNa3trxqYNCfZvdzFLQvgonqn8CwKFcxmI5Y icN2TNsQkR95fan27IjRq3LwNF5TzKNxKDS0t0rMdZ67vs79xcclBsSh2rPnbuH66VRy 7s6Qo4C47Ft8inw9bqNX96SMnRomz9IDqJK25GWXIjkTqKpQzx/5OXJMrHVH3zHOBD+B TNxlkjuyAyRoetMqB6M2GPDfSkznDEV7FyzWVHd8q97JoZbp0PdLLZRk6RhypIoSPq88 tPQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779932295; x=1780537095; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=rwygTp2mARrzZlBrAwz1tP6ZHcucWtK2gK/Pcd3NLTA=; b=TPpGVShcaLOFDh3isYX2xrA4r1SsRCk/7lFkZAps1RfdTkxhRDkHQSvbccsIDaKHVw YJjmm5jnkJZ9Ax8RUX3iIRU5RdV/l7CilIZuYWbU58rXruNX2/RAQPxjPonQ3DebHmzy bgCFtfu1WgTuV0kmI0BBuEHltIrvpKti8DDPGVNX7zHQHWOxW0gjUAzNxiUWjDQLDA5l 023nsF6GTWdJrHXqaYmgnt1mUhYIOSFiOYJQP+5vUDqi9n9CeIGd6kDdBhTUvXNAzWli yq58ci2qXcDymX/gaPF1LKCtljnj8Kn7zW5mKsBrzm1asf9Jlp5YaRCPNKmkoI48EAAH mN5A== X-Forwarded-Encrypted: i=1; AFNElJ8IAZKuaA4NG3pRR+Wateci61ZTu60ON7rO2tGbphe0DMOmYXXqgzzDZCttovk9CuGFpVYNLMwjpIl4b+4=@vger.kernel.org X-Gm-Message-State: AOJu0YxK3jR3HpewKaTMabRjCGVSs+ugEYneS4bkPJorAjPhHJ9aVDeZ VLljJnf5JjGJ0m4XYIz9TqGgwd4V5ClO9T5Cze5i4HowO08RU32tEY07 X-Gm-Gg: Acq92OFepkIc2cj2wfp8ZtGwId+rADsRiHyHHrzbORMWsGStgubUQtnJs6kSj9t7aR7 76tEY5l4ki5+ejhuepRfyHD4pFgOS/25fpcQGFtAUzAGF1KUNv09hkT8GpK0AjYGkdJkxCblAAH s7rhv0RdhbNqUhjjZwr+4DH5Kka2vvF25lWs/WckrRbhCunbzq5PBnhZjbLf7F35RFbZ60gLDrT mEnDnltLjQOBGxFBlBRujKJRj09H5hDy/tZelYSXz2p65sHFSiMUKVyxS8frIsju+0RbimtG8TN mfPDU83pdKn9jDU4ACGIzvfIm07MQByAeOfYa/DZcyGd87+Pn24RxykSFWsXVXlex2Btuu+gqlV 0mNJyrUgrF89pcv01dHqP27yHmh/NYScghjeZReyzA+XAgraBpuoP+R5cASax7loeUc8BraztqH YQD93EozIrmVGkPjNavafWHFM1UEORQO1ZS/kq+/e3/RfrZ9re4Gw4iDARMRlI X-Received: by 2002:a05:6a00:1a0d:b0:841:edbf:6425 with SMTP id d2e1a72fcca58-841edbf656emr1068316b3a.3.1779932294619; Wed, 27 May 2026 18:38:14 -0700 (PDT) Received: from [100.82.106.192] ([203.208.167.149]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-841d70b855csm3482467b3a.38.2026.05.27.18.38.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 May 2026 18:38:14 -0700 (PDT) Message-ID: <942dd4eb-8a5b-45f9-b0f2-fb0ccc1d453e@gmail.com> Date: Thu, 28 May 2026 09:38:09 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 0/1] nvme-pci: detect I/O queue depth changes after reset To: Christoph Hellwig Cc: kbusch@kernel.org, axboe@kernel.dk, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Guzebing References: <20260527075320.3178600-1-guzebing1612@gmail.com> <20260527131951.GA11071@lst.de> From: guzebing In-Reply-To: <20260527131951.GA11071@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit 在 2026/5/27 21:19, Christoph Hellwig 写道: > On Wed, May 27, 2026 at 03:53:19PM +0800, guzebing wrote: >> This RFC instead takes the smaller approach of detecting the reset-time >> CAP.MQES change and making it visible. If the live I/O queue depth >> shrinks, reset recovery is failed before recreating I/O queues. If it >> grows, the driver warns and continues with the existing queue resources. > > Unlike the other version this at least sounds doable without creating > a complete mess. So if we can live with this version that'd make me > much happier. Thanks, Christoph. Yes, that is the direction I would like to take here. The goal of this RFC is to avoid the live queue-depth resize path for now and keep the reset recovery policy explicit: fail reset before recreating I/O queues if the CAP.MQES-derived depth shrinks, and warn but keep using the existing queue resources if it grows. I will keep this lightweight approach unless there are objections, and will wait a bit for other comments before sending a non-RFC version. Thanks, Guzebing