From: Sander Eikelenboom <linux@eikelenboom.it>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: David Vrabel <david.vrabel@citrix.com>,
konrad.wilk@oracle.com, <hpa@zytor.com>, <mingo@redhat.com>,
<tglx@linutronix.de>, <xen-devel@lists.xenproject.org>,
<luto@amacapital.net>, <linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH] hypervisor/x86/xen: Unset X86_BUG_SYSRET_SS_ATTRS on Xen PV guests
Date: Sat, 2 May 2015 14:10:40 +0200 [thread overview]
Message-ID: <943161960.20150502141040@eikelenboom.it> (raw)
In-Reply-To: <55435782.3040506@citrix.com>
Friday, May 1, 2015, 12:37:54 PM, you wrote:
> On 30/04/15 20:08, Boris Ostrovsky wrote:
>> Commit 61f01dd941ba ("x86_64, asm: Work around AMD SYSRET SS descriptor
>> attribute issue") makes AMD processors set SS to __KERNEL_DS in
>> __switch_to() to deal with cases when SS is NULL.
>>
>> This breaks Xen PV guests who do not want to load SS with__KERNEL_DS.
>>
>> Since the problem that the commit is trying to address would have to be
>> fixed in the hypervisor (if it in fact exists under Xen) there is no
>> reason to set X86_BUG_SYSRET_SS_ATTRS flag for PV VPCUs here.
>>
>> This can be easily achieved by adding x86_hyper_xen_hvm.set_cpu_features
>> op which will clear this flag. (And since this structure is no longer
>> HVM-specific we should do some renaming).
> Applied to for-linus-4.1b, thanks.
> David
Also works fine here.
Thanks Boris !
--
Sander
prev parent reply other threads:[~2015-05-02 12:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 19:08 Boris Ostrovsky
2015-04-30 19:17 ` Andy Lutomirski
2015-04-30 19:30 ` Boris Ostrovsky
2015-04-30 19:35 ` Andy Lutomirski
2015-04-30 22:23 ` Boris Ostrovsky
2015-05-01 10:37 ` [Xen-devel] " David Vrabel
2015-05-02 12:10 ` Sander Eikelenboom [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=943161960.20150502141040@eikelenboom.it \
--to=linux@eikelenboom.it \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=hpa@zytor.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®