From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1E75CA5A for ; Mon, 29 Jun 2026 02:08:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782698907; cv=none; b=EIml6Alksg2jvZeVT6GvjSOjAD5pHI2Ib+j53iD57voOHLSAr1VsQo1yjKuhMH7VDPf0DJxTJ3sPSRMmUkk8CljZxkM+/EANOldeUMLIoZNEVWFODBMaQW9CVjoGZsQl8YRr8pBCDI//okQ8JJRvcjLt1W9A69QBGM0n3CSslvE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782698907; c=relaxed/simple; bh=trOx6KMkTWjUnkalk6/gDNlQpuLuChdQHMKM6WK2fMw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=h/ECgi2CJDlTgolqjOGYrf9T0qEV22p3om0TOhm3WB9k3zv7jHV7uFjZuCXrJl14jLVMZzAqvQzOnC+6jarM1ssw//YSe+QrbsJX5hkdG2yusWA5X9exfER2NN4tB6Qh5y6n0gqm+vk0tO7e1AOxQD3mX+MZg/4gnBvMzUkCjTw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WLTkKNL/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DXcl8dLM; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WLTkKNL/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DXcl8dLM" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65SM93RY955941 for ; Mon, 29 Jun 2026 02:08:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tQPFfKAfuAvHuuAQ/jaQ27ZsG9qI5Y1lwfUzTW083pY=; b=WLTkKNL/4couuf/g 52YliDdMBEeXnXG9GQVG/EBQZLZJWWenPC7RNUWRCVkvpzRBOzFh7wheO2cetdFA ehSCQ4sckaeTOSOUB4QyGGplx/wx+p0wGqz+hv+fLPSd0RzwpZt23Ct777WyjJSs F8Z3UBSrMWUIHfhgcLTLg4QQE3r3awM79nkV5BvrubcGx+Hyhv14VKrdA+mw3bBf CFlmHv5P6j3tQRoWRre0cMuNJ5u098X7GcGjm0lj3kcnx5tMEoNLumzKQen6pvAN tFkU5IbOqAyGXTMTAcAHnkCa87i0iv+foCklUhvOsZmZTuGBuZwyeIsxJf6ijF1t cFzJjQ== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f279ckywg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Jun 2026 02:08:25 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-845e3ede1f9so833159b3a.0 for ; Sun, 28 Jun 2026 19:08:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782698904; x=1783303704; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tQPFfKAfuAvHuuAQ/jaQ27ZsG9qI5Y1lwfUzTW083pY=; b=DXcl8dLMR0vVyNfdE71uEFlTp9ToeXl70M3GbRG3OFK/ihS/FZLyWqXvh61yNDk5me CG/3XgW5HjdwB98PtngGp99HWOlPXDr/bPSc/wKwJJxMQosQlbw5d5jFc9jl0jZlvUOC qxKpwlrSPQ449e0PY/eQCWcbrSSv+3JMWuMaiaRT0yfhSr7OMedhZ1Zbb11ivGgDGw0D 5r99pZR+WjuodrKnbnjR4uOIPCrN8pMkVgWjO/TER6hYhftWvrX5TMUaBiuaXe8cvX5E BLxXnHWkwyLTn2WOOFiw9v0KiS8MNeWo54B/yyfx0RVWmhHj3+nu0n5er1J7ad+31U1v AwKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782698904; x=1783303704; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tQPFfKAfuAvHuuAQ/jaQ27ZsG9qI5Y1lwfUzTW083pY=; b=c4wAQTmfvPZoEMhw3bDo8In2TR1I5tr2oJWsWJJgl4wpXOLrp3a7VRWge3S/DDFajj TZuruNNQqeYAjFzgBenzw/rQxJOHJxZOxENo/EjSK46JaWf0PJRlr5xCzLriekDTjuPV juFB00dBipAD9gJdXyLw4VDFsezFNS7/R7NrOLxqyJQAirUOQjGU6OIR3uo+IMrIYobu f9RncsAuxC++Zo5dKkY7Xrg5QIMhlBvhmYbozezzOhuTo5iaKWHw3oFT2+U5yULluNtq XMnFKuIN8K3UypQbNgx5Rp1w8vZUrWGQI6TBPf3aK9K5OtScRaqdTfAGEChELl9exXOQ KnkA== X-Forwarded-Encrypted: i=1; AHgh+RogWfTbzvYpNybL23oQbNPLe5F+9Ow6t1lmAu1d6NOYhJ2SaLE7f3eCaLqZl6njAMv9hdgBVen5taOz3L4=@vger.kernel.org X-Gm-Message-State: AOJu0Yxemz6I4wOkky5jqOJt4SddjxrH78BpNe+VocAEFSj8ycnVHUGP 3w06ans3lh1kakvom2QXAaqfwbT6p/cPLXYYS8Y8nLs9eLhJvDdly3voBBrVcUqRMjGH5dAKPJo R1TIITPCHuuot+XxFtYHHj3FF3NcoTodUowbvC4mvxSi/tn8v2/c2K1T9HgEvFqkFA28= X-Gm-Gg: AfdE7cmYF0N/O3exLrnsRgkCSEnl1Tu3sG+KBGrK8uG0bGooqm+PfdPBXwtKbjxSqf0 snurDLi0ufP1JUx5CxhPDQ5uGLPYRi9Yi9LPQDUJEtWCJhpoo9HKC3jYhbqcKp37a42PcD8yCij AK/upKVpfwNrrXNZI4ZCCxZKYvhBDVi13LEZIusexJwjL6bKwQQTRQnELSx5f3HuyGiLJqovIG1 KQwAiTy85PInSgeIxQ1dRszCRJ95/OQSAHuUUKKyz9R5kn0C0LvYB6+uAL5nsX1EAZ1K1Mi9YTO QYjncAK1F0YhF6dWyA1JGgKGszm6MT0vigebi0RRuPhNN9GgIrIUv8IWaJ6hY+glGubp0keFT6E R8HufapZQoSIuEv9i0ciDDRT7k9yWXTibJIekHpNGmXetMELliJpr2xwmr2zyFo9RNacSLLJ3c3 4= X-Received: by 2002:a05:6a00:2986:b0:845:ccf1:49b6 with SMTP id d2e1a72fcca58-845ccf14c44mr8944867b3a.45.1782698904520; Sun, 28 Jun 2026 19:08:24 -0700 (PDT) X-Received: by 2002:a05:6a00:2986:b0:845:ccf1:49b6 with SMTP id d2e1a72fcca58-845ccf14c44mr8944844b3a.45.1782698904079; Sun, 28 Jun 2026 19:08:24 -0700 (PDT) Received: from [10.133.33.20] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-845a40ee417sm10426170b3a.40.2026.06.28.19.08.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Jun 2026 19:08:23 -0700 (PDT) Message-ID: <9432df20-08bf-4134-b4b9-e6b5d618af81@oss.qualcomm.com> Date: Mon, 29 Jun 2026 10:08:17 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: kaanapali: fix traceNoC probe issue To: Leo Yan , Suzuki K Poulose , Mike Leach , James Clark Cc: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang , Jingyi Wang , Abel Vesa , Yuanfang Zhang , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org References: <471d7a92-3629-4274-a303-8906d3626037@arm.com> <25d7d3a1-58e0-4f25-a73a-59a978130c47@oss.qualcomm.com> <20260624151610.GC575984@e132581.arm.com> <20260625085643.GD575984@e132581.arm.com> <065853f5-b11b-4316-814e-202f07acb6ea@oss.qualcomm.com> <20260626103015.GE575984@e132581.arm.com> <20260626154949.GA1812158@e132581.arm.com> Content-Language: en-US From: Jie Gan In-Reply-To: <20260626154949.GA1812158@e132581.arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=evzvCIpX c=1 sm=1 tr=0 ts=6a41d399 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=AzejHKQscgVUoiqplJQA:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI5MDAxNiBTYWx0ZWRfXxwWKblM+wMh4 eMEk4rRAvg0uCLuiwCyFYk/sJZX8Sql6lA51HVHLweawbbcfu8B/DD4HlDF8YYTHQ+LXaNsg32K 56NG7u0ZrB16MEUg5S+a9hts4LJTnY4= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI5MDAxNiBTYWx0ZWRfX/Gl5Tj09y8Sz Yh0bfcKCGuTZWYR07QfTCbSzNEDhXHm1ICCNppobYLLYufdSUdJcw9wZe9Gab+JS38fFqhgC/dd /7FDn7mskRirYKXbi40N8rdMfezJtiafuOg8TYpXudiyV1W2y6v4IJEoHt8NU0+ZWN4urAbPHFT VdwKTlb6G0gRVQSKhQF1dhROHnI9pMGvJjIDYerpBF58sxRrkiTNQDN2cmz1CZcg5ZGI8hOlwrc yWrWLwArg5CMThageplL+r58XPXPZ0POl9FoxpP17sCmaS7L9b01EALsKIZvnsHTuxLyy4Wbked XM3CMvLDjsuIvFxw2Ot8pZlEvK8gygUfCcPlFT0eyEbbYre2N/p47VIgWHD591+vTtDwpArHLRK QIBP0iOqpw/cQOHB5/zYQmsf+0LE3fhcObIrJUL1AaR7CII8aA9gmaOjejS5as+4nMaE+YLxgaR Wxsg4/o6aCC7kx8OAxg== X-Proofpoint-GUID: Hx0SZH9BiNSLLUgpglvYEfexlNfadth1 X-Proofpoint-ORIG-GUID: Hx0SZH9BiNSLLUgpglvYEfexlNfadth1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-28_06,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 priorityscore=1501 spamscore=0 adultscore=0 malwarescore=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606290016 Hi Leo/Suzuki, On 6/26/2026 11:49 PM, Leo Yan wrote: > On Fri, Jun 26, 2026 at 08:09:58PM +0800, Jie Gan wrote: > > [...] > >> I have another proposal: what if we allocate the ATID in trace_noc_id() when >> the device does not already have a valid ATID? >> >> Possible scenarios: >> >> If the itnoc device is connected to a TPDM device (which has no ATID), >> trace_noc_id() will be invoked via coresight_path_assign_trace_id(), and a >> valid ATID can be allocated for the path. >> >> If the itnoc device is connected to sources other than TPDM, trace_noc_id() >> will never be invoked, and therefore no ATID will be allocated for the >> device, saving resources. > > TBH, I'm not sure I can make a judgement here, as I don't have enough > knowledge of the topology. And I'm not sure whether the listed > connections cover all possible cases. > > I also found commit 5799dee92dc2: > > | This patch adds platform driver support for the CoreSight Interconnect > | TNOC, Interconnect TNOC is a CoreSight link that forwards trace data > | from a subsystem to the Aggregator TNOC. Compared to Aggregator TNOC, > | it does not have aggregation and ATID functionality. > > With your proposal, wouldn't ATID be allocated for the interconnect > TNOC while being skipped for the Aggregator TNOC? That seems to > contradict the commit log. The ATID is allocated to the Aggregator TNOC during probe. The "WA" in driver definitely break the original design. Can I fix the issue by adding "arm,primecell-periphid" property. That's would be the best temp solution as it avoids breaking the original design of both the TraceNoC AMBA driver and interconnect TraceNoC platform driver. The TraceNoC device here must be treated as an AMBA device and I am continuing to investigate the issue with our hardware team. We aim to fix it from hardware perspetive for existing platforms if possible and ensure it is fixed in future platforms. Thanks, Jie > > Thanks, > Leo