mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Zhaoyang Huang <zhaoyang.huang@linaro.org>
Cc: zhaoyang.huang@spreadtrum.com, pavel@ucw.cz,
	linux-kernel@vger.kernel.org, len.brown@intel.com,
	gregkh@linuxfoundation.org, linux-pm@vger.kernel.org
Subject: Re: [RFC PATCH v1] refining the rpm_suspend function
Date: Tue, 19 Jan 2016 14:49:15 +0100	[thread overview]
Message-ID: <9438969.iYZ3h3fHzb@vostro.rjw.lan> (raw)
In-Reply-To: <1453194858-17416-1-git-send-email-zhaoyang.huang@spreadtrum.com>

On Tuesday, January 19, 2016 05:14:18 PM Zhaoyang Huang wrote:
> There are too many branch path within he original rpm_suspend funciton,which make
> the code a little bit hard for understanding and debugging.Just try to split the
> function into some small one to eliminate the goto and make one optimization for
> avoiding transfering from wait to auto when irq_safe flag set
> 
> Signed-off-by: Zhaoyang Huang <zhaoyang.huang@spreadtrum.com>

First off, please don't mix cleanups with optimizations.

Second, I don't really think that the changes you're making improve things
from the readability/debugging viewpoint.

Thanks,
Rafael

  reply	other threads:[~2016-01-19 13:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-19  9:14 Zhaoyang Huang
2016-01-19 13:49 ` Rafael J. Wysocki [this message]
2016-01-19 19:54 ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9438969.iYZ3h3fHzb@vostro.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=zhaoyang.huang@linaro.org \
    --cc=zhaoyang.huang@spreadtrum.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®