From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 944473A6B81 for ; Mon, 8 Jun 2026 08:16:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780906609; cv=none; b=EoDE8i0dhZrq7oZXYejhSSoCFX9jGF/+6d+cg3wMvrlUtDF6NtZ2y6m5Dnpi4aoPOTvLWFTgciknVO0Jp9KIIfXVDX8R0j2uGjYU4Gnu0HIXK5EBk90exAnyV4Rw1PYb/UTkKTiI9OTHci/AIfcBSmpGrGqcPKkM+alAuKIm9V8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780906609; c=relaxed/simple; bh=gJRYBEgOaGl2BIeH92hj9K0rA24WAa9AgrXCfWfGeeg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=W+N0ryUHOTa9PS3FpiGOjwuYroRl3CWTzmVq7137xzXnq3BK+hAU55Md/wCaU3Fsc0aUl9/jltkUkGeFhEtCbOtDckqPpF7j1GR3Jv8pw7oYZmDxXvUgi+4kRdWHi6AmR7U3E8fxFMvQH9eQ3AQCJubY/M0CFO4iTcSuAARsdOk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YbgAiNTD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DRNRBPQg; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YbgAiNTD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DRNRBPQg" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6586OkLI2347148 for ; Mon, 8 Jun 2026 08:16:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 8AMCbCTPRI9tqD3oyXlXIADZYYKHqYbtOIHsuIoklMc=; b=YbgAiNTDvhc9jdct PmanbLRJZ4shvZoofRsmmTqcuOlAtVfcDOdfRraSIB/eSu29Nul8Yuen06VR9WfN g/lE53tyIh8YGafG/lNHRshpVZBAf50+u+85sx5dLt8PNhuvRaybkMfdCw5V7781 fnTLX5GXRJ7w2iEYpzdlqeVXGz3ZmPruURBHW3bo6rmfiVP05drjCDsRgO14nwNI NLPUZlGly3p+tAwQZ7PLzaC1EIWDaf1MI+y8/aadgc0f3piAl2iDWIA6fqWOMp/r +oFHFwfxBd0IDd0dZZkca3mrz09QxuYssSdY2tnpCtRqfagJvEj3e4QVSVpveiv3 /bPdjA== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4emagrf0y1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 08 Jun 2026 08:16:46 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-9156dc90fdaso117234585a.0 for ; Mon, 08 Jun 2026 01:16:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780906606; x=1781511406; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8AMCbCTPRI9tqD3oyXlXIADZYYKHqYbtOIHsuIoklMc=; b=DRNRBPQgHkahnklLtc6a/MP3lqZkeIqv4woIsusf38r0aQEIALnfrSPFNXs/tHpBj4 jWc/EgqJuv0HX6dWheu6WrmAmlUY9WCndmPtEvdQ21RKYDkKZrw+TQhqElpbc2JhQdNZ fgO0yIbVlv5RpmKUHByK6smFoDITY9kNmys5L0yUP1dpqcmzm9jX6hl4P+kHWzQgzplJ 8OxcCdawFV2rwIyojMYHR9/pxL0C55Ay3jTKTJR/zgDr8VkMt6z3ID5H/i/x9/5XC6cO ke6HfR01fXBMrucum8RZtSjeijJPLIWNNEMJtc2hUHnquY7uyKcGZd52LnXh1wBMiR/y GhJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780906606; x=1781511406; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8AMCbCTPRI9tqD3oyXlXIADZYYKHqYbtOIHsuIoklMc=; b=pAQG0cImAvtX+bKkJ/DAo5Shj0ufaOLhZdUmJhhk6itrIniVSsyRNlbpIuCkW/lU1G eqcxLswnnNN+HSHMHzCqM9I7bP+7/t6War5JK1ZPQa5oaaeOBP5Tog2X5V2HNhUiFnLY Z1uLVwELdLqRSKLhA3tEZ7AD/yxgnTr7VSplh4KIcPjrowxq2BN2VrQCvoW81NjmzXQ5 1CfKxoKS0zrxnimXNgP7FtedDIC4grbOXR+4i8cD7E0wkVRTeMSgn0BhsAo823DFbIpa agsXJgEX4wZn+Bj5zeu80PXcyi8EJQkaMWh2IItFTUkrAjNQcXNpWKblvgzsYFjbMuRN TBNQ== X-Forwarded-Encrypted: i=1; AFNElJ/Dc1T3aZUotTXLTtceoeuf0jY7cx4bNy600BWIYARVs9znu1tfqiFmZUrXFiXRDc4jK2kkc0DguPNJHes=@vger.kernel.org X-Gm-Message-State: AOJu0YyrNOo8tSpNHausrLYdahimdaIrcGiuaKWJjMT0x36dGB0aBxjF UpX/6VIA/hCP6P7YOxjh9hsY7+nywqSwGsdQ4qSYwT7favTnzuAW6KaSk097i7WqPBoNyqew5T3 29Yh3XseTyPKh5t21qdDZQT6EtwtLGUip6YCTpMdPJbrDqvI3Y7Na+29n7HVPvljYfII= X-Gm-Gg: Acq92OEGWHTjyR5sIUsO5y9gduMYRYgEkg9rNfMlVJkcUpFb9HUyw6J3M+8JLXsUpp8 I9+jf3Sf6rBroaAwR8h+ta599TzCdCHYf6XolRX5fpUw/+Nf8EhKySKlyxR9pIyyXHCogbosGI7 PJeay/WaLaP8CM6SYs4pctT2wSJ5N5FF3Cm+tjySNavPz395XFR6nZSX4z2n+jV+1zvBKqm1GgM H+KiNn+58sPa2og1GuOn32UjHQ3eCVMcDMCYijLzy2QUGL/n5o8hfed620NIf6SlCkX8V4N516Q LotkorygZEn502SXJT0xmDlUgx6nmn3xrqgi0W5a7+Q3RPSxUmzCBe2DJGcWZj6PtB30APIMW5+ zKfXi+4wnZKI621f7Eof2PtsXT3WBI0DJdHaSnIeUeREc61kJDpq3kQvu X-Received: by 2002:a05:620a:178f:b0:8d7:ed38:8189 with SMTP id af79cd13be357-915a9a36533mr1322505485a.0.1780906605648; Mon, 08 Jun 2026 01:16:45 -0700 (PDT) X-Received: by 2002:a05:620a:178f:b0:8d7:ed38:8189 with SMTP id af79cd13be357-915a9a36533mr1322504485a.0.1780906605125; Mon, 08 Jun 2026 01:16:45 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bf05208e897sm817822766b.25.2026.06.08.01.16.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jun 2026 01:16:44 -0700 (PDT) Message-ID: <943d792a-6980-4883-9644-904c6b4832d6@oss.qualcomm.com> Date: Mon, 8 Jun 2026 10:16:41 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/6] drm/msm: Fix task_struct reference leak in recover_worker To: Akhil P Oommen , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Puranam V G Tejaswi , Jie Zhang , =?UTF-8?Q?Ma=C3=ADra_Canal?= Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jie Zhang References: <20260605-assorted-fixes-june-v1-0-2caa04f7287c@oss.qualcomm.com> <20260605-assorted-fixes-june-v1-6-2caa04f7287c@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260605-assorted-fixes-june-v1-6-2caa04f7287c@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA4MDA3NCBTYWx0ZWRfX3f+Ql33ijmUA 4xmmMbl4CA1FVnmIgi4Jh1wbB2YDarz6/QLhmYwHg5cc0uK3W1ckJbE8XaxhxJ3mUl9g9fN+tn7 goHOVCxqO9ieOsVD9J9HH4k8Yzo/ag3T1UV9hYM3KD2nO5oLsDA1oLBoJmBjNBY4cET0D8x+WJm oim3WYkA4UYtpEZimOjYi6IcwAYvZQdJEVtCpi+KnrTSvMI+CkI82m9wUDa8gG3IiGqCOVQpULZ IUK3n3HzJZC9Ccbe2CSHTXKmOha30as1XgYVgCl7SYisxZUvNcjlZHf5nDmlAHcSKwELCHL3sRs yCQcxcJD61ZVVPBEFElt2DFQsmXDpYLWY75UUnGYWabSbiSta6SiPm6aHv2/x0IzrRbWekee/Zc XR4SZcxvPuS7Myu6gDu/5GnbBZc+BYw6l76peXyUbs0Pybn0Gh4+zoqz9Zs4DUAzwYEj3BKr+4t RI0L5hHZeVhX066Sx0g== X-Authority-Analysis: v=2.4 cv=G/4s1dk5 c=1 sm=1 tr=0 ts=6a267a6e cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=iwmd1eEXldmoXfJYBtMA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: g0dtxV7KwBVRFMe45QdKpUWz9G87lVkj X-Proofpoint-GUID: g0dtxV7KwBVRFMe45QdKpUWz9G87lVkj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-08_02,2026-06-05_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 malwarescore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 impostorscore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606080074 On 6/4/26 10:08 PM, Akhil P Oommen wrote: > From: Jie Zhang > > get_pid_task() increments the task reference count, but the > corresponding put_task_struct() was missing in the else branch, > leaking a reference on every GPU hang recovery. > > Fixes: 25654a1756a4 ("drm/msm: Update global fault counter when faulty process has already ended") > Signed-off-by: Jie Zhang > Signed-off-by: Akhil P Oommen > --- Reviewed-by: Konrad Dybcio Konrad