From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751768AbeAARTB (ORCPT + 1 other); Mon, 1 Jan 2018 12:19:01 -0500 Received: from mout.web.de ([212.227.15.3]:55130 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751336AbeAARS7 (ORCPT ); Mon, 1 Jan 2018 12:18:59 -0500 To: netdev@vger.kernel.org, Derek Chickles , Felix Manlunas , Raghu Vatsavayi , Satanand Burla Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] LiquidIO: Delete two error messages for a failed memory allocation in octeon_setup_interrupt() Message-ID: <94411e3f-3709-3b76-537d-d189cf14cdb4@users.sourceforge.net> Date: Mon, 1 Jan 2018 18:18:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:pFSAStiL6KPADNu+0qT0lEmDjavS9chp+clWSi99xRfvfzU92Pr cXXG3LZBhhvRXe3HONbcFSHE+vZgcVntqlnYOTUkRj6f9kWY5PUTpIBMm7/GcK2hJ6/rgFx S0W8f2X4vRYe4AFHgcf/XZJLe3hdQemP/DXbSi7AGDYeqJLsyXPSg8qgeP7cTTK2WiQ9Lze dSM4B+DDjGs2oOikW4AlQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:wX4tJy/0OOs=:cVqAuzFSB5ktYkla4hvrA8 g/bdo/OcY+AzNaTkTtL7dKDGN1hZUQgip5bop/NlkDgwBjevRClXHDbBBOX4WJzAaPdXAKs9T rOzksQNLtgRa0FB5o8Duxc1y4X48WgoRqTpS8TQKqg/o4AdfUBkJG2Q2z9d8JM8qFBvvu1XDz mf2QZ9MJC/bae9Nw0lWlF9hDUmKL+TIXk3P93Ta+JkT0fzVU1dYQ2y52lhFhksf2r/RJVPvzT evSlvS5hxxg7Of6enff72DOUUsROdSwYJT1lxlEVP8z1fdzzjDhn+2+jbqf2bgGeGAwgBjz5R 5n/QDenfP0yWm3bdEBsGUiO19hsx1NgboFQLueYw0wHtPH14oN5hY6ylh0tefPbzJxNdMGfUV XgVTiVOYlWliKNSaGo2beHJQVTQatczovj11ihQKeDPldtV4nqSyTyTl3dbMSFkOKM9PnMHni UlGxf5VK1KZ3yFucjOcmNdRXlJV5iaFhiBmSAnFph9s04BleXlkux7VLdU05SfogwQFUtmXHD 60bCvR+r0PziIyNuwEUr33mwswBziexdwz7BbjlXaknyBuhoJy4Tdn+SL13iH4oI0+scDvjba AhsLpdfQ96+/29SdCrpTK7Tq3OHws69/ZG1XhVGl1OzflkBJ5ZAAhsgrQr+b47UTuBpG1P7Vp O7L4TndzNa3OHlCgtZXS7/A/gZmIifdh7kREJ8gg209lPQQQjHED1k3qhvQazMpMJo0n8oDgz QiOiu5snmC/rIBRxWW6HnkE9KdpnzuCrwpJcltJUb+RvhAeinG3F7djmROwXSAy19QNAJ+/fQ dNdT8FgX3u0odoJs1BI01KP0qUaVb862dsALhn9lugPErYs7jY= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: From: Markus Elfring Date: Mon, 1 Jan 2018 18:14:49 +0100 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/ethernet/cavium/liquidio/lio_core.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/cavium/liquidio/lio_core.c b/drivers/net/ethernet/cavium/liquidio/lio_core.c index 32ae63b6f20e..012829de76b7 100644 --- a/drivers/net/ethernet/cavium/liquidio/lio_core.c +++ b/drivers/net/ethernet/cavium/liquidio/lio_core.c @@ -915,10 +915,8 @@ int octeon_setup_interrupt(struct octeon_device *oct, u32 num_ioqs) /* allocate storage for the names assigned to each irq */ oct->irq_name_storage = kcalloc(num_interrupts, INTRNAMSIZ, GFP_KERNEL); - if (!oct->irq_name_storage) { - dev_err(&oct->pci_dev->dev, "Irq name storage alloc failed...\n"); + if (!oct->irq_name_storage) return -ENOMEM; - } queue_irq_names = oct->irq_name_storage; @@ -930,7 +928,6 @@ int octeon_setup_interrupt(struct octeon_device *oct, u32 num_ioqs) sizeof(struct msix_entry), GFP_KERNEL); if (!oct->msix_entries) { - dev_err(&oct->pci_dev->dev, "Memory Alloc failed...\n"); kfree(oct->irq_name_storage); oct->irq_name_storage = NULL; return -ENOMEM; -- 2.15.1