From: David Ahern <dsahern@kernel.org>
To: menglong8.dong@gmail.com, kuba@kernel.org, pabeni@redhat.com
Cc: rostedt@goodmis.org, mingo@redhat.com, xeb@mail.ru,
davem@davemloft.net, yoshfuji@linux-ipv6.org,
imagedong@tencent.com, edumazet@google.com, kafai@fb.com,
talalahmad@google.com, keescook@chromium.org, alobakin@pm.me,
flyingpeng@tencent.com, mengensun@tencent.com,
dongli.zhang@oracle.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, benbjiang@tencent.com
Subject: Re: [PATCH RESEND net-next v5 1/4] net: sock: introduce sock_queue_rcv_skb_reason()
Date: Fri, 8 Apr 2022 21:49:54 -0600 [thread overview]
Message-ID: <94414a48-f8d3-aa20-0d82-930043a3d4cd@kernel.org> (raw)
In-Reply-To: <20220407062052.15907-2-imagedong@tencent.com>
On 4/7/22 12:20 AM, menglong8.dong@gmail.com wrote:
> From: Menglong Dong <imagedong@tencent.com>
>
> In order to report the reasons of skb drops in 'sock_queue_rcv_skb()',
> introduce the function 'sock_queue_rcv_skb_reason()'.
>
> As the return value of 'sock_queue_rcv_skb()' is used as the error code,
> we can't make it as drop reason and have to pass extra output argument.
> 'sock_queue_rcv_skb()' is used in many places, so we can't change it
> directly.
>
> Introduce the new function 'sock_queue_rcv_skb_reason()' and make
> 'sock_queue_rcv_skb()' an inline call to it.
>
> Reviewed-by: Hao Peng <flyingpeng@tencent.com>
> Reviewed-by: Jiang Biao <benbjiang@tencent.com>
> Signed-off-by: Menglong Dong <imagedong@tencent.com>
> ---
> include/net/sock.h | 9 ++++++++-
> net/core/sock.c | 30 ++++++++++++++++++++++++------
> 2 files changed, 32 insertions(+), 7 deletions(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2022-04-09 3:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 6:20 [PATCH RESEND net-next v5 0/4] net: icmp: add skb drop reasons to icmp menglong8.dong
2022-04-07 6:20 ` [PATCH RESEND net-next v5 1/4] net: sock: introduce sock_queue_rcv_skb_reason() menglong8.dong
2022-04-09 3:49 ` David Ahern [this message]
2022-04-07 6:20 ` [PATCH RESEND net-next v5 2/4] net: skb: rename SKB_DROP_REASON_PTYPE_ABSENT menglong8.dong
2022-04-09 3:50 ` David Ahern
2022-04-07 6:20 ` [PATCH RESEND net-next v5 3/4] net: icmp: introduce __ping_queue_rcv_skb() to report drop reasons menglong8.dong
2022-04-09 4:05 ` David Ahern
2022-04-07 6:20 ` [PATCH RESEND net-next v5 4/4] net: icmp: add skb drop reasons to icmp protocol menglong8.dong
2022-04-09 4:17 ` David Ahern
2022-04-11 9:50 ` [PATCH RESEND net-next v5 0/4] net: icmp: add skb drop reasons to icmp patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94414a48-f8d3-aa20-0d82-930043a3d4cd@kernel.org \
--to=dsahern@kernel.org \
--cc=alobakin@pm.me \
--cc=benbjiang@tencent.com \
--cc=davem@davemloft.net \
--cc=dongli.zhang@oracle.com \
--cc=edumazet@google.com \
--cc=flyingpeng@tencent.com \
--cc=imagedong@tencent.com \
--cc=kafai@fb.com \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mengensun@tencent.com \
--cc=menglong8.dong@gmail.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rostedt@goodmis.org \
--cc=talalahmad@google.com \
--cc=xeb@mail.ru \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®