From: Joe Perches <joe@perches.com>
To: Nick Desaulniers <ndesaulniers@google.com>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna.schumaker@netapp.com>
Cc: "Gustavo A . R . Silva" <gustavo@embeddedor.com>,
Nathan Chancellor <natechancellor@gmail.com>,
Miaohe Lin <linmiaohe@huawei.com>,
Hongxiang Lou <louhongxiang@huawei.com>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com
Subject: Re: [PATCH] nfs: remove incorrect fallthrough label
Date: Tue, 15 Sep 2020 16:29:41 -0700 [thread overview]
Message-ID: <9441ed0f247d0cac6e85f3847e1b4c32a199dd8f.camel@perches.com> (raw)
In-Reply-To: <20200915225751.274531-1-ndesaulniers@google.com>
On Tue, 2020-09-15 at 15:57 -0700, Nick Desaulniers wrote:
> There is no case after the default from which to fallthrough to. Clang
> will error in this case (unhelpfully without context, see link below)
> and GCC will with -Wswitch-unreachable.
>
> The previous commit should have just removed the comment.
[]
> diff --git a/fs/nfs/super.c b/fs/nfs/super.c
[]
> @@ -889,7 +889,6 @@ static struct nfs_server *nfs_try_mount_request(struct fs_context *fc)
> default:
> if (rpcauth_get_gssinfo(flavor, &info) != 0)
> continue;
> - fallthrough;
My preference would be to convert the fallthrough
to a break here so if someone ever adds another
label after default: for any reason, the code would
still work as expected.
> }
>
next prev parent reply other threads:[~2020-09-15 23:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 22:57 Nick Desaulniers
2020-09-15 23:29 ` Joe Perches [this message]
2020-09-15 23:51 ` Gustavo A. R. Silva
2020-09-16 0:01 ` Gustavo A. R. Silva
2020-09-16 0:33 ` Joe Perches
2020-09-16 20:02 ` [PATCH v2] " Nick Desaulniers
2020-09-16 20:18 ` Gustavo A. R. Silva
2020-09-16 20:19 ` Joe Perches
2020-09-17 21:41 ` Nick Desaulniers
2020-09-18 1:36 ` Joe Perches
2020-09-17 21:45 ` [PATCH v3] " Nick Desaulniers
2020-09-24 17:19 ` Nick Desaulniers
2020-09-24 17:40 ` Joe Perches
2020-09-24 18:07 ` Joe Perches
2020-09-24 18:11 ` Anna Schumaker
2020-09-25 11:27 ` Mark Brown
2020-09-24 18:08 ` Gustavo A. R. Silva
2020-09-17 4:35 ` [PATCH v2] " Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9441ed0f247d0cac6e85f3847e1b4c32a199dd8f.camel@perches.com \
--to=joe@perches.com \
--cc=anna.schumaker@netapp.com \
--cc=clang-built-linux@googlegroups.com \
--cc=gustavo@embeddedor.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=louhongxiang@huawei.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®