From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7297EC433EF for ; Tue, 25 Jan 2022 10:49:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356435AbiAYKtY (ORCPT ); Tue, 25 Jan 2022 05:49:24 -0500 Received: from foss.arm.com ([217.140.110.172]:34182 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355798AbiAYKqE (ORCPT ); Tue, 25 Jan 2022 05:46:04 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 506C5101E; Tue, 25 Jan 2022 02:46:00 -0800 (PST) Received: from [10.163.43.67] (unknown [10.163.43.67]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 40CFD3F7D8; Tue, 25 Jan 2022 02:45:56 -0800 (PST) Subject: Re: [PATCH V3 0/7] coresight: trbe: Workaround Cortex-A510 erratas To: Suzuki K Poulose , linux-arm-kernel@lists.infradead.org Cc: Catalin Marinas , Will Deacon , Mathieu Poirier , coresight@lists.linaro.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org References: <1641872346-3270-1-git-send-email-anshuman.khandual@arm.com> <8a348786-d028-a991-178f-60b17d3d6554@arm.com> From: Anshuman Khandual Message-ID: <94430fa0-0cac-79f4-f167-1ac77077ad23@arm.com> Date: Tue, 25 Jan 2022 16:16:03 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <8a348786-d028-a991-178f-60b17d3d6554@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/25/22 3:32 PM, Suzuki K Poulose wrote: > On 25/01/2022 03:21, Anshuman Khandual wrote: >> >> >> On 1/11/22 9:08 AM, Anshuman Khandual wrote: >>>     This series adds three different workarounds in the TRBE driver for >>> Cortex-A510 specific erratas. But first, this adds Cortex-A510 specific cpu >>> part number definition in the platform. This series applies on 5.16. >>> >>> Relevant errata documents can be found here. >>> >>> https://developer.arm.com/documentation/SDEN2397239/900 >>> https://developer.arm.com/documentation/SDEN2397589/900 >>> >>> Changes in V3: >>> >>> - Moved the comment inside trbe_needs_drain_after_disable() >>> - Moved the comment inside trbe_needs_ctxt_sync_after_enable() >>> >>> Changes in V2: >>> >>> https://lore.kernel.org/all/1641517808-5735-1-git-send-email-anshuman.khandual@arm.com/ >>> >>> Accommodated most review comments from the previous version. >>> >>> - Split all patches into CPU errata definition, detection and TRBE workarounds >>> - s/TRBE_WORKAROUND_SYSREG_WRITE_FAILURE/TRBE_NEEDS_DRAIN_AFTER_DISABLE >>> - s/TRBE_WORKAROUND_CORRUPTION_WITH_ENABLE/TRBE_NEEDS_CTXT_SYNC_AFTER_ENABLE >>> - s/trbe_may_fail_sysreg_write()/trbe_needs_drain_after_disable() >>> - s/trbe_may_corrupt_with_enable()/trbe_needs_ctxt_sync_after_enable() >>> - Updated Kconfig help message for config ARM64_ERRATUM_1902691 >>> - Updated error message for trbe_is_broken() detection >>> - Added new trblimitr parameter to set_trbe_enabled(), improving performance >>> - Added COMPILE_TEST dependency in the errata, until TRBE part is available >>> >>> Changes in V1: >>> >>> https://lore.kernel.org/lkml/1641359159-22726-1-git-send-email-anshuman.khandual@arm.com/ >>> >>> Cc: Catalin Marinas >>> Cc: Will Deacon >>> Cc: Mathieu Poirier >>> Cc: Suzuki Poulose >>> Cc: coresight@lists.linaro.org >>> Cc: linux-doc@vger.kernel.org >>> Cc: linux-arm-kernel@lists.infradead.org >>> Cc: linux-kernel@vger.kernel.org >>> >>> Anshuman Khandual (7): >>>    arm64: Add Cortex-A510 CPU part definition >>>    arm64: errata: Add detection for TRBE ignored system register writes >>>    arm64: errata: Add detection for TRBE invalid prohibited states >>>    arm64: errata: Add detection for TRBE trace data corruption >>>    coresight: trbe: Work around the ignored system register writes >>>    coresight: trbe: Work around the invalid prohibited states >>>    coresight: trbe: Work around the trace data corruption >> >> Hello Catalin/Mathieu, >> >> I am wondering how this series is going to be merged i.e via arm64 or coresight >> tree ? Also will this require rebasing (and resend) against v5.17-rc1 release. >> Please do suggest. Thank you. > > I would recommend rebasing on rc1. Sure, will do.