From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751625AbeFBOdF (ORCPT ); Sat, 2 Jun 2018 10:33:05 -0400 Received: from vern.gendns.com ([206.190.152.46]:58648 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750827AbeFBOdD (ORCPT ); Sat, 2 Jun 2018 10:33:03 -0400 Subject: Re: [PATCH] clk: davinci: cfgchip: testing the wrong variable To: Dan Carpenter Cc: Sekhar Nori , Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20180602075256.hrvidsfsmr33mv2f@kili.mountain> From: David Lechner Message-ID: <9444dee2-db66-77ab-06bb-81df888f6287@lechnology.com> Date: Sat, 2 Jun 2018 09:33:00 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180602075256.hrvidsfsmr33mv2f@kili.mountain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/02/2018 02:52 AM, Dan Carpenter wrote: > There is a copy and paste bug here. We should be testing "usb1" instead > of "usb0". > > Fixes: 58e1e2d2cd89 ("clk: davinci: cfgchip: Add TI DA8XX USB PHY clocks") > Signed-off-by: Dan Carpenter > > diff --git a/drivers/clk/davinci/da8xx-cfgchip.c b/drivers/clk/davinci/da8xx-cfgchip.c > index c971111d2601..20a120aa147e 100644 > --- a/drivers/clk/davinci/da8xx-cfgchip.c > +++ b/drivers/clk/davinci/da8xx-cfgchip.c > @@ -672,7 +672,7 @@ static int of_da8xx_usb_phy_clk_init(struct device *dev, struct regmap *regmap) > > usb1 = da8xx_cfgchip_register_usb1_clk48(dev, regmap); > if (IS_ERR(usb1)) { > - if (PTR_ERR(usb0) == -EPROBE_DEFER) > + if (PTR_ERR(usb1) == -EPROBE_DEFER) > return -EPROBE_DEFER; > > dev_warn(dev, "Failed to register usb1_clk48 (%ld)\n", > Reviewed-by: David Lechner