From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
rfoss@kernel.org, todor.too@gmail.com, agross@kernel.org,
andersson@kernel.org, konrad.dybcio@linaro.org,
mchehab@kernel.org, sakari.ailus@linux.intel.com,
andrey.konovalov@linaro.org
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v0 8/9] media: qcom: camss: Fix set CSI2_RX_CFG1_VC_MODE when VC is greater than 3
Date: Mon, 21 Aug 2023 20:21:41 +0100 [thread overview]
Message-ID: <9447f63a-50a2-d699-606b-b32d16aaa56a@linaro.org> (raw)
In-Reply-To: <62859b0e-cfee-f094-2ae9-bf0e243e2929@linaro.org>
On 21/08/2023 19:51, Bryan O'Donoghue wrote:
> On 21/08/2023 10:53, Hans Verkuil wrote:
>> + u8 dt_id = vc * 4;
>
> You're right.
>
> dt_id = vc is wrong but so is dt_id = vc * 4.
>
> I'll post a fix for the dt_id as a separate patch.
>
> ---
> bod
No wait.. dt_id = vc is _fine_
I'll add a patch to document what this does since the provenance of the
changes for this value are undocumented and confusing even to me, with
access to the documentation for it.
---
bod
next prev parent reply other threads:[~2023-08-21 19:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 14:09 [PATCH v0 0/9] media: qcom: camss: Bugfix series Bryan O'Donoghue
2023-08-14 14:09 ` [PATCH v0 1/9] media: qcom: camss: Fix pm_domain_on sequence in probe Bryan O'Donoghue
2023-08-14 14:10 ` [PATCH v0 2/9] media: qcom: camss: Fix V4L2 async notifier error path Bryan O'Donoghue
2023-08-14 14:10 ` [PATCH v0 3/9] media: qcom: camss: Fix vfe_get() error jump Bryan O'Donoghue
2023-08-14 14:10 ` [PATCH v0 4/9] media: qcom: camss: Fix VFE-17x vfe_disable_output() Bryan O'Donoghue
2023-08-14 14:10 ` [PATCH v0 5/9] media: qcom: camss: Fix VFE-480 vfe_disable_output() Bryan O'Donoghue
2023-08-14 14:10 ` [PATCH v0 6/9] media: qcom: camss: Fix missing vfe_lite clocks check Bryan O'Donoghue
2023-08-14 14:10 ` [PATCH v0 7/9] media: qcom: camss: Fix invalid clock enable bit disjunction Bryan O'Donoghue
2023-08-21 11:56 ` Konrad Dybcio
2023-08-14 14:10 ` [PATCH v0 8/9] media: qcom: camss: Fix set CSI2_RX_CFG1_VC_MODE when VC is greater than 3 Bryan O'Donoghue
2023-08-21 9:53 ` Hans Verkuil
2023-08-21 10:13 ` Bryan O'Donoghue
2023-08-21 18:51 ` Bryan O'Donoghue
2023-08-21 19:21 ` Bryan O'Donoghue [this message]
2023-08-14 14:10 ` [PATCH v0 9/9] media: qcom: camss: Fix csid-gen2 for test pattern generator Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9447f63a-50a2-d699-606b-b32d16aaa56a@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=andrey.konovalov@linaro.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rfoss@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®