mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Ashish Kalra <ashish.kalra@amd.com>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	 Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	Denis Mukhin <dmukhin@ford.com>
Subject: Re: [PATCH v1 0/6] x86/boot: Enable earlyprintk on MMIO (8-bit)
Date: Mon, 05 May 2025 16:32:38 -0700	[thread overview]
Message-ID: <944ddefdc0ef3dc0f78c7957afa7f12e360a4392.camel@infradead.org> (raw)
In-Reply-To: <aBjSzIPaovOl03Eg@smile.fi.intel.com>

[-- Attachment #1: Type: text/plain, Size: 2547 bytes --]

On Mon, 2025-05-05 at 18:01 +0300, Andy Shevchenko wrote:
> On Mon, May 05, 2025 at 05:59:48PM +0300, Andy Shevchenko wrote:
> > On Mon, May 05, 2025 at 07:35:04AM -0700, David Woodhouse wrote:
> > > On Mon, 2025-05-05 at 17:05 +0300, Andy Shevchenko wrote:
> > > > On Fri, May 02, 2025 at 10:33:49AM -0700, David Woodhouse
> > > > wrote:
> > > > > On Fri, 2025-05-02 at 15:29 +0300, Andy Shevchenko wrote:
> > > > > > Some of the platforms may have no legacy COM ports and only
> > > > > > provide
> > > > > > an MMIO accessible UART. Add support for such to
> > > > > > earlyprintk for the
> > > > > > boot phase of the kernel.
> > > > > 
> > > > > Shiny. I had to hack QEMU's PCI serial port to do unnatural
> > > > > things, in
> > > > > order to test the mmio32 variant which was the only thing the
> > > > > earlyprintk code used to support. But I *did* so, and it
> > > > > works with the
> > > > > kexec debugging.
> > > > > 
> > > > > Can you add support for this mode to the kexec debugging too,
> > > > > please?
> > > > 
> > > > Do you mean to add MMIO 8-bit to kexec assembly code and other
> > > > parts like you
> > > > did in the below mentioned change?
> > > > 
> > > > I can try it at some point, but have no time right now for
> > > > this.
> > > > I would appreciate if you can give a try for this patch series
> > > > functionality to see if it helps for the initial messages (as
> > > > far as I understand you also want to have this in the second
> > > > kernel, right?).
> > > 
> > > I'll see if I can find the time to take a look. Got a branch I
> > > can pull
> > > your series from?
> > 
> > Yeo,
> > https://bitbucket.org/andy-shev/linux/commits/branch/topic%2Fx86%2Fboot-earlyprintk
> > .
> 
> But just FYI that with `b4` it's as easy to pull from the mailing
> list as from
> a branch:
> 
> 	b4 am
> 20250502123145.4066635-1-andriy.shevchenko@linux.intel.com
> 	git am -C1 -s ...


Thanks. Should I be expecting this to work...?

qemu-system-x86_64 -display none -vga none  -accel kvm,kernel-irqchip=split \
  -kernel arch/x86/boot/bzImage \
  -append "console=ttyS4 root=/dev/vda1 earlyprintk=pciserial" \
  -chardev stdio,mux=on,id=char0,signal=off -mon char0 -device pci-serial,chardev=char0


I get no early output (I think it's still using the mmio32 variant),
and I only see output from when the real driver takes over:

[    0.894054] printk: legacy console [ttyS4] enabled
[    0.895498] printk: legacy bootconsole [earlyser0] disabled
...



[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5069 bytes --]

  reply	other threads:[~2025-05-05 23:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-02 12:29 Andy Shevchenko
2025-05-02 12:29 ` [PATCH v1 1/6] x86/boot: Convert early_serial_base to unsigned long Andy Shevchenko
2025-05-02 12:29 ` [PATCH v1 2/6] x86/boot: Introduce helpers for serial I/O Andy Shevchenko
2025-05-02 12:29 ` [PATCH v1 3/6] x86/boot: Split out parse_serial_port() helper for earlyprintk Andy Shevchenko
2025-05-02 12:29 ` [PATCH v1 4/6] x86/boot: Allow longer parameter list " Andy Shevchenko
2025-05-02 12:29 ` [PATCH v1 5/6] x86/boot: Also share MMIO accessors Andy Shevchenko
2025-05-02 12:29 ` [PATCH v1 6/6] x86/boot: Introduce MMIO accessors and their support in earlyprintk Andy Shevchenko
2025-05-02 17:33 ` [PATCH v1 0/6] x86/boot: Enable earlyprintk on MMIO (8-bit) David Woodhouse
2025-05-05 14:05   ` Andy Shevchenko
2025-05-05 14:35     ` David Woodhouse
2025-05-05 14:59       ` Andy Shevchenko
2025-05-05 15:01         ` Andy Shevchenko
2025-05-05 23:32           ` David Woodhouse [this message]
2025-05-06  3:19             ` David Woodhouse
2025-05-06 19:38 ` David Woodhouse
2025-05-07 13:54   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=944ddefdc0ef3dc0f78c7957afa7f12e360a4392.camel@infradead.org \
    --to=dwmw2@infradead.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=ashish.kalra@amd.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=dmukhin@ford.com \
    --cc=hpa@zytor.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®