Re: [PATCH v2] mtd: spi-nor: hisi-sfc: Remove excessive clk_disable_unprepare()

[<Tudor.Ambarus@microchip.com>]

On 7/9/21 5:45 PM, Evgeny Novikov wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> hisi_spi_nor_probe() invokes clk_disable_unprepare() on all paths after
> successful call of clk_prepare_enable(). Besides, the clock is enabled by
> hispi_spi_nor_prep() and disabled by hispi_spi_nor_unprep(). So at remove
> time it is not possible to have the clock enabled. The patch removes
> excessive clk_disable_unprepare() from hisi_spi_nor_remove().
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Fixes: e523f11141bd ("mtd: spi-nor: add hisilicon spi-nor flash controller driver")
> Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
> Reviewed-by: Pratyush Yadav <p.yadav@ti.com>
> ---
> v2: Fix notes from Pratyush Yadav:
>     - Describe better why clock disabling is not necessary at remove time.
>     - Add tag Fixes.
> ---
>  drivers/mtd/spi-nor/controllers/hisi-sfc.c | 1 -
>  1 file changed, 1 deletion(-)
> 

Applied, thanks.