From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90CFA3F0A9F for ; Mon, 15 Jun 2026 12:39:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781527182; cv=none; b=gIjEE0j5g2H2SVvc/mjnJpwX4CXsTOa3zk23d3kIhZ9qdqB9nFAxZI7hPTNs7ct0J9Kdiy5q11Kf+Xdp0VwyY6ytHKkNfbQZnlNZMBtHUdfVU8EtMXrH5KGX7pbFIVOMMwI5K7qrvTde9ExqotzG17nbdwkoY2OxwLra+RV+Jek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781527182; c=relaxed/simple; bh=Y5prCy5+X71R7ukzr0TW8cLU1IZdPzDKmXZeqLxAJiQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BJgxb9M/ALInNH1uId/rQEgVrq0IDfNHZJW55/zh+Ug1itabjJzmevyB5qKNdm8tcNK+LGseBbpiLZ3woAsiQ+S1M+Tpy66T6FeKjkfAGjEhJlKv8Y84X4Wa1Cug6LAnwW+/ThVVig9z8jdHwMaGlMnL9dCdJuh3V26/p7ZSttM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=I15gNtEg; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZMArD7cc; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="I15gNtEg"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZMArD7cc" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65FCbmrb568216 for ; Mon, 15 Jun 2026 12:39:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MvAUEeqrTnOOtIH0IwXD0ePwoU1h7XJ2wsmVx9GGNbE=; b=I15gNtEgbJFa3B2j oF2UfjblXkO2+xaZprLAY3bykuh+O2oyNVvKV1GpUMmRtVtbnrce/zW/EcpVsnNb PO36+hgg7n4VQ7FH83Q9gZ4WU+xJr9dK750kVKL0RbDOpFuFzlOQLv6oEg2LDwoR V4fjnxOB2Wgwhe3gDVE9KDYMIElRUdimqWd80Dtx+iry1BhuDjMPxR1/KsAdMxeA nN/VkD0yd2NdxRzJX/tiszcOM8KqhkJJOCZUDkqS/t1ZwJkMY6y1L2EOOOrouEV2 5k7y3T5w50GTHHGbVU3VWctL21bxGTv+lrCm2DI20Blc5p2PJyeqJgV9yesLoXgP iQlbUA== Received: from mail-dl1-f69.google.com (mail-dl1-f69.google.com [74.125.82.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4etgvhg5w0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 15 Jun 2026 12:39:25 +0000 (GMT) Received: by mail-dl1-f69.google.com with SMTP id a92af1059eb24-1394c3ee7f2so6655331c88.1 for ; Mon, 15 Jun 2026 05:39:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781527165; x=1782131965; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MvAUEeqrTnOOtIH0IwXD0ePwoU1h7XJ2wsmVx9GGNbE=; b=ZMArD7cc+bViQJNq+abiNgFiBNPB1JZ2vsARTz4y5k2v29KblIOfg8y8FoLnz1oJv8 lBrwiI+UdmDlcVIqtH2JewyFxs3mUhIdDDOYLKN0JdLXlTI2zXYI77caqWHKBsBbCjvd YYDBpLvb73kYTeUR0xhk3QKnzMDM53iIE9pLCCMCKD55GhWf/cxB2jmiymt/Y7crs7PO YoCcC0ep+ptwZ0YQLuz6QZOSE6g3DEigWCfc73gykA2GqYVai3LWj5H4dYTl5WUVisiG MburxA8QNw3EApmVGgSDCxf3pwnCuhAbFsQefto658RNyiyc+cxFcEeCMQSI3JEOoKBr Xj+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781527165; x=1782131965; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MvAUEeqrTnOOtIH0IwXD0ePwoU1h7XJ2wsmVx9GGNbE=; b=JN5NexHJxMzZUdmAAaZW+rSpp1e6CCwqu5R1hDI7fWdMS7pt50gz9OMmT13BE2BX/L 6j9mShS6WqCA66K4olDzW07n/9CqpW8m0Fq1KSsSIzBfo9ukf/KbRVQCy+Dn3zMnYsPq mQrmS4t/9kwbVjV5qcslJtG8SWcWyJW58ZzYS4a05D+pVtMghnpxvBAiZ8ys0ZDYEfmn u1jqsEbkshr2SZxXxa+cnQt5ciYQc5Ufd7NN3CVkxVYq7wYmwFnBW4NV55TTaOCSAb+P d3fByz9M+tCmRLQ6z8ipI0l6lnXJRYKSOI1z7hqNBE6kLrrBst2Cs89NiJ40VbInLcc0 BBQQ== X-Forwarded-Encrypted: i=1; AFNElJ+gg7+P8d9Ki+ZfIO0NIZV8oV/cTS1oYHqqAqUxz+iFzxF9qSWwGoiDUecsx5PBwFuSF3C4LqH0kh5tJAY=@vger.kernel.org X-Gm-Message-State: AOJu0Yyssw+SNf7jp/Q+1SFYd1tMU1DUZwLyHrYIQ160xkydhDJEqaXZ y9NHZUcpt8R0Yue+mjBDGH3NAxvgeJJBTkB6cbvaU3zKsLBSsxLhR19WqZYyyqMFJWg1qM/n9R7 piDejZbSWZa2e4vhZ4D1Dn/ASVPuc67kj0XNxETwoSpf3z8MPM9HNDFXEn14UMLFr4C4= X-Gm-Gg: Acq92OG7MqRxx4Yvxl/diBRg2WC4PpCcoYZ2nBtaZMDwR14f1Q1qOcYiLd35qFn61tp XmDLlUzgA1D6CSTYX66Wuc/ed1i6ix9WoMLVYjny89/BZT0eKS6vXWLcNK87vyIlJiln2wh6RQn ImzJ8MM1WcRnQVNXC4rhnZMUNaWX+NJ3x7ktFsA9CzgKUIh0t63xrtDEJbUrLho1IJgSo29O54t k/rTDvDyKIWjTlDiECy6ulw5/Z3hkSOpAmDKLKYmGZOo9//m4BlrI/Er1ZP4aYLYraeCsu+vFBE C3kBJiodigxdX0gD0XsNYNQ9V8NFrJ1KUx0F8OxY7AuYhwVleFwnR6F91MUe4G4F+p9Vp8Bm97P zl2MvbUpYv3FR4wS0AKmPKFa4oqdgFpE+aghRn7k1AouVo7oksr3vkg== X-Received: by 2002:a05:7022:ba1:b0:12d:f0e8:9696 with SMTP id a92af1059eb24-1386f237657mr5141962c88.4.1781527164593; Mon, 15 Jun 2026 05:39:24 -0700 (PDT) X-Received: by 2002:a05:7022:ba1:b0:12d:f0e8:9696 with SMTP id a92af1059eb24-1386f237657mr5141931c88.4.1781527163931; Mon, 15 Jun 2026 05:39:23 -0700 (PDT) Received: from [192.168.0.5] ([49.204.111.112]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1384b8f9927sm9787181c88.1.2026.06.15.05.39.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jun 2026 05:39:23 -0700 (PDT) Message-ID: <945821ea-5065-4e20-a1f9-32f7c9adb66a@oss.qualcomm.com> Date: Mon, 15 Jun 2026 18:09:17 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/2] serial: qcom-geni: trace: Add tracepoint support for Qualcomm GENI serial To: Greg Kroah-Hartman Cc: Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Jiri Slaby , konrad.dybcio@oss.qualcomm.com, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, mukesh.savaliya@oss.qualcomm.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com References: <20260526-add-tracepoints-for-qcom-geni-serial-v4-0-e94fbaec0232@oss.qualcomm.com> <20260526-add-tracepoints-for-qcom-geni-serial-v4-1-e94fbaec0232@oss.qualcomm.com> <20260529101422.18dda2ae@fedora> <688f0529-44ea-4cdf-bb0f-6c42cb3fa07e@oss.qualcomm.com> <2026061536-skirmish-nuptials-8fd6@gregkh> Content-Language: en-US From: Praveen Talari In-Reply-To: <2026061536-skirmish-nuptials-8fd6@gregkh> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE1MDEzMyBTYWx0ZWRfX9LMkxvMNc0Rx RLeK2VfLn2KdaaVH/kMaVi8F9uPVA9IDkPTbR1wmynm0pBglLY4ibyoR8oq8+3jgTGsJhUU/fcu YgsQ3pCwVGX8Tt/Qc4tU4FsGfV4z/V8= X-Authority-Analysis: v=2.4 cv=Zqnd7d7G c=1 sm=1 tr=0 ts=6a2ff27d cx=c_pps a=kVLUcbK0zfr7ocalXnG1qA==:117 a=f811rhDWPubbsD7ecTZfYg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=77qTbivRXhmBWYv1PLEA:9 a=QEXdDO2ut3YA:10 a=vr4QvYf-bLy2KjpDp97w:22 X-Proofpoint-GUID: -Fo0s8Gomb0GVKbIUXvyZY8UezYRSG_p X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE1MDEzMyBTYWx0ZWRfX8wsYhNgoLKQo mse6fgb0o/CcreY8pNoy/hU3wFzBOEgZ9eZc3QsPdzpwaWeGEkSoHYtMJltod738YBOmNnBpc8o tB8hs/AV5ZNyGQlQdQ6ctkJqTnzEAQljMB4Zh7vhhpsEvCGbXrL6RkrmAlazVV2f+CYdD2ssew8 0dA+I0d8l8yOYujCA/DDMlHeDZpPAP4fLRmbDwcMZqu43ilXdKooqMoG6lzJ3A+GJqCElhqJidv ihwaw6T4n3gNTNLYTxnAgv5gk2gLXMlUtL1BiQKo3sZxyUb68LuqcNb+t1EBQ7yhEud1iRPhon1 d5V5HMrxjaFgdFXhl2p2AVjrCuFAa5Tei/gBCXN5DuZk2J3wLYc16KvK09Z34oFyVv7R0XJnFyN t4zbYCjGEnb+m6G6hEb0lYcIlgl0JoJ+mU48Nk/CsKBGIrN6LtuA8B946uVuikkMLsXV59xhJZX Wn+/K8/Vqt8bTnPyptQ== X-Proofpoint-ORIG-GUID: -Fo0s8Gomb0GVKbIUXvyZY8UezYRSG_p X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-15_03,2026-06-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 clxscore=1015 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606150133 Hi On 15-06-2026 16:12, Greg Kroah-Hartman wrote: > On Mon, Jun 15, 2026 at 03:26:25PM +0530, Praveen Talari wrote: >> HI Steven, >> >> On 29-05-2026 19:44, Steven Rostedt wrote: >>> On Tue, 26 May 2026 23:07:39 +0530 >>> Praveen Talari wrote: >>> >>>> +DECLARE_EVENT_CLASS(geni_serial_data, >>>> + TP_PROTO(struct device *dev, const u8 *buf, unsigned int len), >>>> + TP_ARGS(dev, buf, len), >>>> + >>>> + TP_STRUCT__entry(__string(name, dev_name(dev)) >>>> + __field(unsigned int, len) >>>> + __dynamic_array(u8, data, len) >>>> + ), >>>> + >>>> + TP_fast_assign(__assign_str(name); >>>> + __entry->len = len; >>>> + memcpy(__get_dynamic_array(data), buf, len); >>>> + ), >>>> + >>>> + TP_printk("%s: len=%u data=%s", >>>> + __get_str(name), __entry->len, >>>> + __print_hex(__get_dynamic_array(data), __entry->len)) >>>> +); >>> No need to save the length of the dynamic array in __entry->len because >>> it's already saved in the metadata of the dynamic array that is stored >>> on the buffer. Instead you can have: >>> >>> DECLARE_EVENT_CLASS(geni_serial_data, >>> TP_PROTO(struct device *dev, const u8 *buf, unsigned int len), >>> TP_ARGS(dev, buf, len), >>> >>> TP_STRUCT__entry(__string(name, dev_name(dev)) >>> __dynamic_array(u8, data, len) >>> ), >>> >>> TP_fast_assign(__assign_str(name); >>> memcpy(__get_dynamic_array(data), buf, len); >>> ), >>> >>> TP_printk("%s: len=%u data=%s", >>> __get_str(name), __entry->len, >>> __print_hex(__get_dynamic_array(data), >>> __get_dynamic_array_len(data))) >>> ); >>> >>> That will save you 4 bytes per event on the ring buffer. And a few >>> cycles not having to store the redundant information. >> This patch has already been accepted and is available in linux-next. > Great, can you send a fixup for it? Or want me to revert this instead? can i add fix patch in same series by removing original patch(0/1)? Thanks, Praveen Talari > > thanks, > > greg k-h