From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f53.google.com (mail-dl1-f53.google.com [74.125.82.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E940726ACC for ; Tue, 24 Mar 2026 23:56:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774396564; cv=none; b=uWpJNh/3f/R6vs+5GlSglvG7m0EWMRdEpPhJZnt8qGQ0kqsHjd1OpqAQqtQidf0ZCSdx84tXKakKLkNFCrcCVWWcxUYnjSqxuA+NULMb3DRvHcxpoChcJwY9NCl46H8s2oQm1K5ofnqpTmkBkGj2FmMoglw+dz4aGh/tOR503kg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774396564; c=relaxed/simple; bh=UKBJ+kC44eNkvuWbhFlfwNEO1faQhVzHZAchOf3nZhQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pTJmXMDy3yzVoRBrGohvJCkOYtPkYEUo53ec7dmFD3e+7ocLIgHGlgfkGtPLmRPMrvYL9gkqWPq7lzWRzanDKmT7s/t9j7aGDYzhj6O/wCGRqQ3CTiWSGYbVEVKZFGIGqoeM4lry02P3UST6fimx2hE0wzub9PlxvYBmPms00Xc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LperUEDn; arc=none smtp.client-ip=74.125.82.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LperUEDn" Received: by mail-dl1-f53.google.com with SMTP id a92af1059eb24-12a71ade78cso2419930c88.0 for ; Tue, 24 Mar 2026 16:56:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774396562; x=1775001362; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CGb7XwT6dZksneWtItSppfi6d0SJR5kEWJ5U/fM6W/0=; b=LperUEDna9sZJCETYmkkj9dCjLv3v1qY6b2/Qrcc0YKRj06UufOa8brWkLs8QVsDkF LoyaDS+7kt2DhPQcxmnA9U5/jn4qKGONx3qn3xMNu6JwE7GXSGOyMjrowDc9gKNeQxE1 4jPXmIMY2k0WGeWIf8SkSpu1/mSSML1K5vsI9Pw9CBQsNK3za6RWRK8DRxD/wWQfgLKI A6tiPkKox6boZpHeKAJ87qTuC+fWdlFK4oOVulncsMSils2Xg9xW6aJYx5WkaldkiKOa aJIQvoBVHL7n5jyezh+RzlgGaQI1buEeeFs4zKubnYjXLRPJ6QTeWGAJKW65mLPpPXpj /nBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774396562; x=1775001362; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CGb7XwT6dZksneWtItSppfi6d0SJR5kEWJ5U/fM6W/0=; b=clVb0CI7JbmOhDKl6Tu6msLdOuDvZpAhkm2qfCosqX8tbR1ZMh+HIEsQzA6AY2q6eh 6Nqd6mz4wcUkEAuI23vWh+gEelZP0mWs+JClAMxgKK+c1Qz5McZf4nxeCGSmzHcKfll9 0NwKJgabORRv12/cK5sEoYYIAJY6vsPhkX8g3GrN83CFXnjnUXiFlyVpWJ1VYbxYDz50 yZPFDWsl/MeN8XVPWp5A43XH+Rw4DL5wvLCGtlSi2SzNzpQ12Pe79wMTTg2si8hmGmRe R6AmaVoqfPxLYaX/G7fn+LH1dD2EmglgPNLn++bpSOeK8FaW6q5aQlG8eqltk+CPr6jM PCCg== X-Forwarded-Encrypted: i=1; AJvYcCURZ+UMwyURCJWfhkqwTLpd492q+ZrpIZ28UkOKXyggIuHFMV4kmzu5DXi4QSS1WZj4eXikX4MwcekFcY0=@vger.kernel.org X-Gm-Message-State: AOJu0YwHudMGfqWrsImH8PrekBrlviVmSV9KEix3vEOSfcBSL0ZOjcQ0 ZzARmYaql0isA87D8ij8Z+bctmixO0e1A1HB5Cn6wOOoe/KDBKc2aey5 X-Gm-Gg: ATEYQzwqHZLnLerjjH51Ibfz9f5gpOpjs+9ItOOQuOIjopAFDs1WaAjQWbtlFi7Toc5 DLQb4gO0akP9Y7Msrv/wjTW2WBVi1Zj98Vs6SYKeO80V2Nr752JyRhL09jWTEJQnz21qR8MNTL2 b0gqVgkU0gHeQ9dUoT0QmcdnoPed5C/1e2t/mzcXsSvP0+tBNfu3lS9mx04Z2Kye20wxbzhmYfj HWE8d2tZMlzJePHKC9NqTEhOgAikJNeZnvWbl1/0sOBMC6GvVFwI0cFf22EuSNeeU99eO7TYoEj DBrTTpNmBLmru574r3No9P5LqpwVpsotyrepBudrRVIdD38N2udoul7OYjlCUWC/FoDfLd2socd SUuRjfzlCNZo4rjWwkl3UNW28hYxq7ou94+OZwPvPSFfXCNh6mpXjvKoYoGwzO8k1LbxUP6oiiG Fd2a+Csj2JczUDK56t4kKNHYGXsSobXVxlF4IEcD4lNpuD7c7NCa6wbyxsUDh8gujOOhINO7Sz X-Received: by 2002:a05:7022:688e:b0:123:3488:899c with SMTP id a92af1059eb24-12a96eff7c7mr646452c88.40.1774396562027; Tue, 24 Mar 2026 16:56:02 -0700 (PDT) Received: from [10.69.65.75] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12a7330d1c5sm11716427c88.0.2026.03.24.16.56.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Mar 2026 16:56:01 -0700 (PDT) Message-ID: <945a3e98-ee75-453c-ae80-f3c9e3e57e58@gmail.com> Date: Tue, 24 Mar 2026 16:55:29 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] nvme: Move nvme_setup_cmd before hot_pathing To: hmi.jeon@samsung.com, "kbusch@kernel.org" , "axboe@kernel.dk" Cc: "sven@kernel.org" , "j@jannau.net" , "neal@gompa.dev" , "hch@lst.de" , "sagi@grimberg.me" , "justin.tee@broadcom.com" , "nareshgottumukkala83@gmail.com" , "paul.ely@broadcom.com" , "kch@nvidia.com" , "linux-arm-kernel@lists.infradead.org" , "linux-nvme@lists.infradead.org" , "asahi@lists.linux.dev" , "linux-kernel@vger.kernel.org" References: <20260320052101epcms2p42ae135da60b36685e9b7fca6849b57a6@epcms2p4> Content-Language: en-US From: Justin Tee In-Reply-To: <20260320052101epcms2p42ae135da60b36685e9b7fca6849b57a6@epcms2p4> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Minsik, > diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c > index e1bb4707183c..8ea37102a836 100644 > --- a/drivers/nvme/host/fc.c > +++ b/drivers/nvme/host/fc.c > @@ -2762,14 +2762,14 @@ nvme_fc_queue_rq(struct blk_mq_hw_ctx *hctx, >         u32 data_len; >         blk_status_t ret; > > -       if (ctrl->rport->remoteport.port_state != FC_OBJSTATE_ONLINE || > -           !nvme_check_ready(&queue->ctrl->ctrl, rq, queue_ready)) > -               return nvme_fail_nonready_command(&queue->ctrl->ctrl, rq); > - >         ret = nvme_setup_cmd(ns, rq); >         if (ret) >                 return ret; > > +       if (ctrl->rport->remoteport.port_state != FC_OBJSTATE_ONLINE || > +           !nvme_check_ready(&queue->ctrl->ctrl, rq, queue_ready)) > +               return nvme_fail_nonready_command(&queue->ctrl->ctrl, rq); > + __nvme_check_ready() checks for (nvme_req(req)->flags & NVME_REQ_USERCMD).  In nvme_setup_cmd(), nvme_clear_nvme_request() clears the nvme_req(req)->flags when RQF_DONTPREP is not set. Is it possible that this patch would have nvme_setup_cmd() erase a nvme_req(req)’s NVME_REQ_USERCMD flag before __nvme_check_ready() is called for each respective .queue_rq? Regards, Justin Tee