From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5F911EB1AF for ; Fri, 7 Feb 2025 15:23:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738941797; cv=none; b=AtP91DJl+im2Xj4QCfjUMbysXJpWXvv0coGalrNjGot5Eawg67kadnH41oRrkOO3FtvuaEnefExFbrLdmhZyyCaFARri+J+1nhfLVw8usu3NajqswAKZFX0vWUk/KoOpygOwJX5uNdosMGkYfWx9sS6DOy41La7cZgwKVZjuWw4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738941797; c=relaxed/simple; bh=JDDbmK++u5Zrrl9i4wETB+fZ6+WtylkQrpDbOxAMbWI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=u/YXVOAJP9Fi3PuVpwcgsDCZ3Rk5hxGjUb9jkHAEKK8R09lBNmWvTEE+hzI1UFO4Aqgi35dr4DZ3191+M56OzkI74Ql2eh/yZmO7jiuRmVOcNxYGts+hSddIDJr9Tttu6x4aVrtSEmhzrKGq8L6fSvBO/zSng0SF59KX1BCocp8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=dL5tXQN9; arc=none smtp.client-ip=209.85.167.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="dL5tXQN9" Received: by mail-oi1-f173.google.com with SMTP id 5614622812f47-3ee29277d44so1278382b6e.1 for ; Fri, 07 Feb 2025 07:23:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738941795; x=1739546595; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pKN8sjRb3wgYxS8vD82nCdPhJYpZegmXytH3ZuvLDaU=; b=dL5tXQN99tpWF8iJr8PDD/x7JBvxCw1n0YxRCcqPSFnvPpC7pz3PL/hYn91vWQB0Lt PZ+YGjJPRvMOtCt8XuOsWuFMiBIr2RD5IvXR6mjqKscso6rFMGbhNJ1G5MGrXATFbpfa VRbiSVly/+dXXwGwD1F+9fcauRK/lcPtiyKuMiFGHGzuW5dhBj3e3WC6bCiqAoyuOliI TzBamMlWWZOQmTpDeCDQ2jegAqduAHVG1KqRiD/u6gqi6cFOo8bwhGGFnLZUJxCbVubd OMzJuQnB26STASsbn1P2y5yqqihWcI+LVXiQ57JzNDbcJB8FV+q3D1HXZajrsTQxKz0A d1YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738941795; x=1739546595; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pKN8sjRb3wgYxS8vD82nCdPhJYpZegmXytH3ZuvLDaU=; b=h0fLVOcV5XRrMBnPqCxHnac4jsEsI7rsceNDbrS75zw9PGXJs3FHO4KYzQGHXwPAFq ua55m0u6gWO0EPk6o66MSYj4wI6WvpCncDWYmkeCGqn9V+ZW0NUuYTWj8vb145uSS625 GuzbHcyjHcpuv7EuGNHp1WeqoTOwwsiQLm3xBdjKPNK9cIEUglsVu55XuXGmnxClmDbC a2sY/3LXZ88OxdryT6dpN627KSML/kcZS+ATlMzuq2YfbynuFRSIWtdNUOKqP12FNwUN 9CGuGwLZvkbluClof1pBhQp6Y2RWYe4T6hl5Bty/y713z0jVE7/6JZVyJAOZnV1V0reH dBbQ== X-Forwarded-Encrypted: i=1; AJvYcCX6WVmcG/oQ2dy3w6Ruhh/w0Y92eIEa1JnXUNK+7Y2HQ2pVvZSVnu4qwX83ZmFqyAH1AOXjzdD05jIVx/0=@vger.kernel.org X-Gm-Message-State: AOJu0YwPGoG0nhCO+ypwEDOphzWSfQUyPLQVsxKwL5jc6lagLPSNG69r gNsR/65I6XIHnCriWW3w326k+QVxi8aTZoZE3n2F77cxoADTDrpnG/76lhUef2/czQn9Z5ck/5X y X-Gm-Gg: ASbGnct9Jwa4qRzEYd6KxHOcUmChxB2i56B7UbqAaI/2RBrO23hmYnMcO0JlJ9VN8hi BAucncwiQuhZiV0F713tLpVltI8LCKsKd8xKCvQCgHMK5EaPUG2Augt4WALCAWdyp1qviqDKnof XRdivSLzrF3qlZnWur46XmHVzs6I8HinLl3+P9U4RwZHJWEgpn50jsB3aUVblWTNq2ujEGGOQXJ buuO5+yRSbOf6hO1p9i1JUkNQMx+SP5ov5Mnv26wrKwyXKdy9Qj5bbRszfKFGzT7u5lTZLAAUzz Vb/hISG5bfo5dG0o22iTVdy6WnwVL2XN+5+s6aQyOqEuppVl3dRG X-Google-Smtp-Source: AGHT+IEEGiDMzanhY46VT0zPfUJ5PNu5OgiAyh3A5rsLRVIHkXKzWkfKjdhXcmoVPsTyGbzMvvecNA== X-Received: by 2002:a05:6870:169d:b0:29e:4340:b1b with SMTP id 586e51a60fabf-2b83ed06682mr2385084fac.9.1738941794664; Fri, 07 Feb 2025 07:23:14 -0800 (PST) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b826261c16sm829675fac.40.2025.02.07.07.23.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Feb 2025 07:23:13 -0800 (PST) Message-ID: <945b338c-8fe1-4082-a20f-57f8152e8f80@baylibre.com> Date: Fri, 7 Feb 2025 09:23:11 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 05/13] gpio: max3191x: use gpiod_multi_set_value_cansleep To: Andy Shevchenko Cc: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?UTF-8?Q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org References: <20250206-gpio-set-array-helper-v2-0-1c5f048f79c3@baylibre.com> <20250206-gpio-set-array-helper-v2-5-1c5f048f79c3@baylibre.com> From: David Lechner Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 2/7/25 4:34 AM, Andy Shevchenko wrote: > On Fri, Feb 7, 2025 at 12:48 AM David Lechner wrote: >> >> Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of >> gpiod_set_array_value_cansleep(). > > It seems you missed my comment. Yes, I must have been sleeping on the job. :-/ > >> +static void gpiod_set_array_single_value_cansleep(struct gpio_descs *descs, >> int value) > > This is not good namespacing. Can we change this while at it? sure > > max3191x_... > > (I would go with max3191x_set_modesel_pins() to make it shorter. I > have no clue why the function repeats so much from gpiod API naming. > Is there anything else which is named in a similar way? Perhaps fix it > by a separate patch?) >