From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36E53C282CE for ; Tue, 4 Jun 2019 19:21:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0EE972070B for ; Tue, 4 Jun 2019 19:21:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726422AbfFDTVX (ORCPT ); Tue, 4 Jun 2019 15:21:23 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:44130 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726179AbfFDTVX (ORCPT ); Tue, 4 Jun 2019 15:21:23 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: ezequiel) with ESMTPSA id 7052C281D9F Message-ID: <9460817290d5846a34b81470b15ac36d88a08aad.camel@collabora.com> Subject: Re: [PATCH v12] dm: add support to directly boot to a mapped device From: Ezequiel Garcia To: Helen Koike , Stephen Boyd , dm-devel@redhat.com Cc: wad@chromium.org, keescook@chromium.org, snitzer@redhat.com, linux-doc@vger.kernel.org, richard.weinberger@gmail.com, linux-kernel@vger.kernel.org, linux-lvm@redhat.com, enric.balletbo@collabora.com, kernel@collabora.com, agk@redhat.com Date: Tue, 04 Jun 2019 16:21:10 -0300 In-Reply-To: References: <20190221203334.24504-1-helen.koike@collabora.com> <5cf5a724.1c69fb81.1e8f0.08fb@mx.google.com> Organization: Collabora Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stephen, On Tue, 2019-06-04 at 14:38 -0300, Helen Koike wrote: > Hi Stephen, > > On 6/3/19 8:02 PM, Stephen Boyd wrote: > > Quoting Helen Koike (2019-02-21 12:33:34) > > > Add a "create" module parameter, which allows device-mapper targets to be > > > configured at boot time. This enables early use of dm targets in the boot > > > process (as the root device or otherwise) without the need of an initramfs. > > > > > > The syntax used in the boot param is based on the concise format from the > > > dmsetup tool to follow the rule of least surprise: > > > > > > sudo dmsetup table --concise /dev/mapper/lroot > > > > > > Which is: > > > dm-mod.create=,,,,[,
+][;,,,,
[,
+]+] > > > > > > Where, > > > ::= The device name. > > > ::= xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx | "" > > > ::= The device minor number | "" > > > ::= "ro" | "rw" > > >
::= > > > ::= "verity" | "linear" | ... > > > > > > For example, the following could be added in the boot parameters: > > > dm-mod.create="lroot,,,rw, 0 4096 linear 98:16 0, 4096 4096 linear 98:32 0" root=/dev/dm-0 > > > > > > Only the targets that were tested are allowed and the ones that doesn't > > > change any block device when the dm is create as read-only. For example, > > > mirror and cache targets are not allowed. The rationale behind this is > > > that if the user makes a mistake, choosing the wrong device to be the > > > mirror or the cache can corrupt data. > > > > > > The only targets allowed are: > > > * crypt > > > * delay > > > * linear > > > * snapshot-origin > > > * striped > > > * verity > > > > > > Co-developed-by: Will Drewry > > > Co-developed-by: Kees Cook > > > Co-developed-by: Enric Balletbo i Serra > > > Signed-off-by: Helen Koike > > > > > > --- > > > > > > > I'm trying to boot a mainline linux kernel on a chromeos device with dm > > verity and a USB stick but it's not working for me even with this patch. > > I've had to hack around two problems: > > > > 1) rootwait isn't considered > > > > 2) verity doesn't seem to accept UUID for or > > > > For the first problem, it happens every boot for me because I'm trying > > to boot off of a USB stick and it's behind a hub that takes a few > > seconds to enumerate. If I hack up the code to call dm_init_init() after > > the 'rootdelay' cmdline parameter is used then I can make this work. It > > would be much nicer if the whole mechanism didn't use a late initcall > > though. If it used a hook from prepare_namespace() and then looped > > waiting for devices to create when rootwait was specified it would work. > > The patch was implemented with late initcall partially to be contained > in drivers/md/*, but to support rootwait, adding a hook from > prepare_namespace seems the way to go indeed. > Thanks for bringing this up. Helen and I have been looking at this code, and we think it's possible to move things around and add some helpers, so we can implement rootwait behavior, without actually cluttering init/do_mounts.c. And along the way, we might get the chance to clean-up this code even further. Regards, Eze