From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 919F1C4167B for ; Mon, 27 Nov 2023 05:59:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229809AbjK0F7F (ORCPT ); Mon, 27 Nov 2023 00:59:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbjK0F7D (ORCPT ); Mon, 27 Nov 2023 00:59:03 -0500 Received: from mail.marcansoft.com (marcansoft.com [212.63.210.85]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1ED9F136 for ; Sun, 26 Nov 2023 21:59:08 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id ADADA42499; Mon, 27 Nov 2023 05:59:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=marcan.st; s=default; t=1701064745; bh=QB9rqf5vjtZTxj6YrVQMoEPk5hNZoTD60Drtq1SmnS0=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=cmEfvlc8StbrONgt6ZkpgMd8fHTKxdbaux+xpi5Q2UuFi8l1eO9m8MbS4dYRYBPp2 YlIbzLqrM2ZBNvqM4WbPx9vuaMlrJjUY6huSfIjUcCa8yIFbBOMw4oTdgkRb80NbUd De/+I7hx8twtw4klptYNOUX57Qfyi8VM4D4blIJutdk1GHTnMsWQsUcThWdTvo3Mon PUjYlcZJhZSzv4HO/3neOHEfD1yZndALyjTrPiMMgStsq5mbMEdcS45/1t2AGicxlq aTQKq46eWu3bDX9FXFniFT7g7zGFHUp7glIgjmKMeeVN8ZwceveLqgHxNlALupPtOF yCL1r1zzsqZ3Q== Message-ID: <94634407-9bbd-4f2d-9d0f-4f02cdfadfa5@marcan.st> Date: Mon, 27 Nov 2023 14:59:00 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] iommu: dart: Use readl instead of readl_relaxed for consistency Content-Language: en-US To: Sven Peter , Joerg Roedel , Will Deacon , Robin Murphy Cc: Alyssa Rosenzweig , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org References: <20231126162009.17934-1-sven@svenpeter.dev> From: Hector Martin In-Reply-To: <20231126162009.17934-1-sven@svenpeter.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/11/27 1:20, Sven Peter wrote: > While the readl_relaxed in apple_dart_suspend is correct the rest of the > driver uses the non-relaxed variants everywhere and the single > readl_relaxed is inconsistent and possibly confusing. > > Signed-off-by: Sven Peter > --- > drivers/iommu/apple-dart.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/apple-dart.c b/drivers/iommu/apple-dart.c > index 59cf256bf40f..c7f047ce0a7a 100644 > --- a/drivers/iommu/apple-dart.c > +++ b/drivers/iommu/apple-dart.c > @@ -1272,7 +1272,7 @@ static __maybe_unused int apple_dart_suspend(struct device *dev) > unsigned int sid, idx; > > for (sid = 0; sid < dart->num_streams; sid++) { > - dart->save_tcr[sid] = readl_relaxed(dart->regs + DART_TCR(dart, sid)); > + dart->save_tcr[sid] = readl(dart->regs + DART_TCR(dart, sid)); > for (idx = 0; idx < dart->hw->ttbr_count; idx++) > dart->save_ttbr[sid][idx] = > readl(dart->regs + DART_TTBR(dart, sid, idx)); Acked-by: Hector Martin - Hector