From: Fan Gong <gongfan1@huawei.com>
To: Fan Gong <gongfan1@huawei.com>, Wu Di <wudi234@huawei.com>,
Teng Peisen <tengpeisen@huawei.com>, <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Mohsin Bashir <mohsin.bashr@gmail.com>,
Dimitri Daskalakis <dimitri.daskalakis1@gmail.com>,
Harshitha Ramamurthy <hramamurthy@google.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
Chen Anwen <chenanwen@huawei.com>,
He Wei <august.hewei@huawei.com>, luosifu <luosifu@huawei.com>,
Xin Guo <guoxin09@huawei.com>,
Zhou Shuai <zhoushuai28@huawei.com>, Wu Like <wulike1@huawei.com>,
Shi Jing <shijing34@huawei.com>,
Zheng Jiezhen <zhengjiezhen@h-partners.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>
Subject: [PATCH net-next v12 2/8] hinic3: Fix loose success check in rx buffer filling
Date: Mon, 27 Jul 2026 14:54:53 +0800 [thread overview]
Message-ID: <9463522667ee175211c12e8ecd7c81a0a55256b6.1785120952.git.root@localhost.localdomain> (raw)
In-Reply-To: <cover.1785120952.git.root@localhost.localdomain>
Tightens the success criterion for hinic3_rx_fill_buffers() in
hinic3_configure_rxqs().
Co-developed-by: Wu Di <wudi234@huawei.com>
Signed-off-by: Wu Di <wudi234@huawei.com>
Co-developed-by: Teng Peisen <tengpeisen@huawei.com>
Signed-off-by: Teng Peisen <tengpeisen@huawei.com>
Signed-off-by: Fan Gong <gongfan1@huawei.com>
---
drivers/net/ethernet/huawei/hinic3/hinic3_rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/huawei/hinic3/hinic3_rx.c b/drivers/net/ethernet/huawei/hinic3/hinic3_rx.c
index 309ab5901379..389b1c2158be 100644
--- a/drivers/net/ethernet/huawei/hinic3/hinic3_rx.c
+++ b/drivers/net/ethernet/huawei/hinic3/hinic3_rx.c
@@ -541,7 +541,7 @@ int hinic3_configure_rxqs(struct net_device *netdev, u16 num_rq,
rq_associate_cqes(rxq);
pkts = hinic3_rx_fill_buffers(rxq);
- if (!pkts) {
+ if (pkts < rxq->q_mask) {
netdev_err(netdev, "Failed to fill Rx buffer\n");
return -ENOMEM;
}
--
2.54.0
next prev parent reply other threads:[~2026-07-27 6:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 6:54 [PATCH net-next v12 0/8] net: hinic3: PF initialization Fan Gong
2026-07-27 6:54 ` [PATCH net-next v12 1/8] hinic3: Fix drop skb when skb_checksum_help() fails Fan Gong
2026-07-30 11:30 ` Larysa Zaremba
2026-08-05 2:15 ` Fan Gong
2026-08-03 23:07 ` Jakub Kicinski
2026-08-05 2:30 ` Re: [PATCH net-next v12 1/8] hinic3: Fix drop skb when Fan Gong
2026-07-27 6:54 ` Fan Gong [this message]
2026-07-27 16:37 ` [PATCH net-next v12 2/8] hinic3: Fix loose success check in rx buffer filling Mohsin Bashir
2026-07-29 7:44 ` Fan Gong
2026-08-03 23:13 ` Jakub Kicinski
2026-08-05 2:22 ` Fan Gong
2026-07-27 6:54 ` [PATCH net-next v12 3/8] hinic3: Refactor channel state machine for dynamic queue configuration Fan Gong
2026-07-27 6:54 ` [PATCH net-next v12 4/8] hinic3: Add ethtool queue ops Fan Gong
2026-07-27 6:54 ` [PATCH net-next v12 5/8] hinic3: Add ethtool statistic ops Fan Gong
2026-07-27 6:54 ` [PATCH net-next v12 6/8] hinic3: Add ethtool coalesce ops Fan Gong
2026-07-27 6:54 ` [PATCH net-next v12 7/8] hinic3: Add ethtool rss ops Fan Gong
2026-07-27 6:54 ` [PATCH net-next v12 8/8] hinic3: Remove unneeded coalesce parameters Fan Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9463522667ee175211c12e8ecd7c81a0a55256b6.1785120952.git.root@localhost.localdomain \
--to=gongfan1@huawei.com \
--cc=andrew+netdev@lunn.ch \
--cc=august.hewei@huawei.com \
--cc=chenanwen@huawei.com \
--cc=davem@davemloft.net \
--cc=dimitri.daskalakis1@gmail.com \
--cc=edumazet@google.com \
--cc=guoxin09@huawei.com \
--cc=horms@kernel.org \
--cc=hramamurthy@google.com \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luosifu@huawei.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shijing34@huawei.com \
--cc=tengpeisen@huawei.com \
--cc=wudi234@huawei.com \
--cc=wulike1@huawei.com \
--cc=zhengjiezhen@h-partners.com \
--cc=zhoushuai28@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®