From: Michael Ellerman <mpe@ellerman.id.au>
To: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Nicholas Piggin <npiggin@gmail.com>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
Geoff Levand <geoff@infradead.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH RESEND 1/2] powerpc/ps3: Drop redundant result assignment
Date: Wed, 29 Apr 2026 16:03:17 +1000 [thread overview]
Message-ID: <946b79c2-ae4c-40ed-997b-ac654e148d47@ellerman.id.au> (raw)
In-Reply-To: <90c122bc-3067-4e3d-8083-dd94844c31f2@oss.qualcomm.com>
On 28/4/2026 23:22, Krzysztof Kozlowski wrote:
> On 17/03/2026 14:08, Krzysztof Kozlowski wrote:
>> Return value of ps3_start_probe_thread() is not used, so code can be
>> simplified to fix W=1 clang warnings:
>>
>> arch/powerpc/platforms/ps3/device-init.c:953:6: error: variable 'result' set but not used [-Werror,-Wunused-but-set-variable]
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>> ---
>>
>> Resend after ~2.5 months
>>
>> arch/powerpc/platforms/ps3/device-init.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> Ping. This also got a review.
>
> I do not plan to resend second time... And I also understand if this is
> somehow legacy and fixing warnings is not desired, but then it would be
> great if you just responded "don't send such patches" and I would not
> waste my time.
Thanks for the patch, sorry it hasn't been picked up.
I have been AWOL, and I suspect Maddy is not sure about taking PS3
patches directly without hearing from Geoff.
Maddy this is fine to pick up for next.
cheers
next prev parent reply other threads:[~2026-04-29 6:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 13:08 Krzysztof Kozlowski
2026-03-17 13:08 ` [PATCH RESEND 2/2] powerpc/pasemi: Drop redundant res assignment Krzysztof Kozlowski
2026-03-17 14:32 ` [PATCH RESEND 1/2] powerpc/ps3: Drop redundant result assignment Geert Uytterhoeven
2026-03-18 11:51 ` Segher Boessenkool
2026-03-18 11:54 ` Krzysztof Kozlowski
2026-03-18 11:58 ` Segher Boessenkool
2026-03-18 12:03 ` Krzysztof Kozlowski
2026-03-18 12:12 ` Segher Boessenkool
2026-03-18 14:59 ` Krzysztof Kozlowski
2026-03-18 12:21 ` Christophe Leroy (CS GROUP)
2026-03-18 15:00 ` Krzysztof Kozlowski
2026-04-28 13:22 ` Krzysztof Kozlowski
2026-04-29 6:03 ` Michael Ellerman [this message]
2026-04-30 3:38 ` Madhavan Srinivasan
2026-05-11 2:28 ` Madhavan Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=946b79c2-ae4c-40ed-997b-ac654e148d47@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=chleroy@kernel.org \
--cc=geoff@infradead.org \
--cc=justinstitt@google.com \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=llvm@lists.linux.dev \
--cc=maddy@linux.ibm.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®