From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE51C1A5B92 for ; Wed, 11 Jun 2025 15:06:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749654381; cv=none; b=hic9JiWQTg7KAdOStoVrntspqLr8fyvK7NUmLA5ReLKtpJaZY7wzF6b7OBbAazCJiHqKfgpfWfFZgTcnNkJvYFx+lkgeucEB3UraMNkOlVXYX8NV+ERmHZKkh9DLA7GDxeBLSURa3wo4oVEYdCu7Qpu4iB+FbFuOEQ6ueBaTCLc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749654381; c=relaxed/simple; bh=uggfU/x1Y1OnYzacJ5PR1iziE7YguscIhi3wGXEOUqI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sfFVCY9DGftrzsald9G81CWG4I8tFTW3sObxSo2IzkEattVdaU90TtOlEMCyj2hMjfNDkz2eZRovUw3fRS+Z5nk6/V1BFCPuFrKkis9oHDYzBSqWFxvPQsOOqQcGtSnRAbODfP8l64el7+4FTN5hEbTKr55YD99w+jfFpduiBwA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dsAxDEb+; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dsAxDEb+" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55B9DEKE027165 for ; Wed, 11 Jun 2025 15:06:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= S/W6554sM4PStRUOoRj5glqk4SWBmtXAj26sF2oFq9A=; b=dsAxDEb+a0Up/7iQ DkYyHEvfQeibaM4ORr+xG2ilSZyA03pQpA9XG4SyDB+LSzlZsY+3ZQIZyyD4eAbO b8I67SbQPzLPgAXkZlZl06CrJ78YjH6f4C5nw3teaU21tmc5m/uWaJBF9h3DOz80 rOcpTk83WtX+jDZP6W+URQgA7ahE6PZHPM4grcZdFRTjP2bQdSlcclaN7yARmOwb xv/TAuBZvTsJQ9Iez8o+AxsOCZwAM3vN7mpCc+iQxirrqgbFK5wjfS3JcvqdHHwA U0BAztx6r2/zbgh7E7Ze0Qad8Zj9eMJgX/DSxoSd7dqU8M2+Yv9Xc6cHeiXDAE2g YhrsVQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 474ccvdadw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 11 Jun 2025 15:06:18 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7d0976a24ceso21150285a.2 for ; Wed, 11 Jun 2025 08:06:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749654377; x=1750259177; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S/W6554sM4PStRUOoRj5glqk4SWBmtXAj26sF2oFq9A=; b=edolYgtpH4ot92Q+TfohR84F4lMSvVlaNOg8fsPNP/sY8RrD+2MnMQNM8HLsZWY3N3 GptJ6oMIlUNdmpHyTdv9gRDQa10DDkyJ98IMMFjZbMd9xJ7NYtHMRoT7HF/hU7S2DIcX IkWhukPIiYpVgTUtQnsXXD2AB64bizp9I9EHLQwJix4n+Eu7NU7Yn5hCGqGezwj/NhxP Mrjm73DmyYZRoD6roolckZYTLnLdhUm4+giveIe0j85kwfLOovHre0M0Whhvnm08XkwM GA7Z6c51nPUCxeuIkepYxq3NK1xooIxFz/oSKafqdrEmfVzIi6rESDSdosNVcYFOCZVA polw== X-Forwarded-Encrypted: i=1; AJvYcCV6vDQGHh7ZyosZtAkg0RYoTQRa8OveaqC4og1sUgTp8WPP3Gy26dAO7pCnENGrVWIqbs01n5XAfE6oWmg=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2sz0UjYA59C1b1bBjoXbHQ+o4pwwEtQeOM4I7fHlK9VdEVq4B XSdSzzPvF60FSt4AxUnzRPvkcEUkwdK2byxg7C5P2N2lmMSX06gxlLmQrX35ASbvMiQ8UkGW9po DeIOyyk7/r3LVLfSSXuXcswhVwF8Jy06yWF/6cZFjY5Tg7Eq8+E2R06BCX7TPss/N3v0= X-Gm-Gg: ASbGncuadv8Xl6EnnFYW4RzZTbndekREUzg4vRAcGjrr0iDvqXGyQWOhLwAmQmyr3Mc DkqTJbgzIBt//aYhATvzspCEV09B+CHWzJkwp/2AB/lml3p15shKt0zaln+trWn5VPNfzpXi+/5 aBPUhIy0wzH+cTLlns/6PMEJgpdrYEsM6I17zkZ9AdSnnjCOvgfmqyaeJpuhWMB/rCZooTEzkzt F2L0P77mnkunei6Di3Tc4Si2+VoU+X/8AmPUgIug71nvwqpViaqvUdanKkeXFeL8CjYxlYrdOlj QpfALH70LeE5KBqWfg6N18lW6NEcQkgNd9EhdLq+rcKhvGGGRRR7kwJ1wGCd8vMvyx59NDgiKfA EbEU= X-Received: by 2002:a05:620a:29d2:b0:7c5:687f:d79d with SMTP id af79cd13be357-7d3a87f04afmr205897485a.8.1749654377329; Wed, 11 Jun 2025 08:06:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHT1MIvBRTLARWB0wt/VEh6LTMpBio201lRkK2h9aABclFE5ka3MIzIuUcHTp49tOwLuqThGA== X-Received: by 2002:a05:620a:29d2:b0:7c5:687f:d79d with SMTP id af79cd13be357-7d3a87f04afmr205895085a.8.1749654376840; Wed, 11 Jun 2025 08:06:16 -0700 (PDT) Received: from [192.168.143.225] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ade31cc25b7sm832539666b.66.2025.06.11.08.06.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Jun 2025 08:06:15 -0700 (PDT) Message-ID: <946e3208-4783-464a-af58-68c4f79d327c@oss.qualcomm.com> Date: Wed, 11 Jun 2025 17:06:07 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 0/3] media: venus: enable venus on qcs615 To: Krzysztof Kozlowski , Renjiang Han , Bryan O'Donoghue , Dmitry Baryshkov Cc: Vikash Garodia , Dikshita Agarwal , Mauro Carvalho Chehab , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Nicolas Dufresne References: <20250530-add-venus-for-qcs615-v8-0-c0092ac616d0@quicinc.com> <285cae4a-219c-4514-818f-34c8225529de@quicinc.com> <5854a587-aba7-4e71-87f8-249ba00cbc59@linaro.org> <996c9a39-5520-4b43-adfa-06ce29223ba0@quicinc.com> <713b87cb-0003-4ee3-a599-9cd41629bb42@kernel.org> <7aa36a0f-6741-40c2-93f4-036823d245fd@quicinc.com> <247002c0-ee68-4d0d-857a-768bf68bce75@kernel.org> <5b6864a9-f0ee-4bc5-aba2-c165d14b0b75@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <5b6864a9-f0ee-4bc5-aba2-c165d14b0b75@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: l-N0AMuP9a2kd6l7C27GEEymuUYH5lyN X-Authority-Analysis: v=2.4 cv=TsLmhCXh c=1 sm=1 tr=0 ts=68499b6a cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6IFa9wvqVegA:10 a=-sEhWvhX9MohxhsycYcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-GUID: l-N0AMuP9a2kd6l7C27GEEymuUYH5lyN X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjExMDEyNiBTYWx0ZWRfX8/eYrdrmUUFr FXMrMHu1OX1eV3g2rvKc8JyJ8dhD90qIedVOuH3EJUlaABR0F2Mx8jXq65+dJJ+R8qrGSFoWgbY uNrfgUuZdCQdqBGzf/b7W+aYmpFc5ADE1UGwO08qbxkF6Ci0TAAbVxMKb//cHXYyGW85N08m7hF 1DNauJYIuCmFZo5ngohcjWsqCX4GoWC+Qn8Wxsntoswk6+UDSVkpg1jffu+yJgbf/UK5JEjH5tm fpzp3EpPu5n9X2/zxDwB4fGPWosD8hsEczET4SuepCL9kQAg1m83qo2PysIHi7aLAvcJnaHU50D Xn/gyzu9z8Zmv7ospyHWpoWOzj9zVjrEel7J7poZkqqhMpcflOzyRxejrfuUUPYPdp81EVTY9t6 QkREejkTdFUolpxiCWLTjmODFwuSX6MGZ5Xt9tS19BoI/rOUweeghplGGBP0muK/Z2xv5DRL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-11_05,2025-06-10_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 spamscore=0 mlxlogscore=999 impostorscore=0 priorityscore=1501 bulkscore=0 adultscore=0 clxscore=1015 mlxscore=0 malwarescore=0 lowpriorityscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506110126 On 6/7/25 11:46 AM, Krzysztof Kozlowski wrote: > On 06/06/2025 15:32, Renjiang Han wrote: >> >> On 6/6/2025 8:56 PM, Krzysztof Kozlowski wrote: >>> On 06/06/2025 14:51, Renjiang Han wrote: >>>> On 6/6/2025 8:44 PM, Krzysztof Kozlowski wrote: >>>>> On 06/06/2025 14:37, Renjiang Han wrote: >>>>>> On 6/5/2025 8:34 PM, Bryan O'Donoghue wrote: >>>>>>> On 31/05/2025 01:05, Renjiang Han wrote: >>>>>>>>>> Note: >>>>>>>>>> This series consist of DT patches and a venus driver patch. The patch >>>>>>>>>> 1/3, which is venus driver patch, can be picked independently without >>>>>>>>>> having any functional dependency. But patch 2/3 & patch 3/3, which are >>>>>>>>>> DT patches, still depend on [1]. >>>>>>>>> I'd say 2/3 and 3/3 still depend on 1/3, otherwise we can get video >>>>>>>>> core >>>>>>>>> on QCS615 over(?)clocked. >>>>>>>> Agree, so we need to make sure that the driver patch is not picked >>>>>>>> after the DT patch. >>>>>>> This statement is confusing. >>>>>>> >>>>>>> 1/3 states that there will be a fallback if there is no OPP table >>>>>>> present. >>>>>>> >>>>>>> Giving the code a glance, I believe that is so, freq_table should be >>>>>>> used if there is no OPP specified in the DT. >>>>>>> >>>>>>> I think we are having a hard time here understanding what you are saying. >>>>>>> >>>>>>> My understanding: >>>>>>> >>>>>>> - venus modification is standalone 1/3 >>>>>>>   Qcs615 will fallback if no OPP is present >>>>>>> >>>>>>> - dt modification 2/3 3/3 is therefore also independent of driver >>>>>>> >>>>>>> --- >>>>>>> bod >>>>>> yes, let me re-spin this with driver patch alone. Once that gets in, >>>>>> will bring in the DT patches. >>>>> Did you read my feedback? There is no "once that gets in". DTS is an >>>>> independent hardware description and your patchset claiming there is >>>>> dependency is just broken. >>>>> >>>>> I am repeating this since few emails, so shall I NAK it that you will >>>>> address the main issue you have? >>>>> >>>>> Best regards, >>>>> Krzysztof >>>> Hi Krzysztof >>>> >>>> SC7180 and QCS615 use the same video core. Only difference lies in the >>>> freq_table for the video. Freq_table is generally determined at SOC level. >>>> The Venus driver does not currently handle freq_table compatibility well >>>> across platforms. This patch enables the driver to use the OPP-table from >>>> the DT, addressing the frequency compatibility issue. >>> This does not resolve the main problem at all. If SW cannot use the >>> fallback alone, your fallback has no meaning and is not only confusing >>> but actually incorrect. And based on previous statements like >>> "overclocking" it is not only incorrect, but even harmful. >>> >>> Best regards, >>> Krzysztof >> The fallback is only triggered when there is no OPP table in the DT. > > No. I don't think you understand how fallback works. Fallback will be > applied on any QCS615 DTS without front compatible. Please read each other's messages.. Krzysztof refers to the fallback compatible mechanism, which means the proposed QCS615 node will match against the driver containing the sc7180 compatible. BOD refers to the driver falling back to using the hardcoded sc7180 freq_table when the OPP table is absent (which will not be the case for QCS615 since the node will be introduced with an OPP table on day 0). This patchset is okay to merge in proposed order (dt patches a cycle after the venus patch) Konrad