From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01C6CC282DE for ; Mon, 8 Apr 2019 06:03:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C748D20870 for ; Mon, 8 Apr 2019 06:03:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726615AbfDHGDk (ORCPT ); Mon, 8 Apr 2019 02:03:40 -0400 Received: from foss.arm.com ([217.140.101.70]:41432 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726349AbfDHGDk (ORCPT ); Mon, 8 Apr 2019 02:03:40 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9885115BF; Sun, 7 Apr 2019 23:03:39 -0700 (PDT) Received: from [10.162.42.195] (p8cg001049571a15.blr.arm.com [10.162.42.195]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 30A803F59C; Sun, 7 Apr 2019 23:03:31 -0700 (PDT) Subject: Re: [PATCH 6/6] arm64/mm: Enable ZONE_DEVICE To: Ira Weiny , Dan Williams Cc: Robin Murphy , Linux Kernel Mailing List , linux-arm-kernel@lists.infradead.org, Linux MM , Andrew Morton , Will Deacon , Catalin Marinas , Michal Hocko , Mel Gorman , james.morse@arm.com, Mark Rutland , cpandya@codeaurora.org, arunks@codeaurora.org, osalvador@suse.de, Logan Gunthorpe , David Hildenbrand , cai@lca.pw, =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= References: <1554265806-11501-1-git-send-email-anshuman.khandual@arm.com> <1554265806-11501-7-git-send-email-anshuman.khandual@arm.com> <0d72db39-e20d-1cbd-368e-74dda9b6c936@arm.com> <20190408040346.GA26243@iweiny-DESK2.sc.intel.com> From: Anshuman Khandual Message-ID: <946f090f-e048-cb9e-053e-371029fd7ba8@arm.com> Date: Mon, 8 Apr 2019 11:33:35 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190408040346.GA26243@iweiny-DESK2.sc.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/08/2019 09:33 AM, Ira Weiny wrote: > On Sun, Apr 07, 2019 at 03:11:00PM -0700, Dan Williams wrote: >> On Thu, Apr 4, 2019 at 2:47 AM Robin Murphy wrote: >>> >>> On 04/04/2019 06:04, Dan Williams wrote: >>>> On Wed, Apr 3, 2019 at 9:42 PM Anshuman Khandual >>>> wrote: >>>>> >>>>> >>>>> >>>>> On 04/03/2019 07:28 PM, Robin Murphy wrote: >>>>>> [ +Dan, Jerome ] >>>>>> >>>>>> On 03/04/2019 05:30, Anshuman Khandual wrote: >>>>>>> Arch implementation for functions which create or destroy vmemmap mapping >>>>>>> (vmemmap_populate, vmemmap_free) can comprehend and allocate from inside >>>>>>> device memory range through driver provided vmem_altmap structure which >>>>>>> fulfils all requirements to enable ZONE_DEVICE on the platform. Hence just >>>>>> >>>>>> ZONE_DEVICE is about more than just altmap support, no? >>>>> >>>>> Hot plugging the memory into a dev->numa_node's ZONE_DEVICE and initializing the >>>>> struct pages for it has stand alone and self contained use case. The driver could >>>>> just want to manage the memory itself but with struct pages either in the RAM or >>>>> in the device memory range through struct vmem_altmap. The driver may not choose >>>>> to opt for HMM, FS DAX, P2PDMA (use cases of ZONE_DEVICE) where it may have to >>>>> map these pages into any user pagetable which would necessitate support for >>>>> pte|pmd|pud_devmap. >>>> >>>> What's left for ZONE_DEVICE if none of the above cases are used? >>>> >>>>> Though I am still working towards getting HMM, FS DAX, P2PDMA enabled on arm64, >>>>> IMHO ZONE_DEVICE is self contained and can be evaluated in itself. >>>> >>>> I'm not convinced. What's the specific use case. >>> >>> The fundamental "roadmap" reason we've been doing this is to enable >>> further NVDIMM/pmem development (libpmem/Qemu/etc.) on arm64. The fact >>> that ZONE_DEVICE immediately opens the door to the various other stuff >>> that the CCIX folks have interest in is a definite bonus, so it would >>> certainly be preferable to get arm64 on par with the current state of >>> things rather than try to subdivide the scope further. >>> >>> I started working on this from the ZONE_DEVICE end, but got bogged down >>> in trying to replace my copied-from-s390 dummy hot-remove implementation >>> with something proper. Anshuman has stepped in to help with hot-remove >>> (since we also have cloud folks wanting that for its own sake), so is >>> effectively coming at the problem from the opposite direction, and I'll >>> be the first to admit that we've not managed the greatest job of meeting >>> in the middle and coordinating our upstream story; sorry about that :) >>> >>> Let me freshen up my devmap patches and post them properly, since that >>> discussion doesn't have to happen in the context of hot-remove; they're >>> effectively just parallel dependencies for ZONE_DEVICE. >> >> Sounds good. It's also worth noting that Ira's recent patches for >> supporting get_user_pages_fast() for "longterm" pins relies on >> PTE_DEVMAP to determine when fast-GUP is safe to proceed, or whether >> it needs to fall back to slow-GUP. So it really is the case that >> "devmap" support is an assumption for ZONE_DEVICE. > > Could you cc me on the patches when you post? Sure will do.