mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Richard GENOUD <richard.genoud@bootlin.com>
To: Hari.PrasathGE@microchip.com, cvam0000@gmail.com
Cc: alexandre.belloni@bootlin.com, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	claudiu.beznea@tuxon.dev, jirislaby@kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] Typo: Fix typo in atmel_serial.c
Date: Tue, 5 Nov 2024 14:10:02 +0100	[thread overview]
Message-ID: <94726cb7-7cd5-48cf-b158-a66e6b279058@bootlin.com> (raw)
In-Reply-To: <5933bb3c-3b1e-4579-88c6-b9bbbed93a4f@microchip.com>

Le 05/11/2024 à 13:18, Hari.PrasathGE@microchip.com a écrit :
> Hi,
> 
> On 10/24/24 10:53 PM, Shivam Chaudhary wrote:
>> [You don't often get email from cvam0000@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>>
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> Corrected minor typo in atmel_serial.c
>> - Fixed "retreives" to "retrieves"
>>
> 
> Pls fix the subject line. Refer to the previous commits from the git log
> of the same file. Also,the commit message should be in imperative mood.
> Send a v2 with the above comments addressed. Some useful links below:
> 
> https://kernelnewbies.org/FirstKernelPatch
> https://kernelnewbies.org/PatchPhilosophy

And for this kind of patches, I think it should go through the 
kernel-janitors ML.

Regards,
Richard
> 
> Regards,
> Hari
> 
>> Signed-off-by: Shivam Chaudhary <cvam0000@gmail.com>
>> ---
>>    drivers/tty/serial/atmel_serial.c | 2 +-
>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
>> index 09b246c9e389..bb1978db6939 100644
>> --- a/drivers/tty/serial/atmel_serial.c
>> +++ b/drivers/tty/serial/atmel_serial.c
>> @@ -1166,7 +1166,7 @@ static void atmel_rx_from_dma(struct uart_port *port)
>>                   port->icount.rx += count;
>>           }
>>
>> -       /* USART retreives ownership of RX DMA buffer */
>> +       /* USART retrieves ownership of RX DMA buffer */
>>           dma_sync_single_for_device(port->dev, atmel_port->rx_phys,
>>                                      ATMEL_SERIAL_RX_SIZE, DMA_FROM_DEVICE);
>>
>> --
>> 2.34.1
>>
>>


  reply	other threads:[~2024-11-05 13:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-24 17:23 Shivam Chaudhary
2024-11-05 12:18 ` Hari.PrasathGE
2024-11-05 13:10   ` Richard GENOUD [this message]
2024-11-05 15:02     ` Shivam Chaudhary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=94726cb7-7cd5-48cf-b158-a66e6b279058@bootlin.com \
    --to=richard.genoud@bootlin.com \
    --cc=Hari.PrasathGE@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=cvam0000@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®