From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: Gao Xiang <hsiangkao@linux.alibaba.com>
Cc: linux-erofs@lists.ozlabs.org, xiang@kernel.org, chao@kernel.org,
huyue2@coolpad.com, jefflexu@linux.alibaba.com,
joneslee@google.com, linux-kernel@vger.kernel.org
Subject: Re: BUG: unable to handle kernel paging request in z_erofs_decompress_queue
Date: Tue, 20 Dec 2022 17:42:21 +0200 [thread overview]
Message-ID: <947527a5-f345-b7c8-6938-9a8d2863fbac@linaro.org> (raw)
In-Reply-To: <Y5suEZgZn6JNIKxm@B-P7TQMD6M-0146.local>
Hi, Gao,
On 15.12.2022 16:24, Gao Xiang wrote:
> Hi Tudor,
>
> On Thu, Dec 15, 2022 at 02:58:10PM +0200, Tudor Ambarus wrote:
>> Hi, Gao, Chao, Yue, Jeffle, all,
>>
>> Syzbot reported a bug at [1] that is reproducible in upstream kernel
>> since
>> commit 47e4937a4a7c ("erofs: move erofs out of staging")
>>
>> and up to (inclusively)
>> commit 2bfab9c0edac ("erofs: record the longest decompressed size in this
>> round")
>>
>> The first commit that makes this bug go away is:
>> commit 267f2492c8f7 ("erofs: introduce multi-reference pclusters
>> (fully-referenced)")
>> Although, this commit looks like new support and not like an explicit
>> bug fix.
>>
>> I'd like to fix the lts kernels. I'm happy to try any suggestions or do
>> some tests. Please let me know if the bug rings a bell.
>
> Thanks for your report. I will try to seek time to look at this this
> weekend. But just from your description, I guess that there could be
> something wrong on several compressed extents pointing to the same
> blocks (i.e. the same pcluster). But prior to commit 267f2492c8f7, such
> image is always considered as corrupted images.
>
> Anyway, I will look into that and see if there could be alternative ways
> to fix this rather than backport the whole multi-reference pcluster
> feature. Yet I think no need to worry since such image is pretty
> crafted and should be used as normal images.
I guess to backport the multi-reference pcluster feature is not an
option for stable - just fixes are accepted. If you think it is worth
fixing the problem without adding new support, I can dive into it.
Let me know what you think.
Thanks,
ta
>
> Thanks,
> Gao Xiang
>
>>
>> Thanks,
>> ta
>>
>> [1]
>> https://syzkaller.appspot.com/bug?id=a9b56d324d0de9233ad80633826fac76836d792a
next prev parent reply other threads:[~2022-12-20 15:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 12:58 Tudor Ambarus
2022-12-15 13:07 ` Tudor Ambarus
2022-12-15 14:24 ` Gao Xiang
2022-12-20 15:42 ` Tudor Ambarus [this message]
2022-12-21 2:28 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=947527a5-f345-b7c8-6938-9a8d2863fbac@linaro.org \
--to=tudor.ambarus@linaro.org \
--cc=chao@kernel.org \
--cc=hsiangkao@linux.alibaba.com \
--cc=huyue2@coolpad.com \
--cc=jefflexu@linux.alibaba.com \
--cc=joneslee@google.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®