From: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
To: Ilya Maximets <i.maximets@ovn.org>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Donald Hunter <donald.hunter@gmail.com>,
"Remy D. Farley" <one-d-wide@protonmail.com>,
"Matthieu Baerts (NGI0)" <matttbe@kernel.org>,
Florian Westphal <fw@strlen.de>,
linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH net v2 2/2] netlink: specs: add missing mask attributes for conntrack dump
Date: Thu, 27 Aug 2026 11:04:54 +0000 [thread overview]
Message-ID: <94804df2-4b2d-4b2a-9a4c-9bc09a6a3f1d@fiberby.net> (raw)
In-Reply-To: <20260826220444.4054714-3-i.maximets@ovn.org>
On 8/26/26 10:01 PM, Ilya Maximets wrote:
> 'mark-mask' and 'status-mask' are defined and supported by the
> conntrack dump, but missing from the list of arguments.
>
> While at it, the order of the arguments should follow the order of
> their definition in the enum ctattr_type. That appears to be a common
> convention for other spec files.
>
> Fixes: 23fc9311a526 ("netlink: specs: add conntrack dump and stats dump support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
LGTM, thanks.
Reviewed-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
next prev parent reply other threads:[~2026-08-27 11:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 22:01 [PATCH net v2 0/2] netlink: specs: fixes for conntrack dump filtering Ilya Maximets
2026-08-26 22:01 ` [PATCH net v2 1/2] netlink: specs: fix the conntrack filter type Ilya Maximets
2026-08-27 11:04 ` Asbjørn Sloth Tønnesen
2026-08-26 22:01 ` [PATCH net v2 2/2] netlink: specs: add missing mask attributes for conntrack dump Ilya Maximets
2026-08-27 11:04 ` Asbjørn Sloth Tønnesen [this message]
2026-08-28 23:00 ` [PATCH net v2 0/2] netlink: specs: fixes for conntrack dump filtering patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94804df2-4b2d-4b2a-9a4c-9bc09a6a3f1d@fiberby.net \
--to=ast@fiberby.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=i.maximets@ovn.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matttbe@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=one-d-wide@protonmail.com \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®